Go to file
Bartłomiej Dach e8a394f894
Fix argon volume-aware hitsounds not correctly playing immediately after object placement
Closes https://github.com/ppy/osu/issues/29832.

The underlying reason for the incorrect sample playback was an equality
comparer failure.

Samples are contained in several pools which are managed by the
playfield. In particular, the pools are keyed by `ISampleInfo`
instances. This means that for correct operation, `ISampleInfo` has to
implement `IEquatable<ISampleInfo>` and also provide an appropriately
correct `GetHashCode()` implementation. Different audible samples must
not compare equal to each other when represented by `ISampleInfo`.

As it turns out, `VolumeAwareHitSampleInfo` failed on this, due to not
overriding equality members. Therefore, a `new
HitSampleInfo(HitSampleInfo.HIT_NORMAL, HitSampleInfo.BANK_NORMAL,
volume: 70)` was allowed to compare equal to a
`VolumeAwareHitSampleInfo` wrapping it, *even though they correspond to
completely different sounds and go through entirely different lookup
path sequences*.

Therefore, to fix, provide more proper equality implementations for
`VolumeAwareHitSampleInfo`.

When testing note that this issue *only occurs immediately after
placing an object*. Saving and re-entering editor makes this issue go
away. I haven't looked too long into why, but the general gist of it is
ordering; it appears that a `normal-hitnormal` pool exists at point
of query of a new object placement, but does not seem to exist when
entering editor afresh. That said I'm not sure that ordering aspect of
this bug matters much if at all, since the two `IHitSampleInfo`s should
never be allowed to alias with each other at all wrt equality.
2024-09-23 13:38:26 +02:00
.config
.github
.idea
.run
.vscode
CodeAnalysis
Templates
assets
osu.Android
osu.Desktop Merge pull request #29812 from smallketchup82/add-beatmap-icon 2024-09-14 10:14:30 +09:00
osu.Game Fix argon volume-aware hitsounds not correctly playing immediately after object placement 2024-09-23 13:38:26 +02:00
osu.Game.Benchmarks
osu.Game.Rulesets.Catch Fix rotation not being updated correctly on start time change 2024-09-17 16:18:29 +09:00
osu.Game.Rulesets.Catch.Tests
osu.Game.Rulesets.Catch.Tests.Android
osu.Game.Rulesets.Catch.Tests.iOS
osu.Game.Rulesets.Mania Merge branch 'master' into pp_refactoring_merge_multipliers 2024-09-12 16:22:55 +09:00
osu.Game.Rulesets.Mania.Tests
osu.Game.Rulesets.Mania.Tests.Android
osu.Game.Rulesets.Mania.Tests.iOS
osu.Game.Rulesets.Osu Fix `DrawableOsuHitObject` not properly cleaning up dim application callbacks 2024-09-19 14:30:02 +02:00
osu.Game.Rulesets.Osu.Tests Merge branch 'master' into grids-3 2024-09-19 18:21:05 +09:00
osu.Game.Rulesets.Osu.Tests.Android
osu.Game.Rulesets.Osu.Tests.iOS
osu.Game.Rulesets.Taiko Fix argon volume-aware hitsounds not correctly playing immediately after object placement 2024-09-23 13:38:26 +02:00
osu.Game.Rulesets.Taiko.Tests Add failing test case to demonstrate failure 2024-09-23 13:17:46 +02:00
osu.Game.Rulesets.Taiko.Tests.Android
osu.Game.Rulesets.Taiko.Tests.iOS
osu.Game.Tests Merge pull request #29897 from bdach/editor/setup-screen-slider 2024-09-19 19:07:14 +09:00
osu.Game.Tests.Android
osu.Game.Tests.iOS
osu.Game.Tournament
osu.Game.Tournament.Tests
osu.iOS
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.globalconfig
CONTRIBUTING.md
Directory.Build.props
FodyWeavers.xml
InspectCode.ps1
InspectCode.sh
LICENCE
README.md
UseLocalFramework.ps1
UseLocalFramework.sh
UseLocalResources.ps1
UseLocalResources.sh
app.manifest
appveyor.yml
appveyor_deploy.yml
global.json
osu.Android.props Update framework 2024-09-16 16:15:09 +09:00
osu.Android.slnf
osu.Desktop.slnf
osu.TestProject.props
osu.iOS.props Update framework 2024-09-16 16:15:09 +09:00
osu.iOS.slnf
osu.licenseheader
osu.sln
osu.sln.DotSettings Merge pull request #28743 from smallketchup82/velopack 2024-09-04 16:09:36 +09:00

README.md

osu! logo

osu!

Build status GitHub release CodeFactor dev chat Crowdin

A free-to-win rhythm game. Rhythm is just a click away!

This is the future and final iteration of the osu! game client which marks the beginning of an open era! Currently known by and released under the release codename "lazer". As in sharper than cutting-edge.

Status

This project is under constant development, but we do our best to keep things in a stable state. Players are encouraged to install from a release alongside their stable osu! client. This project will continue to evolve until we eventually reach the point where most users prefer it over the previous "osu!stable" release.

A few resources are available as starting points to getting involved and understanding the project:

Running osu!

If you are just looking to give the game a whirl, you can grab the latest release for your platform:

Latest release:

Windows 10+ (x64) macOS 12+ (Intel, Apple Silicon) Linux (x64) iOS 13.4+ Android 5+

You can also generally download a version for your current device from the osu! site.

If your platform is unsupported or not listed above, there is still a chance you can run the release or manually build it by following the instructions below.

For iOS/iPadOS users: The iOS testflight link fills up very fast (Apple has a hard limit of 10,000 users). We reset it occasionally. Please do not ask about this. Check back regularly for link resets or follow peppy on twitter for announcements. Our goal is to get the game on mobile app stores in early 2024.

Developing a custom ruleset

osu! is designed to allow user-created gameplay variations, called "rulesets". Building one of these allows a developer to harness the power of the osu! beatmap library, game engine, and general UX for a new style of gameplay. To get started working on a ruleset, we have some templates available here.

You can see some examples of custom rulesets by visiting the custom ruleset directory.

Developing osu!

Prerequisites

Please make sure you have the following prerequisites:

When working with the codebase, we recommend using an IDE with intelligent code completion and syntax highlighting, such as the latest version of Visual Studio, JetBrains Rider, or Visual Studio Code with the EditorConfig and C# plugin installed.

Downloading the source code

Clone the repository:

git clone https://github.com/ppy/osu
cd osu

To update the source code to the latest commit, run the following command inside the osu directory:

git pull

Building

From an IDE

You should load the solution via one of the platform-specific .slnf files, rather than the main .sln. This will reduce dependencies and hide platforms that you don't care about. Valid .slnf files are:

  • osu.Desktop.slnf (most common)
  • osu.Android.slnf
  • osu.iOS.slnf

Run configurations for the recommended IDEs (listed above) are included. You should use the provided Build/Run functionality of your IDE to get things going. When testing or building new components, it's highly encouraged you use the osu! (Tests) project/configuration. More information on this is provided below.

To build for mobile platforms, you will likely need to run sudo dotnet workload restore if you haven't done so previously. This will install Android/iOS tooling required to complete the build.

From CLI

You can also build and run osu! from the command-line with a single command:

dotnet run --project osu.Desktop

When running locally to do any kind of performance testing, make sure to add -c Release to the build command, as the overhead of running with the default Debug configuration can be large (especially when testing with local framework modifications as below).

If the build fails, try to restore NuGet packages with dotnet restore.

Testing with resource/framework modifications

Sometimes it may be necessary to cross-test changes in osu-resources or osu-framework. This can be quickly achieved using included commands:

Windows:

UseLocalFramework.ps1
UseLocalResources.ps1

macOS / Linux:

UseLocalFramework.sh
UseLocalResources.sh

Note that these commands assume you have the relevant project(s) checked out in adjacent directories:

|- osu            // this repository
|- osu-framework
|- osu-resources

Code analysis

Before committing your code, please run a code formatter. This can be achieved by running dotnet format in the command line, or using the Format code command in your IDE.

We have adopted some cross-platform, compiler integrated analyzers. They can provide warnings when you are editing, building inside IDE or from command line, as-if they are provided by the compiler itself.

JetBrains ReSharper InspectCode is also used for wider rule sets. You can run it from PowerShell with .\InspectCode.ps1. Alternatively, you can install ReSharper or use Rider to get inline support in your IDE of choice.

Contributing

When it comes to contributing to the project, the two main things you can do to help out are reporting issues and submitting pull requests. Please refer to the contributing guidelines to understand how to help in the most effective way possible.

If you wish to help with localisation efforts, head over to crowdin.

We love to reward quality contributions. If you have made a large contribution, or are a regular contributor, you are welcome to submit an expense via opencollective. If you have any questions, feel free to reach out to peppy before doing so.

Licence

osu!'s code and framework are licensed under the MIT licence. Please see the licence file for more information. tl;dr you can do whatever you want as long as you include the original copyright and license notice in any copy of the software/source.

Please note that this does not cover the usage of the "osu!" or "ppy" branding in any software, resources, advertising or promotion, as this is protected by trademark law.

Please also note that game resources are covered by a separate licence. Please see the ppy/osu-resources repository for clarifications.