osu/osu.Game/Online/Rooms
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
RoomStatuses Better signify private rooms by showing a different status pill design 2024-05-03 17:17:35 +08:00
APICreatedRoom.cs
APILeaderboard.cs
APIScoreToken.cs
BeatmapAvailability.cs
CreateRoomRequest.cs
CreateRoomScoreRequest.cs
GetRoomLeaderboardRequest.cs
GetRoomRequest.cs
GetRoomsRequest.cs Better signify private rooms by showing a different status pill design 2024-05-03 17:17:35 +08:00
IndexedMultiplayerScores.cs
IndexPlaylistScoresRequest.cs
IndexScoresParams.cs
ItemAttemptsCount.cs
JoinRoomRequest.cs
MatchType.cs
MultiplayerPlaylistItem.cs
MultiplayerScore.cs
MultiplayerScores.cs
MultiplayerScoresAround.cs
OnlinePlayBeatmapAvailabilityTracker.cs Make SelectedItem externally mutable 2024-06-10 12:44:38 +02:00
PartRoomRequest.cs
PlaylistAggregateScore.cs
PlaylistExtensions.cs Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
PlaylistItem.cs
Room.cs Add start date to Room 2024-06-12 11:43:18 +02:00
RoomAvailability.cs
RoomCategory.cs Add client/server models & operations for "daily challenge" feature 2024-05-17 10:58:08 +02:00
RoomStatus.cs
ShowPlaylistUserScoreRequest.cs
SubmitRoomScoreRequest.cs
SubmitScoreRequest.cs