mirror of https://github.com/ppy/osu
a9facc076f
In current `master`, the difficulty creation flow would retrieve a "reference beatmap" to copy metadata and timing points from using `GetPlayableBeatmap()`. But, importantly, it was calling that method using *the ruleset of the new difficulty* rather than the ruleset of the existing one. This would make the difficulty creation flow fail if the beatmap couldn't be converted between rulesets (like taiko to catch). Fixing to use the reference beatmap's actual ruleset would be trivial, but there's no real reason to do all of that work anyway when a `WorkingBeatmap` is available. Because getting a playable beatmap is not required to copy across metadata and timing points, remove the `GetPlayableBeatmap()` step entirely to fix the bug. Closes #22145. |
||
|---|---|---|
| .. | ||
| ControlPoints | ||
| Drawables | ||
| Formats | ||
| Legacy | ||
| Timing | ||
| APIFailTimes.cs | ||
| BeatSyncProviderExtensions.cs | ||
| Beatmap.cs | ||
| BeatmapConverter.cs | ||
| BeatmapDifficulty.cs | ||
| BeatmapDifficultyCache.cs | ||
| BeatmapImporter.cs | ||
| BeatmapInfo.cs | ||
| BeatmapInfoExtensions.cs | ||
| BeatmapManager.cs | ||
| BeatmapMetadata.cs | ||
| BeatmapMetadataInfoExtensions.cs | ||
| BeatmapModelDownloader.cs | ||
| BeatmapOnlineChangeIngest.cs | ||
| BeatmapOnlineStatus.cs | ||
| BeatmapProcessor.cs | ||
| BeatmapSetHypeStatus.cs | ||
| BeatmapSetInfo.cs | ||
| BeatmapSetInfoExtensions.cs | ||
| BeatmapSetNominationStatus.cs | ||
| BeatmapSetOnlineAvailability.cs | ||
| BeatmapSetOnlineCovers.cs | ||
| BeatmapSetOnlineGenre.cs | ||
| BeatmapSetOnlineLanguage.cs | ||
| BeatmapSetOnlineNomination.cs | ||
| BeatmapStatistic.cs | ||
| BeatmapStatisticIcon.cs | ||
| BeatmapUpdater.cs | ||
| BeatmapUpdaterMetadataLookup.cs | ||
| BeatmapUserSettings.cs | ||
| CountdownType.cs | ||
| DifficultyRating.cs | ||
| DifficultyRecommender.cs | ||
| DummyWorkingBeatmap.cs | ||
| FlatFileWorkingBeatmap.cs | ||
| FramedBeatmapClock.cs | ||
| IBeatSyncProvider.cs | ||
| IBeatmap.cs | ||
| IBeatmapConverter.cs | ||
| IBeatmapDifficultyInfo.cs | ||
| IBeatmapInfo.cs | ||
| IBeatmapMetadataInfo.cs | ||
| IBeatmapOnlineInfo.cs | ||
| IBeatmapProcessor.cs | ||
| IBeatmapResourceProvider.cs | ||
| IBeatmapSetInfo.cs | ||
| IBeatmapSetOnlineInfo.cs | ||
| IWorkingBeatmap.cs | ||
| IWorkingBeatmapCache.cs | ||
| MetadataUtils.cs | ||
| StarDifficulty.cs | ||
| WorkingBeatmap.cs | ||
| WorkingBeatmapCache.cs | ||