mirror of
https://github.com/ppy/osu
synced 2024-12-14 19:06:07 +00:00
a16c0641b2
This reverts commitf3faad74d5
, reversing changes made to712e7bc7bf
. Several issues arose after migrating to 5.0, including, but possibly not limited to, performance regressions in song select, as well as failures when attempting to save beatmaps after metadata changes in the editor.
174 lines
6.8 KiB
C#
174 lines
6.8 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using NUnit.Framework;
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Audio;
|
|
using osu.Framework.Bindables;
|
|
using osu.Framework.Extensions;
|
|
using osu.Framework.Extensions.TypeExtensions;
|
|
using osu.Framework.Platform;
|
|
using osu.Framework.Screens;
|
|
using osu.Framework.Testing;
|
|
using osu.Framework.Utils;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Overlays.Mods;
|
|
using osu.Game.Rulesets;
|
|
using osu.Game.Rulesets.Catch;
|
|
using osu.Game.Rulesets.Mods;
|
|
using osu.Game.Rulesets.Osu;
|
|
using osu.Game.Rulesets.Osu.Mods;
|
|
using osu.Game.Rulesets.Taiko;
|
|
using osu.Game.Rulesets.Taiko.Mods;
|
|
using osu.Game.Screens.OnlinePlay;
|
|
using osu.Game.Screens.OnlinePlay.Multiplayer;
|
|
using osu.Game.Screens.Select;
|
|
|
|
namespace osu.Game.Tests.Visual.Multiplayer
|
|
{
|
|
public class TestSceneMultiplayerMatchSongSelect : RoomTestScene
|
|
{
|
|
private BeatmapManager manager;
|
|
private RulesetStore rulesets;
|
|
|
|
private List<BeatmapInfo> beatmaps;
|
|
|
|
private TestMultiplayerMatchSongSelect songSelect;
|
|
|
|
[BackgroundDependencyLoader]
|
|
private void load(GameHost host, AudioManager audio)
|
|
{
|
|
Dependencies.Cache(rulesets = new RulesetStore(ContextFactory));
|
|
Dependencies.Cache(manager = new BeatmapManager(LocalStorage, ContextFactory, rulesets, null, audio, host, Beatmap.Default));
|
|
|
|
beatmaps = new List<BeatmapInfo>();
|
|
|
|
for (int i = 0; i < 8; ++i)
|
|
{
|
|
int beatmapId = 10 * 10 + i;
|
|
|
|
int length = RNG.Next(30000, 200000);
|
|
double bpm = RNG.NextSingle(80, 200);
|
|
|
|
beatmaps.Add(new BeatmapInfo
|
|
{
|
|
Ruleset = rulesets.GetRuleset(i % 4),
|
|
OnlineBeatmapID = beatmapId,
|
|
Length = length,
|
|
BPM = bpm,
|
|
BaseDifficulty = new BeatmapDifficulty()
|
|
});
|
|
}
|
|
|
|
manager.Import(new BeatmapSetInfo
|
|
{
|
|
OnlineBeatmapSetID = 10,
|
|
Hash = Guid.NewGuid().ToString().ComputeMD5Hash(),
|
|
Metadata = new BeatmapMetadata
|
|
{
|
|
Artist = "Some Artist",
|
|
Title = "Some Beatmap",
|
|
AuthorString = "Some Author"
|
|
},
|
|
Beatmaps = beatmaps,
|
|
DateAdded = DateTimeOffset.UtcNow
|
|
}).Wait();
|
|
}
|
|
|
|
public override void SetUpSteps()
|
|
{
|
|
base.SetUpSteps();
|
|
|
|
AddStep("reset", () =>
|
|
{
|
|
Ruleset.Value = new OsuRuleset().RulesetInfo;
|
|
Beatmap.SetDefault();
|
|
SelectedMods.SetDefault();
|
|
});
|
|
|
|
AddStep("create song select", () => LoadScreen(songSelect = new TestMultiplayerMatchSongSelect()));
|
|
AddUntilStep("wait for present", () => songSelect.IsCurrentScreen());
|
|
}
|
|
|
|
[Test]
|
|
public void TestBeatmapRevertedOnExitIfNoSelection()
|
|
{
|
|
BeatmapInfo selectedBeatmap = null;
|
|
|
|
AddStep("select beatmap",
|
|
() => songSelect.Carousel.SelectBeatmap(selectedBeatmap = beatmaps.Where(beatmap => beatmap.RulesetID == new OsuRuleset().LegacyID).ElementAt(1)));
|
|
AddUntilStep("wait for selection", () => Beatmap.Value.BeatmapInfo.Equals(selectedBeatmap));
|
|
|
|
AddStep("exit song select", () => songSelect.Exit());
|
|
AddAssert("beatmap reverted", () => Beatmap.IsDefault);
|
|
}
|
|
|
|
[Test]
|
|
public void TestModsRevertedOnExitIfNoSelection()
|
|
{
|
|
AddStep("change mods", () => SelectedMods.Value = new[] { new OsuModDoubleTime() });
|
|
|
|
AddStep("exit song select", () => songSelect.Exit());
|
|
AddAssert("mods reverted", () => SelectedMods.Value.Count == 0);
|
|
}
|
|
|
|
[Test]
|
|
public void TestRulesetRevertedOnExitIfNoSelection()
|
|
{
|
|
AddStep("change ruleset", () => Ruleset.Value = new CatchRuleset().RulesetInfo);
|
|
|
|
AddStep("exit song select", () => songSelect.Exit());
|
|
AddAssert("ruleset reverted", () => Ruleset.Value.Equals(new OsuRuleset().RulesetInfo));
|
|
}
|
|
|
|
[Test]
|
|
public void TestBeatmapConfirmed()
|
|
{
|
|
BeatmapInfo selectedBeatmap = null;
|
|
|
|
AddStep("change ruleset", () => Ruleset.Value = new TaikoRuleset().RulesetInfo);
|
|
AddStep("select beatmap",
|
|
() => songSelect.Carousel.SelectBeatmap(selectedBeatmap = beatmaps.First(beatmap => beatmap.RulesetID == new TaikoRuleset().LegacyID)));
|
|
AddUntilStep("wait for selection", () => Beatmap.Value.BeatmapInfo.Equals(selectedBeatmap));
|
|
AddStep("set mods", () => SelectedMods.Value = new[] { new TaikoModDoubleTime() });
|
|
|
|
AddStep("confirm selection", () => songSelect.FinaliseSelection());
|
|
AddStep("exit song select", () => songSelect.Exit());
|
|
|
|
AddAssert("beatmap not changed", () => Beatmap.Value.BeatmapInfo.Equals(selectedBeatmap));
|
|
AddAssert("ruleset not changed", () => Ruleset.Value.Equals(new TaikoRuleset().RulesetInfo));
|
|
AddAssert("mods not changed", () => SelectedMods.Value.Single() is TaikoModDoubleTime);
|
|
}
|
|
|
|
[TestCase(typeof(OsuModHidden), typeof(OsuModHidden))] // Same mod.
|
|
[TestCase(typeof(OsuModHidden), typeof(OsuModTraceable))] // Incompatible.
|
|
public void TestAllowedModDeselectedWhenRequired(Type allowedMod, Type requiredMod)
|
|
{
|
|
AddStep($"select {allowedMod.ReadableName()} as allowed", () => songSelect.FreeMods.Value = new[] { (Mod)Activator.CreateInstance(allowedMod) });
|
|
AddStep($"select {requiredMod.ReadableName()} as required", () => songSelect.Mods.Value = new[] { (Mod)Activator.CreateInstance(requiredMod) });
|
|
|
|
AddAssert("freemods empty", () => songSelect.FreeMods.Value.Count == 0);
|
|
assertHasFreeModButton(allowedMod, false);
|
|
assertHasFreeModButton(requiredMod, false);
|
|
}
|
|
|
|
private void assertHasFreeModButton(Type type, bool hasButton = true)
|
|
{
|
|
AddAssert($"{type.ReadableName()} {(hasButton ? "displayed" : "not displayed")} in freemod overlay",
|
|
() => songSelect.ChildrenOfType<FreeModSelectOverlay>().Single().ChildrenOfType<ModButton>().All(b => b.Mod.GetType() != type));
|
|
}
|
|
|
|
private class TestMultiplayerMatchSongSelect : MultiplayerMatchSongSelect
|
|
{
|
|
public new Bindable<IReadOnlyList<Mod>> Mods => base.Mods;
|
|
|
|
public new Bindable<IReadOnlyList<Mod>> FreeMods => base.FreeMods;
|
|
|
|
public new BeatmapCarousel Carousel => base.Carousel;
|
|
}
|
|
}
|
|
}
|