osu/osu.Game/Database
Bartłomiej Dach 8c82bb006c
Fix mania score conversion using score V1 accuracy
Partially addresses https://github.com/ppy/osu/discussions/26416

As pointed out in the discussion thread above, the total score
conversion process for mania was using accuracy directly from the
replay. In mania accuracy is calculated differently in score V1 than in
score V2, which meant that scores coming from stable were treated more
favourably (due to weighting GREAT and PERFECT equally).

To fix, recompute accuracy locally and use that for the accuracy
portion.

Note that this will still not be (and cannot be made) 100% accurate, as
in stable score V2, as well as in lazer, hold notes are *two*
judgements, not one as in stable score V1, meaning that full and correct
score statistics are not available without playing back the replay.

The effects of the change can be previewed on the following spreadsheet:

https://docs.google.com/spreadsheets/d/1wxD4UwLjwcr7n9y5Yq7EN0lgiLBN93kpd4gBnAlG-E0/edit#gid=1711190356

Top 5 changed scores with replays:

| score                                                                                                                            | master  | this PR | replay  |
| :------------------------------------------------------------------------------------------------------------------------------- | ------: | ------: | ------: |
| [Outlasted on Uwa!! So Holiday by toby fox [[4K] easy] (0.71\*)](https://osu.ppy.sh/scores/mania/460404716)                      | 935,917 | 927,269 | 920,579 |
| [ag0 on Emotional Uplifting Orchestral by bradbreeck [[4K] Rocket's Normal] (0.76\*)](https://osu.ppy.sh/scores/mania/453133066) | 921,636 | 913,535 | 875,549 |
| [rlarkgus on Zen Zen Zense by Gom (HoneyWorks) [[5K] Normal] (1.68\*)](https://osu.ppy.sh/scores/mania/458368312)                | 934,340 | 926,787 | 918,855 |
| [YuJJun on Harumachi Clover by R3 Music Box [4K Catastrophe] (1.80\*)](https://osu.ppy.sh/scores/mania/548215786)                | 918,606 | 911,111 | 885,454 |
| [Fritte on 45-byou by respon feat. Hatsune Miku & Megpoid [[5K] Normal] (1.52\*)](https://osu.ppy.sh/scores/mania/516079410)     | 900,024 | 892,569 | 907,456 |
2024-01-08 16:38:43 +01:00
..
BeatmapExporter.cs
BeatmapLookupCache.cs
EmptyRealmSet.cs
ICanAcceptFiles.cs
IHasFiles.cs
IHasGuidPrimaryKey.cs
IHasNamedFiles.cs
IHasOnlineID.cs
IHasPrimaryKey.cs
IHasRealmFiles.cs Remove IScoreInfo : IHasNamedFiles inheritance 2023-10-26 14:58:33 +02:00
IModelDownloader.cs
IModelFileManager.cs
IModelImporter.cs
IModelManager.cs
ImportParameters.cs Fix skin editor freezing game if opened during active gameplay 2023-10-27 14:34:30 +02:00
ImportProgressNotification.cs
ImportTask.cs Bring back disposal of stream after copy-out to MemoryStream 2023-09-14 19:36:35 +02:00
INamedFile.cs
INamedFileInfo.cs
INamedFileUsage.cs
IPostNotifications.cs
ISoftDelete.cs
LegacyArchiveExporter.cs
LegacyBeatmapExporter.cs Fix incorrect legacy conversion when B-splines are used 2023-11-20 15:08:58 +09:00
LegacyBeatmapImporter.cs Fix legacy beatmap importer not always handling nested paths correctly 2023-10-03 16:01:17 +09:00
LegacyCollectionImporter.cs
LegacyExporter.cs
LegacyImportManager.cs Extract common method for determining stable import usability of directory 2023-12-15 15:42:19 +01:00
LegacyModelImporter.cs
LegacyScoreExporter.cs
LegacyScoreImporter.cs
LegacySkinExporter.cs
LegacySkinImporter.cs
Live.cs
MemoryCachingComponent.cs
MissingBeatmapNotification.cs Fix notification text sets overwriting each other 2023-09-19 11:12:58 +02:00
ModelDownloader.cs
ModelManager.cs
OnlineLookupCache.cs
RealmAccess.cs Add versioning of local scores 2023-12-21 18:37:15 +09:00
RealmArchiveModelImporter.cs Fix skin editor freezing game if opened during active gameplay 2023-10-27 14:34:30 +02:00
RealmExtensions.cs
RealmFileStore.cs
RealmLive.cs
RealmLiveUnmanaged.cs
RealmObjectExtensions.cs
StandardisedScoreMigrationTools.cs Fix mania score conversion using score V1 accuracy 2024-01-08 16:38:43 +01:00
TooManyDownloadsNotification.cs
UserLookupCache.cs