Go to file
Dean Herbert 87570ed238 Fix incorrect slider stacking on very old beatmaps
Closes https://github.com/ppy/osu/issues/24185

The stable code has had a bug in this logic forever. So we'll need to
reimplement the bug.

Basically, sliders have to have `UpdateCalculations` run in order to
have a correct `Position2` and `EndTime`, but this wasn't being called
in the inner loop before use of `EndTime` at
1531237b63/osu!/GameplayElements/HitObjectManager.cs#L1813.

To fix this, we use `StartTime` in the inner loop to reproduce the bug.
2023-07-12 17:35:03 +09:00
.config
.github
.idea
.run
.vscode
CodeAnalysis
Templates
assets
osu.Android Fix nullability-related warnings in Android project 2023-06-24 17:05:52 +02:00
osu.Desktop Merge pull request #24092 from Susko3/fix-manifest-dpi 2023-07-11 14:12:28 +09:00
osu.Game Merge pull request #24169 from bdach/legacy-score-v2 2023-07-12 12:44:04 +09:00
osu.Game.Benchmarks
osu.Game.Rulesets.Catch Implement back-and-forth conversion of `ModScoreV2` and `LegacyMods` 2023-07-09 16:15:21 +02:00
osu.Game.Rulesets.Catch.Tests Add failing legacy mod conversion test cases 2023-07-09 16:09:25 +02:00
osu.Game.Rulesets.Catch.Tests.Android
osu.Game.Rulesets.Catch.Tests.iOS
osu.Game.Rulesets.Mania Implement back-and-forth conversion of `ModScoreV2` and `LegacyMods` 2023-07-09 16:15:21 +02:00
osu.Game.Rulesets.Mania.Tests Add failing legacy mod conversion test cases 2023-07-09 16:09:25 +02:00
osu.Game.Rulesets.Mania.Tests.Android
osu.Game.Rulesets.Mania.Tests.iOS
osu.Game.Rulesets.Osu Fix incorrect slider stacking on very old beatmaps 2023-07-12 17:35:03 +09:00
osu.Game.Rulesets.Osu.Tests Add failing legacy mod conversion test cases 2023-07-09 16:09:25 +02:00
osu.Game.Rulesets.Osu.Tests.Android
osu.Game.Rulesets.Osu.Tests.iOS
osu.Game.Rulesets.Taiko Implement back-and-forth conversion of `ModScoreV2` and `LegacyMods` 2023-07-09 16:15:21 +02:00
osu.Game.Rulesets.Taiko.Tests Add failing legacy mod conversion test cases 2023-07-09 16:09:25 +02:00
osu.Game.Rulesets.Taiko.Tests.Android
osu.Game.Rulesets.Taiko.Tests.iOS
osu.Game.Tests Merge branch 'master' into verify-drain-time 2023-07-11 23:29:18 +02:00
osu.Game.Tests.Android Fix nullability-related warnings in Android project 2023-06-24 17:05:52 +02:00
osu.Game.Tests.iOS
osu.Game.Tournament Fix tournament bracket parsing regression 2023-07-06 17:17:17 +09:00
osu.Game.Tournament.Tests Rename test step 2023-06-25 17:39:36 +02:00
osu.iOS
.editorconfig Add generated code hints in editorconfig / dotsettings 2023-07-07 22:38:07 +09:00
.git-blame-ignore-revs Add automated commit to blame ignore revs 2023-06-24 01:56:38 +09:00
.gitattributes
.gitignore
.globalconfig
CONTRIBUTING.md
Directory.Build.props
FodyWeavers.xml
InspectCode.ps1
InspectCode.sh
LICENCE
README.md
UseLocalFramework.ps1
UseLocalFramework.sh
UseLocalResources.ps1
UseLocalResources.sh
app.manifest Remove manifest DPI awareness entires 2023-07-01 19:11:48 +02:00
appveyor.yml
appveyor_deploy.yml
global.json
osu.Android.props Update framework 2023-07-10 21:26:20 +09:00
osu.Android.slnf
osu.Desktop.slnf
osu.TestProject.props
osu.iOS.props Update framework 2023-07-10 21:26:20 +09:00
osu.iOS.slnf
osu.licenseheader
osu.sln
osu.sln.DotSettings Add generated code hints in editorconfig / dotsettings 2023-07-07 22:38:07 +09:00

README.md

osu! logo

osu!

Build status GitHub release CodeFactor dev chat Crowdin

A free-to-win rhythm game. Rhythm is just a click away!

The future of osu! and the beginning of an open era! Currently known by and released under the release codename "lazer". As in sharper than cutting-edge.

Status

This project is under constant development, but we aim to keep things in a stable state. Users are encouraged to try it out and keep it installed alongside the stable osu! client. It will continue to evolve to the point of eventually replacing the existing stable client as an update.

IMPORTANT: Gameplay mechanics (and other features which you may have come to know and love) are in a constant state of flux. Game balance and final quality-of-life passes come at the end of development, preceded by experimentation and changes which may potentially reduce playability or usability. This is done in order to allow us to move forward as developers and designers more efficiently. If this offends you, please consider sticking to a stable release of osu!. We are not yet open to heated discussion over game mechanics and will not be using github as a forum for such discussions just yet.

We are accepting bug reports (please report with as much detail as possible and follow the existing issue templates). Feature requests are also welcome, but understand that our focus is on completing the game to feature parity before adding new features. A few resources are available as starting points to getting involved and understanding the project:

Running osu!

If you are looking to install or test osu! without setting up a development environment, you can consume our releases. You can also generally download a version for your current device from the osu! site. Failing that, you may use the links below to download the latest version for your operating system of choice:

Latest release:

Windows 8.1+ (x64) macOS 10.15+ (Intel, Apple Silicon) Linux (x64) iOS 13.4+ Android 5+
  • The iOS testflight link may fill up (Apple has a hard limit of 10,000 users). We reset it occasionally when this happens. Please do not ask about this. Check back regularly for link resets or follow peppy on twitter for announcements of link resets.

If your platform is not listed above, there is still a chance you can manually build it by following the instructions below.

Developing a custom ruleset

osu! is designed to have extensible modular gameplay modes, called "rulesets". Building one of these allows a developer to harness the power of osu! for their own game style. To get started working on a ruleset, we have some templates available here.

You can see some examples of custom rulesets by visiting the custom ruleset directory.

Developing osu!

Please make sure you have the following prerequisites:

When working with the codebase, we recommend using an IDE with intelligent code completion and syntax highlighting, such as the latest version of Visual Studio, JetBrains Rider or Visual Studio Code.

Downloading the source code

Clone the repository:

git clone https://github.com/ppy/osu
cd osu

To update the source code to the latest commit, run the following command inside the osu directory:

git pull

Building

Build configurations for the recommended IDEs (listed above) are included. You should use the provided Build/Run functionality of your IDE to get things going. When testing or building new components, it's highly encouraged you use the VisualTests project/configuration. More information on this is provided below.

  • Visual Studio / Rider users should load the project via one of the platform-specific .slnf files, rather than the main .sln. This will allow access to template run configurations.

You can also build and run osu! from the command-line with a single command:

dotnet run --project osu.Desktop

If you are not interested in debugging osu!, you can add -c Release to gain performance. In this case, you must replace Debug with Release in any commands mentioned in this document.

If the build fails, try to restore NuGet packages with dotnet restore.

Due to a historical feature gap between .NET Core and Xamarin, running dotnet CLI from the root directory will not work for most commands. This can be resolved by specifying a target .csproj or the helper project at build/Desktop.proj. Configurations have been provided to work around this issue for all supported IDEs mentioned above.

Testing with resource/framework modifications

Sometimes it may be necessary to cross-test changes in osu-resources or osu-framework. This can be quickly achieved using included commands:

Windows:

UseLocalFramework.ps1
UseLocalResources.ps1

macOS / Linux:

UseLocalFramework.sh
UseLocalResources.sh

Note that these commands assume you have the relevant project(s) checked out in adjacent directories:

|- osu            // this repository
|- osu-framework
|- osu-resources

Code analysis

Before committing your code, please run a code formatter. This can be achieved by running dotnet format in the command line, or using the Format code command in your IDE.

We have adopted some cross-platform, compiler integrated analyzers. They can provide warnings when you are editing, building inside IDE or from command line, as-if they are provided by the compiler itself.

JetBrains ReSharper InspectCode is also used for wider rule sets. You can run it from PowerShell with .\InspectCode.ps1. Alternatively, you can install ReSharper or use Rider to get inline support in your IDE of choice.

Contributing

When it comes to contributing to the project, the two main things you can do to help out are reporting issues and submitting pull requests. Please refer to the contributing guidelines to understand how to help in the most effective way possible.

If you wish to help with localisation efforts, head over to crowdin.

We love to reward quality contributions. If you have made a large contribution, or are a regular contributor, you are welcome to submit an expense via opencollective. If you have any questions, feel free to reach out to peppy before doing so.

Licence

osu!'s code and framework are licensed under the MIT licence. Please see the licence file for more information. tl;dr you can do whatever you want as long as you include the original copyright and license notice in any copy of the software/source.

Please note that this does not cover the usage of the "osu!" or "ppy" branding in any software, resources, advertising or promotion, as this is protected by trademark law.

Please also note that game resources are covered by a separate licence. Please see the ppy/osu-resources repository for clarifications.