osu/osu.Game.Rulesets.Taiko/Objects
Bartłomiej Dach 6d325651dc
Propagate samples to drum roll/swell ticks for correct playback
In d97daee96b, `DrumSampleTriggerSource`
was changed such that in order to play sounds for the user's inputs, the
bank of the normal sound would always be used.

The problem is that in the case of taiko objects which have nested
objects (swells and drum rolls), the samples were not propagated fully
(drum rolls, where only the finish sample was kept, for the purposes of
determining strongability), or not propagated at all (swells) to ticks.

As ticks of both objects are valid return values of
`GetMostValidHitObject()`, this would lead to the drum making no sounds
if the next object was a drum roll or swell, until that drum roll or
swell was completed. To fix, propagate the full set of samples, so that
`DrumSampleTriggerSource` can retrieve the normal sound to copy the bank
from.

Note that this may not necessarily reproduce prior behaviour. This is
because it is not guaranteed that all realised samples for a given
hitobject have the same bank - some may have been overriden locally on a
given hitobject. Previously, the bank would have been retrieved from the
sample control point, wherein there is only one possible bank to use;
however, when deciding the sound to play on the basis of a constructed
hitobject, it is possible that there are cases wherein the hitnormal
sample was overridden on that given hitobject, and in such cases, this
PR would make samples _play_, but not necessarily the _same_ samples
as prior to #23308.

If that turns out to be the case, this will have to be revisited.
2023-05-21 18:57:01 +02:00
..
Drawables Merge branch 'master' into maximum-judgement-offset-in-hit-object 2023-02-15 14:48:15 +09:00
BarLine.cs Change bindable properties in all HitObjects to be lazily initialised 2022-07-19 05:39:10 +03:00
DrumRoll.cs Propagate samples to drum roll/swell ticks for correct playback 2023-05-21 18:57:01 +02:00
DrumRollTick.cs Move MaximumJudgementOffset to HitObject 2023-01-19 21:23:55 +09:00
Hit.cs Rename GetSampleInfo to better describe what method does 2023-05-17 14:07:48 +09:00
HitType.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IgnoreHit.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
StrongNestedHitObject.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
Swell.cs Propagate samples to drum roll/swell ticks for correct playback 2023-05-21 18:57:01 +02:00
SwellTick.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
TaikoHitObject.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
TaikoStrongableHitObject.cs Rename GetSampleInfo to better describe what method does 2023-05-17 14:07:48 +09:00