mirror of
https://github.com/ppy/osu
synced 2024-12-13 02:17:32 +00:00
f13ca28d5e
Closes https://github.com/ppy/osu/issues/28369.
The reporter of the issue was incorrect; it's not the beat snap grid
that is causing the problem, it's something far stupider than that.
When the current selection changes,
`EditorSelectionHandler.UpdateTernaryStates()` is supposed to update the
state of ternary bindables to reflect the reality of the current
selection. This in turn will fire bindable change callbacks for said
ternary toggles, which heavily use `EditorBeatmap.PerformOnSelection()`.
The thing about that method is that it will attempt to check whether any
changes were actually made to avoid producing empty undo states, *but*
to do this, it must *serialise out the entire beatmap to a stream* and
then *binary equality check that* to determine whether any changes were
actually made:
7b14c77e43/osu.Game/Screens/Edit/EditorChangeHandler.cs (L65-L69)
As goes without saying, this is very expensive and unnecessary, which
leads to stuff like keeping a selection box active while a taiko beatmap
is playing under it dog slow. So to attempt to mitigate that, add
precondition checks to every single ternary callback of this sort to
avoid this serialisation overhead.
And yes, those precondition checks use linq, and that is *still* faster
than not having them.
109 lines
3.7 KiB
C#
109 lines
3.7 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Bindables;
|
|
using osu.Framework.Graphics.UserInterface;
|
|
using osu.Game.Graphics.UserInterface;
|
|
using osu.Game.Rulesets.Edit;
|
|
using osu.Game.Rulesets.Objects;
|
|
using osu.Game.Rulesets.Taiko.Objects;
|
|
using osu.Game.Screens.Edit.Compose.Components;
|
|
|
|
namespace osu.Game.Rulesets.Taiko.Edit
|
|
{
|
|
public partial class TaikoSelectionHandler : EditorSelectionHandler
|
|
{
|
|
private readonly Bindable<TernaryState> selectionRimState = new Bindable<TernaryState>();
|
|
private readonly Bindable<TernaryState> selectionStrongState = new Bindable<TernaryState>();
|
|
|
|
[BackgroundDependencyLoader]
|
|
private void load()
|
|
{
|
|
selectionStrongState.ValueChanged += state =>
|
|
{
|
|
switch (state.NewValue)
|
|
{
|
|
case TernaryState.False:
|
|
SetStrongState(false);
|
|
break;
|
|
|
|
case TernaryState.True:
|
|
SetStrongState(true);
|
|
break;
|
|
}
|
|
};
|
|
|
|
selectionRimState.ValueChanged += state =>
|
|
{
|
|
switch (state.NewValue)
|
|
{
|
|
case TernaryState.False:
|
|
SetRimState(false);
|
|
break;
|
|
|
|
case TernaryState.True:
|
|
SetRimState(true);
|
|
break;
|
|
}
|
|
};
|
|
}
|
|
|
|
public void SetStrongState(bool state)
|
|
{
|
|
if (SelectedItems.OfType<Hit>().All(h => h.IsStrong == state))
|
|
return;
|
|
|
|
EditorBeatmap.PerformOnSelection(h =>
|
|
{
|
|
if (!(h is Hit taikoHit)) return;
|
|
|
|
if (taikoHit.IsStrong != state)
|
|
{
|
|
taikoHit.IsStrong = state;
|
|
EditorBeatmap.Update(taikoHit);
|
|
}
|
|
});
|
|
}
|
|
|
|
public void SetRimState(bool state)
|
|
{
|
|
if (SelectedItems.OfType<Hit>().All(h => h.Type == (state ? HitType.Rim : HitType.Centre)))
|
|
return;
|
|
|
|
EditorBeatmap.PerformOnSelection(h =>
|
|
{
|
|
if (h is Hit taikoHit)
|
|
{
|
|
taikoHit.Type = state ? HitType.Rim : HitType.Centre;
|
|
EditorBeatmap.Update(h);
|
|
}
|
|
});
|
|
}
|
|
|
|
protected override IEnumerable<MenuItem> GetContextMenuItemsForSelection(IEnumerable<SelectionBlueprint<HitObject>> selection)
|
|
{
|
|
if (selection.All(s => s.Item is Hit))
|
|
yield return new TernaryStateToggleMenuItem("Rim") { State = { BindTarget = selectionRimState } };
|
|
|
|
if (selection.All(s => s.Item is TaikoHitObject))
|
|
yield return new TernaryStateToggleMenuItem("Strong") { State = { BindTarget = selectionStrongState } };
|
|
|
|
foreach (var item in base.GetContextMenuItemsForSelection(selection))
|
|
yield return item;
|
|
}
|
|
|
|
public override bool HandleMovement(MoveSelectionEvent<HitObject> moveEvent) => true;
|
|
|
|
protected override void UpdateTernaryStates()
|
|
{
|
|
base.UpdateTernaryStates();
|
|
|
|
selectionRimState.Value = GetStateFromSelection(EditorBeatmap.SelectedHitObjects.OfType<Hit>(), h => h.Type == HitType.Rim);
|
|
selectionStrongState.Value = GetStateFromSelection(EditorBeatmap.SelectedHitObjects.OfType<TaikoStrongableHitObject>(), h => h.IsStrong);
|
|
}
|
|
}
|
|
}
|