osu/osu.Game/Screens/Select
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
..
Carousel Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Details Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
Filter
Leaderboards Fix incorrect CancellationToken being used for inner check during leaderboard updates 2021-11-16 17:41:16 +09:00
Options
BeatmapCarousel.cs Remove usage of key repeat helper method 2021-11-18 13:13:36 +09:00
BeatmapClearScoresDialog.cs Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
BeatmapDeleteDialog.cs Fix a few more "maybe null" inspections 2021-11-04 16:11:23 +09:00
BeatmapDetailArea.cs Rename all remaining cases 2021-10-03 00:55:29 +09:00
BeatmapDetailAreaDetailTabItem.cs
BeatmapDetailAreaLeaderboardTabItem.cs
BeatmapDetailAreaTabControl.cs
BeatmapDetailAreaTabItem.cs
BeatmapDetails.cs Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
BeatmapInfoWedge.cs Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
BeatmapInfoWedgeBackground.cs Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
FilterControl.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
FilterCriteria.cs
FilterQueryParser.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Footer.cs
FooterButton.cs
FooterButtonMods.cs
FooterButtonOptions.cs
FooterButtonRandom.cs
ImportFromStablePopup.cs
LocalScoreDeleteDialog.cs Rename all remaining cases 2021-10-03 00:55:29 +09:00
PlayBeatmapDetailArea.cs Rename all remaining cases 2021-10-03 00:55:29 +09:00
PlaySongSelect.cs Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
SongSelect.cs Update UI cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
WedgeBackground.cs