osu/osu.Game
Bartłomiej Dach 46d3220c07
Isolate sample screens from global mods bindable
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.

The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.

This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
..
Audio
Beatmaps Merge branch 'master' into snapping-tidy-distance 2022-05-05 19:55:55 +09:00
Collections Split out IDialogOverlay to allow for easier testing 2022-04-18 18:36:26 +09:00
Configuration Add migration of song progress setting from config to component 2022-04-27 18:10:58 +09:00
Database Split out INotificationOverlay to allow for easier testing 2022-04-18 20:14:01 +09:00
Extensions Update TimeSpan localisation to use ToLocalisableString 2022-04-28 11:12:50 +03:00
Graphics Merge branch 'mod-overlay/back-button' into mod-overlay/integration 2022-05-07 10:59:30 +02:00
Input Merge branch 'master' into beatmap-selection-keybinding 2022-05-04 16:48:49 +03:00
IO Remove unused binary serialization related code. 2022-04-12 20:29:13 +08:00
IPC
Localisation Add localisable string for difficulty multiplier display 2022-05-07 10:48:15 +02:00
Migrations Add license headers to EF migration files 2022-05-03 14:33:14 +08:00
Models
Online Mark GuestUser as system user via Id for now 2022-05-06 17:37:46 +09:00
Overlays Isolate sample screens from global mods bindable 2022-05-07 21:44:58 +02:00
Performance
Properties
Replays
Rulesets Merge branch 'master' into distance-snapping-test 2022-05-06 17:29:27 +03:00
Scoring
Screens Hardcode hide key handling in ModSelectScreen 2022-05-08 01:35:11 +09:00
Skinning Fix return condition from EnsureMutableSkin not accounting for "failed" imports 2022-04-29 13:46:18 +09:00
Stores Move logging and early return into UndeleteForReuse method itself 2022-04-13 14:33:28 +09:00
Storyboards Add null check guards to unsubscriptions in Dispose() 2022-04-07 21:37:42 +02:00
Tests Implement IOverlayManager in ScreenTestScene 2022-05-05 22:16:55 +02:00
Updater Split out INotificationOverlay to allow for easier testing 2022-04-18 20:14:01 +09:00
Users Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
Utils Move FastRandom to LegacyRandom in osu.Game project 2022-04-28 19:01:21 +09:00
.editorconfig Add localisation length hinting 2022-04-28 19:26:28 +09:00
osu!.res
osu.Game.csproj Update framework 2022-04-30 23:52:36 +09:00
OsuGame.cs Merge branch 'mod-overlay/back-button' into mod-overlay/integration 2022-05-07 10:59:30 +02:00
OsuGameBase_Importing.cs
OsuGameBase.cs
PerformFromMenuRunner.cs Split out INotificationOverlay to allow for easier testing 2022-04-18 20:14:01 +09:00