mirror of
https://github.com/ppy/osu
synced 2024-12-15 19:36:34 +00:00
fe86ee629e
As reported in #12718, it turns out that temporary files from beatmap set downloads performed via the beatmap listing overlay could remain in the user's filesystem even after the download has concluded. The reason for the issue is a failure in component integration. In the case of online downloads, files are first downloaded to a temporary directory (`C:/Temp` or `/tmp`), with a randomly generated filename, which ends in an extension of `.tmp`. On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()` method, which determines whether a file should be deleted after importing. At the time of writing, in the case of beatmap imports the file is only automatically cleaned up if the extension of the file is equal to `.osz`, which was not the case for temporary files. As it turns out, `APIDownloadRequest` has a facility for adjusting the file's extension, via the protected `FileExtension` property. Therefore, use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`, which then will make sure that the `ShouldDeleteArchive()` check in `BeatmapManager` picks it up for clean-up. |
||
|---|---|---|
| .. | ||
| Responses | ||
| CommentVoteRequest.cs | ||
| CreateChannelRequest.cs | ||
| CreateNewPrivateMessageRequest.cs | ||
| CreateNewPrivateMessageResponse.cs | ||
| Cursor.cs | ||
| DownloadBeatmapSetRequest.cs | ||
| DownloadReplayRequest.cs | ||
| GetBeatmapRequest.cs | ||
| GetBeatmapSetRequest.cs | ||
| GetChangelogBuildRequest.cs | ||
| GetChangelogRequest.cs | ||
| GetCommentsRequest.cs | ||
| GetCountriesResponse.cs | ||
| GetCountryRankingsRequest.cs | ||
| GetFriendsRequest.cs | ||
| GetMessagesRequest.cs | ||
| GetNewsRequest.cs | ||
| GetNewsResponse.cs | ||
| GetRankingsRequest.cs | ||
| GetScoresRequest.cs | ||
| GetSeasonalBackgroundsRequest.cs | ||
| GetSpotlightRankingsRequest.cs | ||
| GetSpotlightRankingsResponse.cs | ||
| GetSpotlightsRequest.cs | ||
| GetTopUsersRequest.cs | ||
| GetTopUsersResponse.cs | ||
| GetUpdatesRequest.cs | ||
| GetUpdatesResponse.cs | ||
| GetUserBeatmapsRequest.cs | ||
| GetUserKudosuHistoryRequest.cs | ||
| GetUserMostPlayedBeatmapsRequest.cs | ||
| GetUserRankingsRequest.cs | ||
| GetUserRecentActivitiesRequest.cs | ||
| GetUserRequest.cs | ||
| GetUserScoresRequest.cs | ||
| GetUsersRequest.cs | ||
| GetUsersResponse.cs | ||
| JoinChannelRequest.cs | ||
| LeaveChannelRequest.cs | ||
| ListChannelsRequest.cs | ||
| MarkChannelAsReadRequest.cs | ||
| PaginatedAPIRequest.cs | ||
| PostBeatmapFavouriteRequest.cs | ||
| PostMessageRequest.cs | ||
| ResponseWithCursor.cs | ||
| SearchBeatmapSetsRequest.cs | ||
| SearchBeatmapSetsResponse.cs | ||