mirror of
https://github.com/ppy/osu
synced 2024-12-16 03:45:46 +00:00
ffc7eaa3f2
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
161 lines
5.1 KiB
C#
161 lines
5.1 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using NUnit.Framework;
|
|
using osu.Framework.Bindables;
|
|
using osu.Framework.Graphics;
|
|
using osu.Framework.Utils;
|
|
using osu.Framework.Testing;
|
|
using osu.Framework.Timing;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Rulesets.Judgements;
|
|
using osu.Game.Rulesets.Objects;
|
|
using osu.Game.Rulesets.Scoring;
|
|
using osu.Game.Tests.Visual;
|
|
|
|
namespace osu.Game.Tests.Gameplay
|
|
{
|
|
[HeadlessTest]
|
|
public class TestSceneDrainingHealthProcessor : OsuTestScene
|
|
{
|
|
private Bindable<bool> breakTime;
|
|
private HealthProcessor processor;
|
|
private ManualClock clock;
|
|
|
|
[Test]
|
|
public void TestInitialHealthStartsAtOne()
|
|
{
|
|
createProcessor(createBeatmap(1000, 2000));
|
|
|
|
assertHealthEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthNotDrainedBeforeGameplayStart()
|
|
{
|
|
createProcessor(createBeatmap(1000, 2000));
|
|
|
|
setTime(100);
|
|
assertHealthEqualTo(1);
|
|
setTime(900);
|
|
assertHealthEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthNotDrainedAfterGameplayEnd()
|
|
{
|
|
createProcessor(createBeatmap(1000, 2000));
|
|
setTime(2001); // After the hitobjects
|
|
setHealth(1); // Reset the current health for assertions to take place
|
|
|
|
setTime(2100);
|
|
assertHealthEqualTo(1);
|
|
setTime(3000);
|
|
assertHealthEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthNotDrainedDuringBreak()
|
|
{
|
|
createProcessor(createBeatmap(0, 2000));
|
|
setBreak(true);
|
|
|
|
setTime(700);
|
|
assertHealthEqualTo(1);
|
|
setTime(900);
|
|
assertHealthEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthDrainedDuringGameplay()
|
|
{
|
|
createProcessor(createBeatmap(0, 1000));
|
|
|
|
setTime(500);
|
|
assertHealthNotEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthGainedAfterRewind()
|
|
{
|
|
createProcessor(createBeatmap(0, 1000));
|
|
setTime(500);
|
|
|
|
setTime(0);
|
|
assertHealthEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthGainedOnHit()
|
|
{
|
|
Beatmap beatmap = createBeatmap(0, 1000);
|
|
|
|
createProcessor(beatmap);
|
|
setTime(10); // Decrease health slightly
|
|
assertHealthNotEqualTo(1);
|
|
|
|
AddStep("apply hit result", () => processor.ApplyResult(new JudgementResult(beatmap.HitObjects[0], new Judgement()) { Type = HitResult.Perfect }));
|
|
assertHealthEqualTo(1);
|
|
}
|
|
|
|
[Test]
|
|
public void TestHealthRemovedOnRevert()
|
|
{
|
|
var beatmap = createBeatmap(0, 1000);
|
|
JudgementResult result = null;
|
|
|
|
createProcessor(beatmap);
|
|
setTime(10); // Decrease health slightly
|
|
AddStep("apply hit result", () => processor.ApplyResult(result = new JudgementResult(beatmap.HitObjects[0], new Judgement()) { Type = HitResult.Perfect }));
|
|
|
|
AddStep("revert hit result", () => processor.RevertResult(result));
|
|
assertHealthNotEqualTo(1);
|
|
}
|
|
|
|
private Beatmap createBeatmap(double startTime, double endTime)
|
|
{
|
|
var beatmap = new Beatmap
|
|
{
|
|
BeatmapInfo = { BaseDifficulty = { DrainRate = 5 } },
|
|
};
|
|
|
|
for (double time = startTime; time <= endTime; time += 100)
|
|
beatmap.HitObjects.Add(new JudgeableHitObject { StartTime = time });
|
|
|
|
return beatmap;
|
|
}
|
|
|
|
private void createProcessor(Beatmap beatmap) => AddStep("create processor", () =>
|
|
{
|
|
breakTime = new Bindable<bool>();
|
|
|
|
Child = processor = new DrainingHealthProcessor(beatmap.HitObjects[0].StartTime).With(d =>
|
|
{
|
|
d.RelativeSizeAxes = Axes.Both;
|
|
d.Clock = new FramedClock(clock = new ManualClock());
|
|
});
|
|
|
|
processor.IsBreakTime.BindTo(breakTime);
|
|
processor.ApplyBeatmap(beatmap);
|
|
});
|
|
|
|
private void setTime(double time) => AddStep($"set time = {time}", () => clock.CurrentTime = time);
|
|
|
|
private void setHealth(double health) => AddStep($"set health = {health}", () => processor.Health.Value = health);
|
|
|
|
private void setBreak(bool enabled) => AddStep($"{(enabled ? "enable" : "disable")} break", () => breakTime.Value = enabled);
|
|
|
|
private void assertHealthEqualTo(double value)
|
|
=> AddAssert($"health = {value}", () => Precision.AlmostEquals(value, processor.Health.Value, 0.0001f));
|
|
|
|
private void assertHealthNotEqualTo(double value)
|
|
=> AddAssert($"health != {value}", () => !Precision.AlmostEquals(value, processor.Health.Value, 0.0001f));
|
|
|
|
private class JudgeableHitObject : HitObject
|
|
{
|
|
public override Judgement CreateJudgement() => new Judgement();
|
|
protected override HitWindows CreateHitWindows() => new HitWindows();
|
|
}
|
|
}
|
|
}
|