mirror of https://github.com/ppy/osu
041318e3e8
For a judgement result to show up on the colour hit error meter, it has to be two things: be scorable, and not be bonus. `ComboBreak` happens to meet both of those criteria - it impacts score indirectly via decreasing the combo portion, and isn't bonus. Therefore it would show up on the colour hit error meter, but because `OsuColour.ForHitResult()` wasn't handling it explicitly, it was painting the result in light blue, which isn't ideal for a miss type judgement. Therefore, use red instead. There is possibly an argument to be made that this judgement should not show up on the colour hit error meter at all, but I think it's actually okay for it to be this way. In any case it doesn't appear to be anything so major as to warrant blocking the hold note tick removal at this time. |
||
|---|---|---|
| .. | ||
| Backgrounds | ||
| Containers | ||
| Cursor | ||
| OpenGL/Vertices | ||
| Sprites | ||
| UserInterface | ||
| UserInterfaceV2 | ||
| DateTooltip.cs | ||
| DrawableDate.cs | ||
| ErrorTextFlowContainer.cs | ||
| HSPAColour.cs | ||
| IHasAccentColour.cs | ||
| InputBlockingContainer.cs | ||
| OsuColour.cs | ||
| OsuFont.cs | ||
| OsuIcon.cs | ||
| ParticleExplosion.cs | ||
| ParticleSpewer.cs | ||
| ScreenshotManager.cs | ||