Commit Graph

135 Commits

Author SHA1 Message Date
Dean Herbert 05596a391d
Disable collection expression inspections completely 2024-06-17 19:11:08 +08:00
Bartłomiej Dach 442b61da84
Disable primary constructor related inspections
I'm not actually sure whether the editorconfig incantation does anything
but it's the one official sources give:

	https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0290
2024-06-04 15:14:56 +02:00
Salman Ahmed 848e497c94 Add "HP" to the abbreviations list 2024-05-05 21:32:30 +03:00
Salman Ahmed 9dc1a58ce7 Add few abbreviations from existing enums to appease naming inspection 2024-05-01 17:27:21 +03:00
Dean Herbert 3e8ddbd2a9
Add new entries to dotsettings (Rider 2024.1) 2024-04-11 11:33:16 +08:00
Susko3 7864810fc9 Merge branch 'master' into windows-file-uri-association 2024-02-07 23:10:13 +01:00
Susko3 498d93be61 Add way to associate with files and URIs on Windows 2024-02-03 16:59:48 +01:00
Andrei Zavatski dde7e068a4 Incorporate new unstable rate algo 2024-02-02 22:46:52 +03:00
Dan Balasescu b44f77cee1
Update R# + fix inspections 2024-02-02 21:00:28 +09:00
Dean Herbert 0553de768c
Enforce namespace body style 2023-12-07 15:26:02 +09:00
Dean Herbert 35e11c7c63
Rename diagonal scale variable and update xmldoc 2023-11-10 17:55:02 +09:00
Bartłomiej Dach ba1f6439bf
Disable redundant verbatim string prefix inspections
For some reason this started flaring up recently all over for me and
showing inspections all over, which are _technically_ valid, but
interfere with our convention of using verbatim string prefixes to
denote non-localisable strings. This, as a result, led to circular
inspections (addressing the r# inspection results in getting the
osu-localisation-analyser one, addresssing that one results in
getting the r# inspection back, etc. ad nauseam).
2023-08-28 12:44:57 +02:00
Dean Herbert 71a643d640 Update inspection rules in line with source generation change 2023-07-20 20:05:38 +09:00
Dean Herbert 2cd5a4c6c2 Add generated code hints in editorconfig / dotsettings 2023-07-07 22:38:07 +09:00
Dean Herbert dc421bd2af Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11"
This reverts commit ab2bd123e7, reversing
changes made to 267e63320f.
2023-05-17 14:49:47 +09:00
Bartłomiej Dach c97b7a077e
Use better issue reference 2023-05-16 23:47:47 +02:00
Bartłomiej Dach 70426a5042
Add reference to youtrack issue to suppression 2023-05-16 22:42:25 +02:00
Huo Yaoyuan 84de463e2e Turn off inspection of MSBuild unknown property 2023-05-17 00:13:08 +08:00
Dean Herbert 26ed50d8fd Add abbreviations found in framework functions
Brings total inspections down to zero when using local framework
checkout (in conjuncation with https://github.com/ppy/osu-framework/pull/5793).
2023-05-15 21:42:49 +09:00
Dean Herbert 3d55a0291f Prefer block scoped namespaces 2023-05-05 16:06:02 +09:00
Joseph Madamba a10628e270 Change severity of `RedundantArgumentDefaultValue` to hint 2022-12-25 20:47:05 -08:00
Dean Herbert 4a7d7c6ed9 Use `MaxBy` in all locations that can and update inspection level to match `dotnet-build` 2022-12-19 16:47:10 +09:00
Dan Balasescu 15db65c037 Extract to struct, add dictionary term 2022-10-14 14:12:53 +09:00
Dean Herbert 40a60f7145 Remove all entity framework code and migrations 2022-09-15 16:58:58 +09:00
Susko3 e5118130db Add 'SDL' acronym 2022-07-30 16:05:35 +02:00
Dean Herbert 0bd4aee66c Add ignore rule for `System.ComponentModel.Component` 2022-07-19 17:56:27 +09:00
Dean Herbert 978a80dd6f Change closure elimination to hint
Pretty noisy as a suggestion, and can fire incorrectly quite a lot (aka
`Schedule()`).
2022-06-29 01:52:51 +09:00
Bartłomiej Dach e0c2228b41
Revert downgrades in code inspection settings 2022-06-24 16:43:57 +02:00
Dean Herbert 81bfe14063 Update `DotSettings` to match framework (in most cases) 2022-06-24 21:28:24 +09:00
Salman Ahmed eaae600a49 Fix typo in auto-import ignore rule 2022-06-24 04:58:27 +03:00
Dean Herbert f561d5b4ad Change always-discarded-parameter inspection to hint
See

f8830c6850/osu.Game/Rulesets/Scoring/ScoreProcessor.cs (L518)

Coming up as a suggestion (the only one in the solution).
2022-06-22 14:32:44 +09:00
Dean Herbert ac5b1fba1f Add blacklisted auto-import rules which conflict with osu!/osu!framework naming 2022-06-07 15:36:26 +09:00
Dan Balasescu 494955aff1 Resolve inspection issues 2022-04-14 13:11:11 +09:00
Dean Herbert e1f5acd689 Remove names from user dictionary 2022-01-13 12:40:19 +09:00
Joseph Madamba a18b283626 Revert identifier typo bump 2022-01-12 15:52:33 -08:00
Joseph Madamba 5185f6010e Fix missed identifier typos 2022-01-12 15:46:20 -08:00
Joseph Madamba b245ffefc1 Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names 2022-01-12 15:05:07 -08:00
Dean Herbert e38e1bb1d7 Enable a couple of missing async related inspections 2021-12-31 01:52:01 +09:00
Joseph Madamba c22a07d9fc Bump identifier typo inspection and fix remaining identifier names 2021-12-28 11:26:42 -08:00
Joseph Madamba 55768d8c11 Add some osu! words to dictionary 2021-12-27 20:26:28 -08:00
Joseph Madamba eed0ecf8c5 Add special prefixed/suffixed words to dictionary 2021-12-27 20:26:28 -08:00
Dean Herbert 4149d458f0 Move realm data migrations inside the `RealmContextFactory` 2021-11-23 18:14:15 +09:00
Dean Herbert 63bc415565 Warn on suspicious types 2021-11-12 18:35:42 +09:00
Dean Herbert 1d7e97625a Update `var` usage inspections to disallow for built-in types 2021-10-27 12:57:43 +09:00
Dean Herbert d37913a8b4 Disable null check pattern type check syntax inspections 2021-10-18 13:59:25 +09:00
Salman Ahmed 1e6119da0b Update code inspection settings to hide "merge into pattern" again 2021-08-20 05:36:39 +03:00
kj415j45 3f434c8474
Resolve code quality issue 2021-08-12 13:42:16 +08:00
Dean Herbert 0a950a5da7 Disable auto property get-only inspection 2021-07-21 17:59:50 +09:00
Bartłomiej Dach af02a1efcb Bump redundant argument default value inspection severity to warning 2021-07-05 21:02:40 +02:00
Bartłomiej Dach 30a7b034be Add HSV abbreviation to team-shared collection 2021-07-01 00:30:43 +02:00