79 Commits

Author	SHA1	Message	Date
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	43c9058d09	Fix wrong obsolete message	2022-05-05 14:39:05 +03:00
Salman Ahmed	8501a41619	Bring back separate bool properties as non-cascading	2022-05-05 14:37:38 +03:00
Salman Ahmed	8488a29e9e	Renew obsoletion date	2022-05-04 17:22:11 +03:00
Salman Ahmed	5f878ed82b	Delegate IsPlayable to the obsoleted UserPlayable by default ... Handles consumers who still haven't updated to use `IsPlayable` yet.	2022-03-20 16:07:09 +03:00
Salman Ahmed	51e5dd7d0e	Introduce IsPlayable(...) and obsolete UserPlayable	2022-03-18 02:08:30 +03:00
Salman Ahmed	d90a334853	Introduce multiplayer playability and free mod validity in Mod	2022-03-17 03:48:56 +03:00
Dean Herbert	1814a325d8	Move GetSettingUnderlyingValue to a SettingSource extension method	2022-03-15 14:54:00 +09:00
Dean Herbert	7307e68e9c	Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier" ... This reverts commit 252b945d3b, reversing changes made to a1b39a96cf.	2022-02-17 13:26:12 +09:00
Dean Herbert	23933fc881	Update xmldoc to mention that multipliers are not applied anywhere	2022-02-16 17:32:22 +09:00
Dan Balasescu	4c1413e0c7	No longer require Mod implementation	2022-02-16 16:36:02 +09:00
Dean Herbert	c3531e1361	Move more specification from Mod to IMod	2021-09-10 12:42:53 +09:00
Dean Herbert	cf633973a9	Refactor exposed mod retrieval methods for better safety	2021-09-10 11:09:13 +09:00
Dean Herbert	c25ab6835c	Remove IJsonSerializable interface ... Was pretty pointless and made it hard to use the custom serialisation terms arbitrarily in tests.	2021-08-31 14:39:20 +09:00
Salman Ahmed	072560ba3e	Remove leftover unused using	2021-08-19 07:17:43 +03:00
Salman Ahmed	1ae4a1910a	Cache mod settings rather than fetching everytime	2021-08-18 09:17:42 +03:00
Salman Ahmed	060ba0692d	Add hash code support for Mod	2021-08-17 04:27:04 +03:00
Dean Herbert	3c028ce05c	Add IDeepCloneable interface and update existing CreateCopy methods to use it	2021-07-19 12:54:17 +09:00
Henry Lin	6a0c5b54c3	Fix obsolete message in Mod.Ranked	2021-07-02 15:55:25 +08:00
Dean Herbert	0396a03bbc	Rename Mod.Ranked back to avoid breaking ruleset API	2021-07-02 12:50:58 +09:00
Dean Herbert	d0e9f8ef90	Replace and obsolete Ranked flag with IsUserPlayable	2021-06-09 14:17:03 +09:00
smoogipoo	8c4804dd7a	Use nameof	2021-04-16 15:40:06 +09:00
smoogipoo	d1c72f5e13	Apply changes resulting from IBindable interface updates	2021-04-16 15:10:53 +09:00
Dean Herbert	346e36d32a	Make Mod.Description abstract and add missing descriptions	2021-04-15 14:36:26 +09:00
Salman Ahmed	92fab653e1	Take current mod settings value into account on equality comparsion	2021-04-12 20:51:13 +03:00
Salman Ahmed	18fb9f5ac9	Merge branch 'master' into mod-using-reference-equality	2021-04-11 19:48:55 +03:00
Dean Herbert	8204d360a8	Always reset local user settings when a mod is deselected in ModSelectOverlay	2021-02-09 13:44:42 +09:00
Dean Herbert	be379e0e3c	Change CopyFrom to always overwrite all settings with incoming values	2021-02-09 13:44:11 +09:00
Bartłomiej Dach	4b4adc927c	Rename param to match method body	2021-01-10 15:35:53 +01:00
Salman Ahmed	0aad0c7c6c	Target logic at this and adjust variables	2021-01-09 00:31:18 +03:00
Salman Ahmed	375ecf92ed	Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings	2021-01-09 00:26:18 +03:00
Bartłomiej Dach	9e4a925ab1	Clarify & cleanup comments some	2021-01-03 13:44:29 +01:00
Bartłomiej Dach	a3e29b9154	Rename parameters for readability	2021-01-03 13:25:44 +01:00
Dean Herbert	2501707d7d	Copy values using Bind to also copy defaults	2021-01-03 20:45:03 +09:00
Dean Herbert	29dbb1cc0d	Add internal pathway for ensuring correct application of bindable mods	2021-01-03 15:48:28 +09:00
Dean Herbert	23e216fa0b	Simplify some default value checks (we are sure the return is an IBindable)	2021-01-03 15:47:15 +09:00
Salman Ahmed	c1a1e3acc5	Revert drive-by changes	2021-01-01 15:40:40 +03:00
Salman Ahmed	a031c8e0b6	Apply documentation suggestions ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-01-01 15:34:09 +03:00
Salman Ahmed	b4df2d6d43	Add method for copying properties from another mod	2021-01-01 03:46:09 +03:00
Salman Ahmed	41b79d938b	Fix wrong checks..	2020-12-28 15:30:52 +03:00
Salman Ahmed	5efcdbd431	Fix IMod now using reference equality as well	2020-12-28 15:19:28 +03:00
Salman Ahmed	43f8f3638a	Fix mod using reference equality unless casted to IMod	2020-12-27 02:42:13 +03:00
smoogipoo	1143d5d992	Update class exclusion for dynamic compilation	2020-09-04 20:41:08 +09:00
smoogipoo	3cb22fad82	Fix mods sharing bindable instances	2020-08-13 19:48:31 +09:00
Dean Herbert	205f4dcb54	Simplify string construction logic	2020-03-23 15:20:56 +09:00
Liam DeVoe	889608a408	remove redundant ToString call	2020-03-22 22:51:29 -04:00
Liam DeVoe	98b8f82810	simplify SettingDescription default definition	2020-03-22 22:07:09 -04:00
Liam DeVoe	ea87afd577	use string.Empty in IconTooltip	2020-03-22 22:06:54 -04:00
Liam DeVoe	63e9b2a299	use string.Empty, use base SettingDescription for [Osu/Catch]ModDifficultyAdjust	2020-03-22 18:50:09 -04:00
Liam DeVoe	cda1efef0b	move overridability to SettingDescription method	2020-03-20 16:34:36 -04:00