RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-30 19:02:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
47,413 Commits 4 Branches 666 Tags 366 MiB
ee64ab6383
Commit Graph

47413 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Balasescu
ee64ab6383 Fix delete button test failures 
Can be tested by adding a Thread.Sleep() in
DrawableRoomPlaylistItem.load().
 2021-12-22 09:55:19 +09:00
Dan Balasescu
4ce61d4260 Directly bind to room updates 
Currently doesn't really cause any difference, however it may in the
future if we decide the queueing algorithm shouldn't update PlaylistOrder
when an item has been played.
 2021-12-21 18:40:29 +09:00
Dan Balasescu
e2f8c71081 Fix test 2021-12-21 18:38:31 +09:00
Dan Balasescu
a34d24fb20 Disallow expired items from showing delete button 
This isn't possible in practice since expired items are removed from the
queue list, but this helps out in tests.
 2021-12-21 18:37:42 +09:00
Dan Balasescu
51b7e920c0 Fix delete button being able to show on current item 2021-12-21 16:57:58 +09:00
Dan Balasescu
32fbaf47c0
Merge pull request #16192 from peppy/add-room-lost-logging 
Add logging of `MultiplayerMatchSubScreen` exiting from room loss
 2021-12-21 16:37:08 +09:00
Dean Herbert
2707b2fbda
Merge pull request #16012 from bdach/beatmap-card/extra 
Implement "extra" beatmap card size
 2021-12-21 15:40:33 +09:00
Dan Balasescu
a8cd96278d
Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure 
Fix intermittent failures on `TestSceneBeatmapListingOverlay`
 2021-12-21 15:11:25 +09:00
Dan Balasescu
5cea8da80f
Merge pull request #16188 from peppy/multiplayer-button-enabled 
Centralise all multiplayer button clicking test logic
 2021-12-21 15:10:26 +09:00
Dean Herbert
d08b66a5ff Also add logging to OnlinePlayScreen 2021-12-21 15:07:06 +09:00
Dan Balasescu
3b700b6967
Merge pull request #16187 from peppy/fix-threading-colour-error-meter 
Fix potential wrong thread mutation in `ColourHitErrorMeter`
 2021-12-21 15:05:57 +09:00
Dean Herbert
ddadf3c4b5 Add logging of MultiplayerMatchSubScreen exiting from room loss 2021-12-21 14:53:24 +09:00
Dean Herbert
0f8a6a3f64 Fix intermittent failures on TestSceneBeatmapListingOverlay 
In the specific method, there was no wait step after the initial fetch
(unlike all of the rest), meaning the fetch may not have finished in
time for the follow-up steps.

As seen at
https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.
 2021-12-21 14:12:06 +09:00
Dan Balasescu
2ea31c26a5
Merge pull request #16168 from peppy/windows-key-when-inactive 
Avoid blocking windows key usage when the osu! window is not active
 2021-12-21 13:51:10 +09:00
Dean Herbert
bb3f375958 Add note about local button clicking usage 2021-12-21 13:49:51 +09:00
Dean Herbert
aad55ef89e Remove unused method in TestSceneMultiplayerQueueList 2021-12-21 13:49:51 +09:00
Dean Herbert
9aff646ff4 Centralise all multiplayer button clicking test logic 
This adds the "wait for enabled" check in a way that can be easily
reused, as it keeps getting missed in test implementations.

This particular commit hopefully fixes
https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.
 2021-12-21 13:49:51 +09:00
Dean Herbert
edcbd4de6d Fix incorrect event unbind logic 2021-12-21 13:05:26 +09:00
Dean Herbert
52db7b36fc Move Schedule call to base implementation of error meter for extra safety 2021-12-21 12:55:21 +09:00
Dean Herbert
28d6ff5d9c Fix potential wrong thread mutation in ColourHitErrorMeter 2021-12-21 12:36:04 +09:00
Dan Balasescu
377cb1d9e3
Merge pull request #15728 from MBmasher/fl-decay 
Remove decay factor in Flashlight skill
 2021-12-21 07:59:32 +09:00
Bartłomiej Dach
f1a03aced5
Merge branch 'master' into beatmap-card/extra 2021-12-20 15:49:00 +01:00
Dean Herbert
488e1f858b
Merge pull request #16167 from peppy/fix-song-select-test-failure 
Fix occasional failures in `TestScenePlaySongSelect`
 2021-12-20 23:11:06 +09:00
Bartłomiej Dach
0b7daf542f
Merge branch 'master' into fix-song-select-test-failure 2021-12-20 11:36:49 +01:00
Bartłomiej Dach
6bbc9ccf97
Merge pull request #16169 from peppy/fix-ready-button-test 
Add better defined steps to `TestLoseHostWhileReady` ready button test
 2021-12-20 11:36:20 +01:00
Bartłomiej Dach
f492cf84d9
Ensure presence of at least 1 difficulty for each ruleset 2021-12-20 11:34:39 +01:00
Bartłomiej Dach
d8be455a43
Merge branch 'master' into fix-ready-button-test 2021-12-20 11:02:43 +01:00
Bartłomiej Dach
e4702b8729
Merge pull request #16172 from peppy/update-framework 
Update framework
 2021-12-20 11:02:15 +01:00
Dean Herbert
ec0a6735eb Rename TestMultiplayerScreenStack to TestMultiplayerComponents 2021-12-20 18:24:59 +09:00
Dean Herbert
6907a9a3cc Name some screen stacks for better logging context 2021-12-20 18:24:14 +09:00
Dean Herbert
1533aefce5 Update framework 2021-12-20 18:22:19 +09:00
Dean Herbert
87051d5d61 Add better defined steps to TestLoseHostWhileReady ready button test 
Not 100% sure this will solve the issue but it's worth a try. The button
state checks are using `Until` everywhere else so this brings the test
in line with the standards.

As seen
https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.
 2021-12-20 17:47:06 +09:00
Dean Herbert
090c3e84e7 Avoid blocking windows key usage when the osu! window is not active 
As discussed in https://github.com/ppy/osu/discussions/16147.
 2021-12-20 17:40:11 +09:00
Bartłomiej Dach
51386bb48d
Merge pull request #16166 from peppy/playlist-tests-wait-step 
Add wait step to `TestScenePlaylistResultScreen` explicitly for screen load
 2021-12-20 09:36:57 +01:00
Dean Herbert
5c8e317a6e Chooser earlier items in song select tests to avoid potentially not having enough 2021-12-20 17:11:15 +09:00
Dean Herbert
af78a3e99d Fix weird loop logic 2021-12-20 17:09:08 +09:00
Dean Herbert
d79602a912 Add wait step to TestScenePlaylistResultScreen explicitly for screen load 2021-12-20 16:58:36 +09:00
Dean Herbert
2e47c4e25d
Merge pull request #16164 from smoogipoo/fix-intermittent-background-test 
Fix intermittent background screen test failures
 2021-12-20 14:00:53 +09:00
Dean Herbert
ce6503ff8b
Merge pull request #16165 from smoogipoo/fix-multiplayer-tests 
Add better fix for intermittent multiplayer tests as a result of async room joins
 2021-12-20 13:44:29 +09:00
Dan Balasescu
9316abc278 Better fix for intermittent multiplayer tests 2021-12-20 13:10:13 +09:00
Dan Balasescu
11f3ec0cb5 Wait for previous screen to be hidden in test 2021-12-20 12:44:23 +09:00
Dean Herbert
c81787a43d
Merge pull request #16163 from smoogipoo/remove-sdk-greater-than-readme 
Require installing .NET 5 in README
 2021-12-20 12:19:59 +09:00
Dan Balasescu
1203ae5984 Require installing .NET 5 in README 2021-12-20 11:49:39 +09:00
Dan Balasescu
ecaa0a40c5
Merge pull request #16158 from bdach/is-ranked-user-profile 
Fix rank graph showing for unranked users on profile overlay
 2021-12-20 09:14:17 +09:00
Bartłomiej Dach
a6ccbafc77
Fix rank graph showing for unranked users 2021-12-19 13:40:22 +01:00
Bartłomiej Dach
097402677d
Add test for ranked/unranked user display 2021-12-19 13:40:22 +01:00
Bartłomiej Dach
c112177559
Bring profile header test in line with modern conventions 
- Removed online code that didn't work anyway after the introduction of
  the development web instance.

- Removed some weird test steps.

- Fixed online/offline test steps not working at all due to identical
  user ID.
 2021-12-19 13:40:21 +01:00
Dan Balasescu
a3b81094ca
Merge pull request #16142 from peppy/fix-random-skin-string 
Fix "Random Skin" text not showing up correctly
 2021-12-18 16:59:41 +09:00
Dean Herbert
04cfae9bde Fix "Random Skin" text not showing up correctly 2021-12-18 16:26:15 +09:00
Bartłomiej Dach
33e930f477
Move scale-on-expand logic to BeatmapCardContent 2021-12-17 13:29:20 +01:00