RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,376 Commits 3 Branches 659 Tags 360 MiB
Commit Graph

1031 Commits

Author SHA1 Message Date
Salman Ahmed 68e28f4903 Implement `IHasApproachCircle` in `DrawableHitCircle` as well 2021-06-21 07:35:07 +03:00
Salman Ahmed c04b09520d Replace spinner approach circle proxying logic with hooking up to `OnSkinChange` in mod 2021-06-19 20:06:28 +03:00
Salman Ahmed 843c8bd7a4 Move spinner approach circle to its own `SkinnableDrawable` 2021-06-18 20:33:50 +03:00
Salman Ahmed f7b5341663 Merge branch 'master' into legacy-spinner-approach-circle 2021-06-18 19:50:52 +03:00
Salman Ahmed c9458fd9ce Hide spinner approach circle in "Hidden" mod 2021-06-18 06:23:54 +03:00
Dean Herbert a46f730a69 Fix approach circle fade not running early on an early user hit 
Regressed in https://github.com/ppy/osu/pull/12153.
Closes https://github.com/ppy/osu/issues/13531.
 2021-06-17 15:09:05 +09:00
Dean Herbert 6017ef3825
Merge branch 'master' into fix-skin-sample-lookup 2021-06-08 17:37:36 +09:00
Dean Herbert 277eb9fa6e Fix slider repeat arrow not updating rotation immediately while paused in editor 
A bit of a local solution, but not sure there's a better way to handle
this.

Closes #13342.
 2021-06-07 15:58:43 +09:00
Dean Herbert d26c9a66c2 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-07 12:01:19 +09:00
ekrctb d7da66d876 Bring back scheduling of follow point update 2021-06-04 18:41:02 +09:00
ekrctb 0098ac2760 Remove one TODO 
It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.
 2021-06-04 17:09:59 +09:00
ekrctb bc892086fe Resolve nullable inspection, enable nullable for `FollowPointLifetimeEntry` 2021-06-04 17:09:59 +09:00
ekrctb b373b120ff Use general lifetime container for follow point container 2021-06-04 16:31:50 +09:00
ekrctb c06ff3c623 Remove defunct `Animate` calls 2021-06-02 11:46:28 +09:00
ekrctb b82190e157 Fix hit circle animation reset when skin is changed 
The transforms applied in `Animate` call was not applied because the piece is recreated.
 2021-06-02 11:32:24 +09:00
Dean Herbert 6268bbea85 Merge branch 'master' into fix-skin-sample-lookup 2021-05-28 14:47:35 +09:00
Dean Herbert 70a844ac10 Remove `allowFallback` parameters completely 2021-05-27 14:50:42 +09:00
Endrik Tombak 9ac4ef273e Make DrawableSliderTail not require ITrackSnaking 2021-05-26 23:21:05 +03:00
smoogipoo 3db995c778 Fix sliders jumping around the screen on movement 2021-05-24 17:15:57 +09:00
Dean Herbert 8336428574 Add regression test for spinner sample actually transforming its frequency 2021-05-24 15:10:33 +09:00
Dean Herbert 1410b8f36d Fix follow points displaying at incorrect locations when dragging a slider out-of-bounds 2021-05-05 18:30:57 +09:00
Dean Herbert d10aac851d Extract scale constant 2021-04-26 15:30:22 +09:00
Dean Herbert 4da964c3f3 Expose `DrawableSliderRepeat`'s arrow and move transforms to children 2021-04-26 15:22:42 +09:00
Dean Herbert aa7ade8186 Expose presence of `MainCirclePiece` via an interface 2021-04-26 15:22:17 +09:00
Salman Ahmed 0b9172a1dc Animate back slider repeat and tail circle pieces 2021-04-26 02:39:49 +03:00
Dean Herbert 47a4a07024 Split out animation triggering of `MainCirclePiece` to be interface driven 2021-04-21 19:15:10 +09:00
Dean Herbert ac0ed72d04 Keep hitcircles aligned with view in "Barrel Roll" mod 2021-04-20 18:36:11 +09:00
Dean Herbert e2470d757e
Merge branch 'master' into legacy-spm-counter 2021-04-12 12:52:52 +09:00
smoogipoo f2e811928b Rework slider hackery to not overwrite Samples 2021-04-09 15:28:08 +09:00
smoogipoo 8efa381d3a Actually use whistle sample for sliderwhistle 2021-04-08 23:13:16 +09:00
smoogipoo 7d291ed7d7 Don't serialise OriginalSamples 2021-04-08 20:57:50 +09:00
smoogipoo 7713c8a45f Add support for sliderwhistle 2021-04-08 20:20:09 +09:00
smoogipoo 9c3d15171c Reword xmldoc slightly 2021-04-02 18:00:28 +09:00
Amber 5ac36a2462 Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity 2021-04-02 03:56:23 -05:00
Amber 5063cd957f Force hit sample to play when Classic mod is enabled 2021-04-02 02:54:35 -05:00
Dean Herbert 9504fe3f3c Inline add of spm calculation (no need for it to be a separate call) 2021-03-30 13:43:05 +09:00
Salman Ahmed 0bf84e473d Refactor spinner SPM counter for skinning purposes 2021-03-30 04:19:23 +03:00
Dean Herbert c715b9b89e Merge branch 'master' into legacy-spinner-bonus 2021-03-25 18:09:25 +09:00
Dean Herbert 64e85ba995 Always fade out approach circles at a HitObject's start time to better match stable 2021-03-23 19:19:07 +09:00
Dean Herbert 098005393e Remove unnecessary null checks and debug code 2021-03-23 10:38:37 +09:00
Dean Herbert c4d08463ad Fix spinners playing looping sound too long in the editor 
The `OnComplete` event was never being run due to the transform playing
out longer than the spinner's lifetime. I've matched the durations, but
also moved the `Stop()` call to what I deem a safer place to run it (I
did notice that without this it would still potentially never fire).

Note that this is more noticeable in the editor because of lifetime
extension. In gameplay, the returning of a spinner to the pool will
clean things up (but in the editor that can take longer, depending on
timeline zoom level).

Another thing worth mentioning is that the fade doesn't actually work.
This is due to https://github.com/ppy/osu-framework/pull/4212.

Closes #12119.
 2021-03-22 16:04:51 +09:00
Salman Ahmed 98f6e16113 Move default spinner bonus counter to new `DefaultSpinner` 2021-03-13 05:59:42 +03:00
Salman Ahmed 8fdab5a7de Revert legacy spinner presence changes and bonus counter component 
No longer necessary, after inlining legacy coordinates logic to `LegacySpinner` and limiting precisely-positioned legacy components there
 2021-03-13 05:57:47 +03:00
Salman Ahmed 020a03e01e Use sensible "score per tick" constant 2021-03-13 05:56:28 +03:00
Salman Ahmed c4048c9831 Merge branch 'master' into legacy-spinner-bonus 2021-03-13 05:54:34 +03:00
Dean Herbert 1591d593e2 Move spin start time to inside result and switch to standard state handling 2021-03-11 12:58:15 +09:00
Dean Herbert 4e8bcc9265 Fix SPM counter decreasing after spinner has already been completed 2021-03-09 16:54:46 +09:00
Dean Herbert 5a6864eb78 Fix SPM counter immediately disappearing on completion of spinners 2021-03-09 16:54:46 +09:00
Salman Ahmed 3f1d36ee6b Add default spinner bonus counter piece 2021-03-06 20:27:56 +03:00
Salman Ahmed c441e993ff Separate "gained bonus" to a read-only bindable 2021-03-06 20:27:56 +03:00