Commit Graph

112 Commits

Author SHA1 Message Date
ekrctb 53b9852034 Add test case for DHO state change before load complete 2021-08-06 19:59:02 +09:00
Salman Ahmed 523c154f15 Add `ComboIndexWithOffsetsBindable` and bind similar to `ComboIndexBindable` 2021-07-22 16:40:33 +03:00
Dean Herbert 399c3b0be8 Rename property, reword xmldoc and improve readability of update code 2021-07-21 17:32:56 +09:00
Salman Ahmed 9d92b795fa Revert making `ComboOffset`s legacy and define `BeatmapSkinComboIndex` instead 2021-07-20 14:15:43 +03:00
Salman Ahmed 554652b033 Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset 2021-07-20 10:11:52 +03:00
Salman Ahmed 1af230c48c Merge branch 'master' into refactor-combo-colour-retrieval 2021-07-20 10:08:25 +03:00
ekrctb 55859938b1 Use object initializer syntax for hit object application in tests 2021-06-16 16:07:22 +09:00
Dan Balasescu c065f761c7
Merge branch 'master' into legacy-skin-default-fallback 2021-06-02 19:08:52 +09:00
Dan Balasescu ac83450791
Merge pull request #13256 from ekrctb/update-lifetime-2
Update DHO lifetime on entry lifetime change
2021-06-02 11:07:54 +09:00
ekrctb 0f381f7758 Fix wrong code 2021-06-01 14:38:02 +09:00
ekrctb 977d44df87 Add test catching lifetime change while KeepAlive is true 2021-06-01 14:28:23 +09:00
Dean Herbert 3ff9f9c89d Make `FindProvider` non-default 2021-05-31 21:29:47 +09:00
Dean Herbert ebfc24a499 Rename conflicting resources 2021-05-31 19:14:49 +09:00
Dean Herbert b16d10bd95 Provide game-wide resources via `IStorageResourceProvider` 2021-05-31 18:57:47 +09:00
ekrctb b7afea37c4 Test drawable lifetime change on entry lifetime change 2021-05-31 14:45:29 +09:00
ekrctb 265dfe5416 Add test case of DHO setting LifetimeStart in OnApply 2021-05-28 21:51:48 +09:00
ekrctb 68c5f4813e Add test of lifetime update on DefaultsApplied 2021-05-28 21:35:26 +09:00
ekrctb 3018a41ab5 Remove redundant string interpolation 2021-05-20 16:00:49 +09:00
ekrctb abf96db545 Add regression test for the pattern of using DHO proxy in `LifetimeManagementContainer` 2021-05-20 15:27:08 +09:00
Salman Ahmed cd6d070b4a Consider "combo offsets" as legacy logic and separate from combo information 2021-05-05 07:43:08 +03:00
Salman Ahmed 78794935b4 Handle combo colour lookups in other skins 2021-05-05 07:15:11 +03:00
ekrctb 39bccc5048 Revert "Adopt HitObjectContainer change in a test"
This reverts commit f55aa016
2021-05-04 16:45:24 +09:00
ekrctb 5aa522b1c2 Completely delegate DHO lifetime to Entry lifetime
A downside is lifetime update is not caught by LifetimeManagementContainer if used.
2021-04-29 14:38:01 +09:00
ekrctb f55aa016be Adopt HitObjectContainer change in a test
Non-pooled objects are attached as children only while alive
2021-04-29 14:38:01 +09:00
ekrctb 003553aba3 Add test of HitObjectLifetimeEntry.KeepAlive behavior 2021-04-27 18:10:44 +09:00
ekrctb 7980d16b4c Add failing test showing the issue of DHO lifetime 2021-04-27 14:26:12 +09:00
smoogipoo f144661c31 Fix storyboard sample test scene 2021-04-20 18:26:30 +09:00
smoogipoo 5da18c51a4 Fix compile error 2021-04-20 17:27:37 +09:00
smoogipoo 80473a356e Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction 2021-04-20 17:27:01 +09:00
smoogipoo 281c2041b2 Add failing test 2021-04-20 16:51:00 +09:00
smoogipoo 88ded95e75 Ensure clock is set in GCC.Start() 2021-04-20 13:56:13 +09:00
smoogipoo 44e13a91ad Rename test scene to match class 2021-04-16 20:51:42 +09:00
smoogipoo 1aa36818df Abstractify GameplayClockContainer 2021-04-14 17:47:11 +09:00
Bartłomiej Dach aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
Ronnie Moir f6d3cd6413 Change SamplePlaybackWithRateMods to use rate calulated from the sample
Replace hardcoded numbers
2021-02-23 21:25:59 +00:00
Ronnie Moir dbde47fe94 Fix test failure 2021-02-23 19:43:04 +00:00
Dean Herbert 00574a5288 Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
smoogipoo de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
Dean Herbert 10c2745682 Add region specifications around implicit interface implementations 2020-12-22 12:01:09 +09:00
Dean Herbert a5bcf1dc20 Expose resources to skin via interface (and share common pieces with beatmap) 2020-12-21 15:18:52 +09:00
smoogipoo 832d52a056 Fix hitobject sample tests 2020-11-13 18:19:07 +09:00
Bartłomiej Dach 164370bc7d Resolve more CA1805 inspections 2020-11-01 20:51:23 +01:00
smoogipoo cb6b35116a Merge branch 'master' into scoring-standardisation 2020-10-01 12:28:51 +09:00
smoogipoo 4ef7ab2872 Fix tests 2020-09-29 16:33:38 +09:00
smoogipoo bad48d6d44 Merge branch 'master' into scoring-standardisation 2020-09-29 16:33:38 +09:00
smoogipoo 31fae045fa Update judgement processors with new hit results 2020-09-29 16:33:38 +09:00
Dean Herbert 136843c8e4 Make DrawableStoryboardSample a SkinnableSound
Allows sharing pause logic with gameplay samples.
2020-09-29 14:25:39 +09:00
smoogipoo 9a24346a00 Fix HP drain edgecase potentially causing insta-fails 2020-09-25 23:29:40 +09:00
Dean Herbert a1ec167982 Add the ability to toggle new combo state from composer context menu 2020-09-23 16:38:16 +09:00
smoogipoo 447fd07b4e Fix maps with only bonus score having NaN scores 2020-09-11 01:13:55 +09:00