RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
37,203 Commits 3 Branches 658 Tags 381 MiB
Commit Graph

37203 Commits

Author SHA1 Message Date
Bartłomiej Dach dd2f63f313 Add assertions to actually check order 2021-02-27 14:58:05 +01:00
Bartłomiej Dach 528de5869e Fix multiple enumerations when ordering setting sources 
This was not spotted previously, because the base `Attribute` overrides
`Equals()` to have semantics similar to structs (per-field equality) by
using reflection. That masked the issue when strings were used, and
migrating to `LocalisableString` revealed it, as that struct's
implementation of equality currently uses instance checks.

Whether `LocalisableString.Equals()` is the correct implementation may
still be up for discussion, but allowing multiple enumeration is wrong
anyway, since the underlying enumerables are live (one especially is a
yield iterator, causing new object instances to be allocated).
 2021-02-27 14:58:01 +01:00
Bartłomiej Dach 87b73da73e Add failing test case 2021-02-27 14:57:55 +01:00
Dean Herbert 46fa82e4a7
Merge pull request #11909 from peppy/update-framework 
Update framework
 2021-02-26 20:37:37 +09:00
Dean Herbert 4fd8501c86 Remove unnecessary using (underlying enumerator change) 2021-02-26 20:03:03 +09:00
Dean Herbert 98d525d1db Update framework 2021-02-26 19:56:10 +09:00
Dan Balasescu 6bf5df407d
Merge pull request #11908 from peppy/fix-drawings-flag-sizing 
Fix tournament drawings screen flags being too big
 2021-02-26 19:02:36 +09:00
Dan Balasescu b1702273c8
Merge pull request #11904 from peppy/editor-centralise-selection-change-handling 
Centralise cases of performing actions on the current selection
 2021-02-26 19:01:30 +09:00
Dan Balasescu e80db89def
Merge pull request #11903 from peppy/fix-chat-post-error-display 
Show API human readable error message when chat posting fails
 2021-02-26 19:00:17 +09:00
Dan Balasescu d7f3519bd7
Merge pull request #11907 from peppy/fix-import-from-stable-no-beatmaps-message 
Fix "failed to import" message showing when importing from a stable install with no beatmaps
 2021-02-26 18:45:54 +09:00
Dean Herbert 1ac82af19a Adjust flag size to fit again 2021-02-26 17:58:23 +09:00
Dean Herbert 1ab449b73e Add test scene for drawings screen 2021-02-26 17:54:54 +09:00
Dan Balasescu 5558084b86
Merge pull request #11906 from peppy/reduce-notifications-alloc-overhead 
Reduce allocation overhead when notification overlay has visible notifications
 2021-02-26 17:54:12 +09:00
Dean Herbert 7e6bd0e995 Fix "failed to import" message showing when importing from a stable install with no beatmaps 2021-02-26 17:30:59 +09:00
Dean Herbert 3e65dfb9e7 Reduce allocation overhead when notification overlay has visible notifications 2021-02-26 17:11:47 +09:00
Dean Herbert cd1c1bf534 Centralise cases of performing actions on the current selection 
By moving this to a central location, we can avoid invoking the
EditorChangeHandler when there is no selection made. This helps
alleviate the issue pointed out in
https://github.com/ppy/osu/issues/11901, but not fix it completely.
 2021-02-26 14:15:13 +09:00
Dean Herbert 254f9bb58b Show API human readable error message when chat posting fails 
Closes #11902.
 2021-02-26 13:38:00 +09:00
Dean Herbert 119b4e8174
Merge pull request #11898 from peppy/beatmap-difficulty-cache-nullable 
Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability
 2021-02-26 09:26:54 +09:00
Bartłomiej Dach d0decc73be Merge branch 'master' into beatmap-difficulty-cache-nullable 2021-02-25 19:40:38 +01:00
Dean Herbert a792c3f13c
Merge pull request #11900 from peppy/update-bpm-with-mods 
Update the displayed BPM at song select with rate adjust mods
 2021-02-26 00:25:55 +09:00
smoogipoo 01a4815412 Make labels disappear on null beatmap/no hitobjects 2021-02-25 23:36:02 +09:00
Dan Balasescu 46ea0f44eb
Merge branch 'master' into beatmap-difficulty-cache-nullable 2021-02-25 22:52:15 +09:00
Dan Balasescu 8e12dd98f9
Merge pull request #11897 from peppy/fix-song-select-star-rating-display-zero-flashing 
Fix the star rating display at song select flashing to zero when changing mods
 2021-02-25 22:51:35 +09:00
Dean Herbert f14a8c21d1
Merge pull request #11896 from smoogipoo/optimised-has-flag-checks 
Change Enum.HasFlag to use HasFlagFast extension method
 2021-02-25 22:41:48 +09:00
smoogipoo c1f27ba938 Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing 2021-02-25 22:13:48 +09:00
smoogipoo c3eb44137b Move ValueChanged bind back to load() 2021-02-25 22:09:41 +09:00
smoogipoo 649ce20e35 Fix up super weird and super wrong DI 2021-02-25 22:01:53 +09:00
smoogipoo b090a82b35 Merge branch 'master' into update-bpm-with-mods 2021-02-25 21:58:54 +09:00
smoogipoo 56d38734b7 Merge branch 'master' into update-bpm-with-mods 2021-02-25 21:57:21 +09:00
smoogipoo de417a660d Make BPM update with changes in mod settings 2021-02-25 21:51:32 +09:00
smoogipoo 98313a98bf DI mods in parent class and pass them down 2021-02-25 21:48:02 +09:00
smoogipoo cf4c88c647 Fix spacing 2021-02-25 21:38:21 +09:00
Dean Herbert 8004652d27
Merge branch 'master' into optimised-has-flag-checks 2021-02-25 21:24:39 +09:00
Dan Balasescu 91e8abe901
Merge pull request #11871 from peppy/localisation-refactor-framework 
Update localisation in line with framework-side refactor
 2021-02-25 20:58:20 +09:00
Dean Herbert 3802cb29a4 Fix failing tests doing reference comparisons between string and LocalisedString 2021-02-25 17:49:54 +09:00
Dean Herbert 0566930895
Merge pull request #11895 from smoogipoo/update-analysers 
Update analyser package
 2021-02-25 17:39:48 +09:00
Dean Herbert 6d1c5979ea Update framework 2021-02-25 17:28:59 +09:00
Dean Herbert 90e8308716 Merge branch 'master' into localisation-refactor-framework 2021-02-25 17:28:55 +09:00
Dean Herbert 2db4b793d7 Also handle most common BPM display 2021-02-25 17:05:00 +09:00
Dean Herbert 31c52bd585 Update the displayed BPM at song select with rate adjust mods 
This only covers constant rate rate adjust mods. Mods like wind up/wind
down will need a more complex implementation which we haven't really
planned yet.
 2021-02-25 17:00:44 +09:00
Dean Herbert 5fa9bf61b6 Update xmldoc 2021-02-25 16:22:40 +09:00
Dean Herbert 03771ce8ec Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability 2021-02-25 16:19:01 +09:00
smoogipoo dcda7f62df Fix incorrect banned symbol 2021-02-25 16:10:27 +09:00
Dean Herbert 9f3ceb99eb Fix the star rating display at song select flashing to zero when changing mods 
Due to the use of bindable flow provided by `BeatmapDifficultyCache` in
this usage, the display would briefly flash to zero while difficulty
calculation was still running (as there is no way for a consumer of the
provided bindable to know whether the returned 0 is an actual 0 SR or a
"pending" calculation).

While I hope to fix this by making the bindable flow return nullable
values, I think this particular use case works better with non-bindable
flow so have switched across to that.
 2021-02-25 16:05:13 +09:00
Dan Balasescu a9aed0eef4
Merge pull request #11894 from peppy/fix-settings-from-main-menu 
Fix global hotkeys not working from main menu before toolbar is initially shown
 2021-02-25 15:43:47 +09:00
smoogipoo dff1d80f39 Update HasFlag usages to HasFlagFast 2021-02-25 15:38:56 +09:00
smoogipoo 996b6a1e57 Add Enum.HasFlag to banned symbols 2021-02-25 15:38:43 +09:00
smoogipoo 154dc03a8c Update analyser package 2021-02-25 15:31:50 +09:00
Dean Herbert 2c8e62ae35 Fix toolbar not completing enough of layout to propagate hotkeys to buttons before initial display 2021-02-25 14:52:51 +09:00
Dean Herbert a08a3d44c7 Add failing test coverage for using hotkeys from main menu before toolbar displayed 2021-02-25 14:52:16 +09:00