RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
52,323 Commits 3 Branches 660 Tags 372 MiB
Commit Graph

73 Commits

Author SHA1 Message Date
Joseph Madamba 5e5c8e78a6 Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
Dean Herbert 2ef791069c Fix typon on `AdvancedStats` 2022-01-07 17:33:38 +09:00
Dean Herbert 00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00
Dean Herbert 3ea7588a91 Update continuation usages to use `GetCompletedResult` 2022-01-06 22:53:07 +09:00
Dean Herbert 73b40e6833 Replace usage of `.Result` with `.WaitSafelyForResult` 2022-01-04 11:51:41 +09:00
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable 
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
 2021-11-20 17:00:50 +01:00
Dean Herbert b21e0e7efb Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays 2021-11-01 18:07:51 +09:00
Bartłomiej Dach 914e5c0f9d
Fix star rating not updating for some mods on details tab in song select 
`AdvancedStats` was locally assuming that the only changes in mods that
are relevant to it are if the mods are `IApplicableToDifficulty`. This
is not true, as other mods (such as `IApplicableToRate` mods, or more
recently, Flashlight) can also affect star difficulty, which is shown on
one of the bars in `AdvancedStats`.
 2021-10-31 18:58:17 +01:00
Dean Herbert a16c8f1ebc Update all beatmap overlay views to use `APIBeatmap`/`APIBeatmapSet` 2021-10-29 18:50:55 +09:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
Dean Herbert 2c308f3008 Rename `BeatmapMetrics` to `APIFailTimes` 2021-10-25 15:34:41 +09:00
Dean Herbert 045dd94a6e Move online metrics out of `BeatmapSetInfo` model 2021-10-25 15:12:39 +09:00
Dean Herbert bd84a8b749 Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage 2021-10-05 18:21:21 +09:00
Dean Herbert 973c31132b Rename `BeatmapInfo` variables which were named `beatmap` for clarity 2021-10-02 12:45:34 +09:00
Dean Herbert a92d499d7a Convert usages of `BeatmapDifficulty` to `IBeatmapDifficultyInfo` 2021-10-01 16:55:50 +09:00
Salman Ahmed e374ef163d Update localisable formattable extensions usages inline with framework change 2021-08-29 15:00:28 +03:00
Lucas A 7bebbf9f74 Mark format strings as verbatim. 2021-08-16 12:46:41 +02:00
Lucas A 5e0f9d0af9 Localise user ratings. 2021-08-08 22:00:12 +02:00
Dean Herbert d6656047e3 Fix beatmap statistics with value of zero not displaying correctly at song select 
Closes #13307.
 2021-06-03 01:58:51 +09:00
smoogipoo c1f27ba938 Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing 2021-02-25 22:13:48 +09:00
Dean Herbert 9f3ceb99eb Fix the star rating display at song select flashing to zero when changing mods 
Due to the use of bindable flow provided by `BeatmapDifficultyCache` in
this usage, the display would briefly flash to zero while difficulty
calculation was still running (as there is no way for a consumer of the
provided bindable to know whether the returned 0 is an actual 0 SR or a
"pending" calculation).

While I hope to fix this by making the bindable flow return nullable
values, I think this particular use case works better with non-bindable
flow so have switched across to that.
 2021-02-25 16:05:13 +09:00
Dean Herbert 1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
Dean Herbert eaa7b4cb93 Rename second usage variable name to match 2021-02-11 14:54:50 +09:00
smoogipoo 6fff7c39da Ensure tracker is disposed 2021-02-10 20:09:45 +09:00
smoogipoo 393cd6c74a Add helper class for tracking changes to mod settings 2021-02-10 19:40:07 +09:00
Dean Herbert 5113d4af8f Rename BeatmapDifficultyManager to BeatmapDifficultyCache 2020-11-06 13:14:29 +09:00
Bartłomiej Dach cc6ae8e3bd Fix crash if only one count list is received from API 2020-08-24 20:41:31 +02:00
smoogipoo 877b985e90 Remove local cancellation token 2020-07-24 16:11:28 +09:00
smoogipoo b10b99a670 Change method signatures to remove tracked/untracked 2020-07-24 13:52:43 +09:00
smoogipoo 107b5ca4f2 Add support for bindable retrieval 2020-07-21 23:13:04 +09:00
smoogipoo 24f14751ce Update beatmap details SR on ruleset/mod changes 2020-07-16 21:08:08 +09:00
alex 0e2ccac33b Add spaces to comments 2020-05-04 18:36:24 -07:00
TheWildTree 64a9b9c6fb Remove redundant using directives 2020-02-16 21:52:08 +01:00
TheWildTree 4d180a685a Adjust font sizes and spacing in BeatmapSetOverlay 2020-02-16 21:43:33 +01:00
Bartłomiej Dach 0bfadfbbf1 Apply precision when comparing adjusted values 
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
 2020-02-01 16:16:15 +01:00
Bartłomiej Dach a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
Dean Herbert 12ff51f686 Fix key count being incorrectly adjusted by hard/easy mods 2020-01-28 17:21:50 +09:00
TheWildTree b5ac707c6c Remove unnecessary directive 2020-01-12 21:09:48 +01:00
TheWildTree aa2645502c Fix adjusted value always being 0 2020-01-12 20:43:48 +01:00
Dean Herbert a6bdf04f6b Remove unused using 2019-12-20 18:36:39 +09:00
Dean Herbert 822903d5db Update song select statistics when mod changes settings 2019-12-20 18:01:35 +09:00
Dan Balasescu 6683460240
Merge branch 'master' into update-beatmap-settings 2019-12-18 17:59:27 +09:00
smoogipoo 8e651962c7 Fix incorrectly binding inside BDL load() 2019-12-18 17:41:30 +09:00
Dean Herbert ada2ae2b2c Use tuple to avoid potential for incorrect display 2019-12-18 17:12:41 +09:00
Dean Herbert e87aa281bf Don't clone beatmap unnecessarily 2019-12-18 17:00:35 +09:00
Huo Yaoyuan ecfc6dfa3d CA1825: use Array.Empty. 2019-12-17 12:59:48 +08:00
unknown 3945e7403a improve tests and refactor AdvancedStats 2019-12-13 09:39:54 +08:00
unknown ec5b506960 apply mod difficulty settings during song select 2019-12-12 23:41:46 +08:00
Berkan Diler fccdbffa93 Use MathF instead of Math- functions when possible 
MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.
 2019-11-25 00:45:42 +01:00
Berkan Diler 6cab517b2d .NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK. 2019-11-20 13:37:47 +01:00