28 Commits

Author	SHA1	Message	Date
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using `var`	2021-10-27 13:04:41 +09:00
Dean Herbert	b339c149d8	Copy `BaseDifficulty` to `Beatmap<T>` and move all write operations across	2021-10-06 15:10:45 +09:00
Naxess	53c0298b5e	Add too short spinners check and tests	2021-07-13 10:51:40 +02:00
Naxess	fec9448301	Add too short sliders check and tests	2021-07-13 10:50:41 +02:00
Dean Herbert	e9339d6100	Move some inline comments on `const`s to xmldoc instead	2021-06-22 15:16:19 +09:00
Naxess	fcb918d0e1	Add time distance equality check	2021-06-21 15:30:23 +02:00
Naxess	3eb088f89a	Add low difficulty overlaps check	2021-06-21 15:30:04 +02:00
Naxess	19800f5f7f	Move `IBeatmap` arg into context	2021-05-13 11:24:22 +02:00
Naxess	b7bc42e0d3	Rename "playableBeatmap" check arg to "beatmap" ... The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.	2021-05-12 02:34:16 +02:00
Naxess	c13b93e6f1	Replace `IWorkingBeatmap` arg with `BeatmapVerifierContext` in checks ... This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes. See next commit for example.	2021-05-12 02:29:18 +02:00
Naxess	8656176ab8	Add the playable beatmap as check argument ... This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor. So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`. This should be preferred over `workingBeatmap.Beatmap`.	2021-04-20 01:31:51 +02:00
Naxess	56bf49c85c	Take `IWorkingBeatmap` instead of `WorkingBeatmap` ... This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.	2021-04-18 01:21:20 +02:00
Naxess	448574e7e6	Use `WorkingBeatmap` instead of `IBeatmap` ... This lets us access things like the background, track, etc. which are necessary for quality and filesize checks. Also improves the structure of the `CheckBackgroundTest` class in the process.	2021-04-17 17:33:53 +02:00
Naxess	c8cb4286f6	Add reference for screen bounding box numbers	2021-04-13 10:35:06 +02:00
Naxess	6d3f9fa9ce	Use `is` class instead of `Equals` with template index ... Ensures ordering of `PossibleTemplates` does not affect tests.	2021-04-13 02:29:25 +02:00
Naxess	19a154ddf1	Rename `checkOrigin` -> `check` ... More consistent with `Issue.ctor`'s "template".	2021-04-12 17:28:12 +02:00
Naxess	bb720c23a0	Remove check ctors and locals	2021-04-12 17:12:37 +02:00
Dean Herbert	62c1812282	Remove redundant parameter naming	2021-04-12 23:37:47 +09:00
Dean Herbert	36bd235021	Move nested classes to bottom of file	2021-04-12 23:36:10 +09:00
Naxess	7c4f6d2b62	Rework template usage ... Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.	2021-04-12 15:47:26 +02:00
Naxess	65ebdd8f7a	Move check origin from `IssueTemplate` to `Issue` ... As a result we can also make check an interface, and need to provide the check itself when constructing an issue.	2021-04-12 10:08:08 +02:00
Dean Herbert	8bf85d737c	Change Metadata into a get property	2021-04-12 15:52:29 +09:00
Dean Herbert	8c31e96cdf	Change some methods to get properties	2021-04-12 15:52:18 +09:00
Dean Herbert	f78239c7f2	Move enums out of nesting	2021-04-12 15:52:18 +09:00
Naxess	3289bb0379	Merge `Check` and `BeatmapCheck` ... We're probably not going to need GeneralChecks or BeatmapsetChecks. The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.	2021-04-10 14:56:30 +02:00
Naxess	bc4f3351f3	Replace checks with realistic ones	2021-04-10 13:03:16 +02:00
Naxess	9c4604e3c5	Add example checks	2021-04-07 14:36:53 +02:00