Commit Graph

77 Commits

Author SHA1 Message Date
Dean Herbert 5c0494f3ba Remove unnecessary precondition check and disallow vertical catch flips for now 2022-01-06 14:39:29 +09:00
Dean Herbert 6779503e57 Refactor logic to avoid `TimelineSelectionHandler` having to block base calls 2022-01-05 16:56:54 +09:00
Dean Herbert 866ae3472b Add global flip hotkeys 2022-01-05 16:48:07 +09:00
Darius Wattimena d370f64ac3 Changed finding the spinner gaps via a dictionary instead of getting the thresholds via an array 2021-11-10 19:58:36 +01:00
Darius Wattimena bd5caceeb1 Fixed typo in banana shower gap check message 2021-11-10 00:23:14 +01:00
Darius Wattimena 5d8f35f3c9 Code cleanup and added tests for the spinner check 2021-11-10 00:16:29 +01:00
Darius Wattimena fbfed16756 Started on implementing a spinner gap check for catch 2021-11-09 23:05:25 +01:00
ekrctb 393d118eef Fix compilation failure overlooked in merge 2021-10-26 20:20:43 +09:00
ekrctb e5050b90a5 Don't assume catcher dash speed is 2x the walk speed 2021-10-26 20:09:48 +09:00
ekrctb de7a908be2 Cut distance snap lines at playfield border in catch editor 2021-10-26 14:51:52 +09:00
ekrctb c5d765029c Don't compute source object for distance snap grid when it is not enabled 2021-10-26 11:17:04 +09:00
ekrctb b7a719de71 Rename method 2021-10-26 11:14:12 +09:00
ekrctb 068217557e Add doc comment on catch distance snap grid 2021-10-26 11:12:10 +09:00
ekrctb 9f49a1df8b Handle the case of cursor below the start time of distance snap 2021-10-26 11:00:55 +09:00
ekrctb 865be5a10b Fix distance snap grid rendering inverted when out of bounds 2021-10-26 11:00:44 +09:00
ekrctb 2c92f1a0b7 Use array for fixed-size list 2021-10-26 10:41:17 +09:00
ekrctb 6d1cd0a3a1 Add distance snapping to catch editor 2021-10-25 16:37:44 +09:00
ekrctb 60df0151c0 Add very basic distance snap grid for catch editor 2021-10-25 15:25:59 +09:00
Dean Herbert b339c149d8 Copy `BaseDifficulty` to `Beatmap<T>` and move all write operations across 2021-10-06 15:10:45 +09:00
Dean Herbert a92d499d7a Convert usages of `BeatmapDifficulty` to `IBeatmapDifficultyInfo` 2021-10-01 16:55:50 +09:00
Dean Herbert 6dcd9427ac Remove bindable usage in `PathControlPoint`
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
Dean Herbert a7d6c682de
Merge pull request #13983 from ekrctb/juice-stream-placement
Add initial implementation of juice stream placement
2021-07-23 13:52:25 +09:00
ekrctb bd3386e770 Fix previously placed vertices in juice stream placement
A different UX than not fixing vertices.
2021-07-23 10:18:37 +09:00
ekrctb 4509c8bcfb Use the more consistent `lastVertex`, with a comment 2021-07-23 10:13:55 +09:00
ekrctb d49d303bae Call `GetContainingInputManager` at `LoadComplete` 2021-07-23 10:10:55 +09:00
ekrctb 9fff304554 Implement reversing of selected pattern in catch editor 2021-07-22 17:00:08 +09:00
ekrctb dc90e4d24c `EditorBeatmap.SelectedHitObjects` -> `SelectedItems` (same thing) 2021-07-22 16:52:47 +09:00
ekrctb 64102d2972 Add initial implementation of juice stream placement 2021-07-22 15:47:23 +09:00
ekrctb 2beef89c23 Add empty juice stream placement blueprint (no implementation) 2021-07-22 15:47:23 +09:00
Dean Herbert e8aaf4df16
Merge pull request #13961 from ekrctb/catch-editor-flip
Implement horizontal flipping of hit objects in catch editor
2021-07-22 15:27:59 +09:00
Dean Herbert 1d2fdd9841
Merge pull request #13937 from ekrctb/selection-editable-path
Add initial implementation of juice stream path editing
2021-07-22 14:48:02 +09:00
Dean Herbert 2151c1863e Rename variables for catch-specific casting to avoid any confusion 2021-07-22 14:07:32 +09:00
ekrctb 19657cd00e Guard against empty range in `PositionRange` 2021-07-22 13:29:32 +09:00
ekrctb 7b6981c632 Don't show the flip button when flipping is a no-op 2021-07-22 13:29:32 +09:00
ekrctb d93bf5be80 Don't handle mouse down at fixed vertices 2021-07-22 12:58:39 +09:00
Dean Herbert 73866c2837
Merge branch 'master' into catch-editor-flip 2021-07-21 19:54:39 +09:00
ekrctb d2d3214d47 Implement horizontal flipping of hit objects in catch editor 2021-07-21 16:07:02 +09:00
ekrctb 4c8b9c168e Use added position range computation in hit object move handling 2021-07-21 16:06:34 +09:00
ekrctb 60f876511d Add function of computing position range occupied by hit objects 2021-07-21 16:06:34 +09:00
ekrctb cd447f0305 Add some doc comment to `JuiceStreamSelectionBlueprint` 2021-07-21 13:27:07 +09:00
ekrctb cc0110aa52 Add doc comment to `VertexState` 2021-07-21 13:17:18 +09:00
ekrctb 97fba5df58 Use existing method for the same code 2021-07-21 12:59:42 +09:00
ekrctb ca3dfb2498 Fix comment 2021-07-21 12:53:48 +09:00
ekrctb 8586458704 Implement vertex deletion in juice stream selection blueprint 2021-07-19 22:53:32 +09:00
ekrctb 08f8d4e65e Implement vertex addition in juice stream selection blueprint 2021-07-19 22:53:32 +09:00
ekrctb 8cc1630655 Add initial juice stream editing 2021-07-19 22:53:32 +09:00
ekrctb 50f9e5f362 Replace usage of `CatcherArea.MovableCatcher` with `Catcher` 2021-07-19 19:52:40 +09:00
ekrctb c347584851 Use added utility function 2021-07-19 13:33:46 +09:00
ekrctb 70c9d7105f Add a function to compute hit object position in catch editor 2021-07-19 13:33:22 +09:00
Bartłomiej Dach c5011865fc Invert strangely negated condition 2021-07-10 11:23:38 +02:00