RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,558 Commits 3 Branches 658 Tags 358 MiB
Commit Graph

37 Commits

Author SHA1 Message Date
Dean Herbert 887035c12e Fix migration target having left over files potentially causing test failures 
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050324.
 2021-07-09 12:21:25 +09:00
Dean Herbert 2c1422b4f9 Add comment regarding teste edge case 2021-04-26 15:37:19 +09:00
Dean Herbert 03592fa696 Merge branch 'master' into realm-migration-operation-blocking 2021-03-19 21:33:26 +09:00
smoogipoo 7fa5fd5647 Update usages of config with framework changes 2021-03-17 16:10:16 +09:00
Dean Herbert d480aa0e42 Don't check for all ignored files being present in original folder (the realm exception is platform dependent) 2021-01-21 22:57:55 +09:00
Dean Herbert 1989141968
Merge branch 'master' into tourney-asset-refactor 2020-10-07 21:34:07 +09:00
Dean Herbert 3cef93ee27 Centralise import test helper methods 2020-09-18 18:05:33 +09:00
Dean Herbert 89a2f20922 Use new CleanRun host class in import tests 2020-09-17 16:12:30 +09:00
Dean Herbert 835c8d74b7 Wait for two update frames before attempting to migrate storage 2020-09-17 16:12:18 +09:00
Shivam c167727ac6 Merge branch 'master' into tourney-asset-refactor 
# Conflicts:
#	osu.Game/IO/OsuStorage.cs
 2020-08-09 12:38:41 +02:00
Dean Herbert 3a5784c410 Ensure directories are deleted before migration tests run 2020-07-09 15:08:15 +09:00
smoogipoo 1edfac4923 Fix test failing 2020-07-01 23:21:08 +09:00
Shivam 47a732ef60 Address review comments 
Now asserting instead of an if-statement, change cast from OsuStorage to MigratableStorage and make internal virtual properties protected.
 2020-06-24 23:01:56 +02:00
Shivam 063503f4db Move null check outside of the loop 2020-06-24 20:43:56 +02:00
Shivam af11340849 Fix nullref exceptions and redundant explicit type 2020-06-24 02:13:28 +02:00
Shivam c32ef5e718 Address formatting issues 2020-06-24 00:37:29 +02:00
Shivam a47d34f1db make ignore properties protected virtual get-only in base 2020-06-23 23:34:26 +02:00
Shivam 21774b8967 Move static properties to parent class and inherit OsuStorage from it 2020-06-22 11:38:50 +02:00
Shivam 1d4d749b53 Undo blank line removal 
Was too excited to add blank lines before submitting the PR that I overdid it
 2020-06-11 15:56:34 +02:00
Shivam 222ac86304 Add newlines at the end of the file 2020-06-11 15:52:14 +02:00
Salman Ahmed 2c6887e610
Remove unnecessary use of and remove StartupStorage 2020-05-31 19:49:03 +03:00
Salman Ahmed 82fe99cf4a
Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory 
Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).
 2020-05-31 02:24:49 +03:00
Dean Herbert aea192080a Fix incorrect storage name 2020-05-15 13:02:46 +09:00
Dean Herbert 7641507c90 Ensure test directories are deleted before subsequent run 2020-05-15 10:45:57 +09:00
Dean Herbert 0690d81bbb Add protection against migrating to a nested folder 2020-05-15 10:40:26 +09:00
Dean Herbert 19f117ae53 Update test logic for new exception type 2020-05-15 10:28:03 +09:00
Dean Herbert 827d75b152 Revert "Add protection against migrating to a nested folder" 
This reverts commit ef8375b442.
 2020-05-14 22:44:27 +09:00
Dean Herbert ef8375b442 Add protection against migrating to a nested folder 2020-05-14 22:42:42 +09:00
Dean Herbert e4a23b3e7d Fix ignored excluding more than top level 2020-05-12 12:39:04 +09:00
Dean Herbert 6c350db097 Add connection flushing support 2020-05-11 21:39:44 +09:00
Dean Herbert 36640f5dda Merge branch 'master' into migration-backend 2020-05-11 18:52:36 +09:00
Dean Herbert 384862d48b Fix incorrect relative paths when using GetStorageForDirectory 2020-05-10 13:20:13 +09:00
Dean Herbert 5dda94187e Add more edge case testing 2020-05-09 20:13:44 +09:00
Dean Herbert 5e65bda8d8 Add test coverage 2020-05-07 22:12:24 +09:00
Dean Herbert 4ac5ed71f4 Remove redundant string interpolation 2020-05-07 21:48:57 +09:00
Dean Herbert 90e17853a8 Update tests in line with framework changes 2020-05-07 18:12:11 +09:00
Dean Herbert 6621d363da Add basic custom data directory support 2020-05-04 17:01:05 +09:00