Commit Graph

515 Commits

Author SHA1 Message Date
Dean Herbert f726c38215 Pass `ArchiveReader` instead of `Stream` to simplify resolution code 2023-09-19 17:49:15 +09:00
Dean Herbert 0593c76c57 Fix log output using incorrect name 2023-09-19 17:34:24 +09:00
Bartłomiej Dach 59b9a636d3
Fix grammar in comment 2023-09-18 10:46:14 +02:00
cdwcgt f68a12003a
check beatmap hash before try to import 2023-09-04 17:37:31 +09:00
cdwcgt 58844092d6
post a notification instead a screen 2023-09-04 16:17:21 +09:00
cdwcgt dfecddbf5d
Merge branch 'master' into missing-beatmap 2023-09-04 12:41:23 +09:00
Dean Herbert b3e7416972 Rename new flag and update xmldoc to match 2023-08-21 19:36:22 +09:00
Dean Herbert 662073c472
Fix some incorrect comments / test step descriptions
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-21 19:35:04 +09:00
cdwcgt 09047538c7
remove all memory stream dispose 2023-08-04 20:02:22 +09:00
cdwcgt 0e7e36f114
don't passing stream by exception 2023-08-02 22:04:29 +09:00
cdwcgt 6637a5e7bc
ensure Performer not null 2023-08-02 18:53:27 +09:00
cdwcgt 4c43c92329
ensure dispose stream 2023-08-02 17:58:17 +09:00
cdwcgt eef63b41da
fetch missing beatmap when import score with missing beatmap 2023-08-02 17:58:05 +09:00
Dean Herbert 30baac0f3d Avoid reprocessing scores which already failed an upgrade previously
Closes https://github.com/ppy/osu/issues/24301.
2023-07-26 16:22:10 +09:00
Dean Herbert c1ba8fe175 Rename `BackgroundBeatmapProcessor` to `BackgroundDataStoreProcessor` 2023-07-26 16:22:10 +09:00
Dean Herbert eb81eac635 Flag decoded scores more correctly 2023-07-15 12:19:18 +09:00
Dean Herbert d72765b6f8
Merge pull request #24114 from peppy/editor-save-local-score-management
Ensure scores always have the correct linked `BeatmapInfo`
2023-07-07 15:40:54 +09:00
Bartłomiej Dach ae2896ba7e
Sprinkle some more null-forgiving operators 2023-07-06 22:08:48 +02:00
Dean Herbert a98a36872e Bring realm library up-to-date 2023-07-06 13:37:43 +09:00
Dean Herbert 9ff6b3fcd3 Merge branch 'master' into editor-save-local-score-management 2023-07-06 12:28:44 +09:00
Dean Herbert 00c68cad53 Fix new scoring related properties not storing to realm due to `internal` spec 2023-07-05 19:47:44 +09:00
Dean Herbert 5947c2b298 Throw if a null `BeatmapInfo` arrives during score import process 2023-07-05 16:08:06 +09:00
Bartłomiej Dach a55809733d
Expand `ScoreInfo.BeatmapInfo` xmldoc 2023-07-04 22:20:50 +02:00
Dean Herbert f2aa80f413 Rename and adjust xmldoc on `TotalScoreVersion` 2023-07-04 20:04:02 +09:00
Dean Herbert a0c3fa9c13 Move preconditions to realm migration step to simplify marker version logic 2023-07-04 17:53:53 +09:00
Dean Herbert d74b1e148d Make `ScoreInfo.BeatmapInfo` nullable 2023-07-04 14:50:34 +09:00
Dean Herbert 4203e2183d
Merge branch 'master' into diffcalc-total-scorev1 2023-07-04 14:15:24 +09:00
Cootz 8d25e2c3e1 Add importer update test 2023-07-01 09:49:06 +03:00
Dan Balasescu 6822871dab Move population of LegacyTotalScore to ScoreImporter 2023-06-29 17:21:24 +09:00
Dan Balasescu ddd870e843 Make LegacyTotalScore nullable 2023-06-29 17:19:10 +09:00
Dan Balasescu 1ca4e39fc3 Allow legacy scores to be displayed in "classic" scoring mode 2023-06-28 16:30:50 +09:00
Dan Balasescu 09bc8e45de Refactoring 2023-06-28 16:14:32 +09:00
Dan Balasescu e291dff5ad Fix imported scores not getting LegacyTotalScore 2023-06-28 14:50:16 +09:00
Dan Balasescu 6e2369e651 Add xmldoc on LegacyTotalScore 2023-06-27 17:18:32 +09:00
Dan Balasescu 0c5c09597c Store old total score as LegacyTotalScore 2023-06-27 14:59:40 +09:00
Dan Balasescu a9c65d200a Initial conversion of scores 2023-06-26 22:19:01 +09:00
Dan Balasescu 8e79510793 Add migration for total score conversion 2023-06-26 21:53:21 +09:00
Bartłomiej Dach 66ef199fa4
Revert nullability enable in `Score` (and related changes)
Causes several knock-on inspections in `OsuGame` et al. Probably best
addressed in a separate pass, because treatment is mixed at best (some
places nullcheck, some expect non-null).
2023-06-24 15:35:07 +02:00
Dean Herbert df5b389629 Manual fixes to reduce warnings to zero 2023-06-24 01:52:53 +09:00
Dean Herbert 0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Dean Herbert 362aa4b376 Also move `GetMaxAchievableCombo` 2023-06-16 15:26:13 +09:00
Dean Herbert ce41ef6e5d Move `OrderByTotalScore()` to an extension method 2023-06-16 15:24:30 +09:00
Bartłomiej Dach 51b5a0863f
Apply migration to new standardised score on normal reimport too 2023-06-15 21:53:15 +02:00
Dean Herbert 659a042065
Merge pull request #23844 from peppy/memory-caching-nrt
Apply NRT to `MemoryCachingComponent` classes
2023-06-09 23:28:21 +09:00
Bartłomiej Dach 52412c673d
Bump replay version in encoder after Score V2 changes
One release too late, but this may help in the future if we need to
discern replays set with Score V2 from older lazer replays.
2023-06-09 14:49:49 +02:00
Bartłomiej Dach 11694f35fe
Apply NRT in `MemoryCachingComponent` subclasses too 2023-06-09 13:47:35 +02:00
Dean Herbert c5e77e13de Add a very simple user cache to `ScoreImporter` 2023-06-09 19:03:28 +09:00
Dan Balasescu 76df11c398 Don't scale stable scores with the classic scoring mode 2023-06-08 21:38:10 +09:00
Dan Balasescu facf7de053 Parse ScoreInfo.IsLegacyScore from replays 2023-06-08 21:38:10 +09:00
Dean Herbert 4e0f40bee5 Split out multiplier retrieval into a function and use a default multiplier for all rulesets 2023-05-30 14:20:26 +09:00