Commit Graph

51692 Commits

Author SHA1 Message Date
Salman Ahmed
a42f5ea34e Bring back virtual track condition given its cheapness
Will still keep the override in `ClockBackedTestWorkingBeatmap` because
it still relies on a local track store and will fail the moment it uses
a non-virtual track.
2022-05-21 16:51:56 +03:00
Salman Ahmed
466ed3c791
Fix wrong return xmldoc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-21 16:43:31 +03:00
Salman Ahmed
abf9039109 Use == instead of ?? 2022-05-20 16:08:31 +03:00
Salman Ahmed
cef99fd020 Disallow transferring track from test WorkingBeatmaps which have local stores 2022-05-20 16:08:31 +03:00
Salman Ahmed
c78d90ccbd Refactor track transferring logic for ability to override and disallow 2022-05-20 14:43:07 +03:00
Dan Balasescu
64a371638e
Merge pull request #18236 from peppy/snap-unification
Add `enum` to snap method as alternative to multiple nested invocations
2022-05-20 11:35:05 +09:00
Dean Herbert
77b4bd97f8
Merge pull request #18156 from ekrctb/catch-editor-per-object-sv
Automatically adjust per-hit object slider velocity in osu!catch editor
2022-05-19 19:12:38 +09:00
Dan Balasescu
bef0cbf178
Merge pull request #18335 from peppy/better-first-run-toolbar-handling
Fix toolbar potentially being in incorrect state after exiting the first run setup
2022-05-19 17:20:47 +09:00
Dean Herbert
363e7a6f53 Simplify toolbar hiding logic in FirstRunSetupOverlay
Rather than fiddling around with the activation modes, this seems like a
much cleaner way to make things work.

Closes https://github.com/ppy/osu/issues/18277.
2022-05-19 16:42:48 +09:00
Dean Herbert
b3d6f76cfa Add "None" snap type to fix flags not working correctly 2022-05-19 15:57:17 +09:00
Dean Herbert
5af7641e94 Add safety against playfield potentially not being available during mania note placement 2022-05-19 15:53:53 +09:00
Dean Herbert
16075d2a2f
Merge pull request #18321 from smoogipoo/legacy-catmull
Fix compatibility issues with legacy Catmull sliders
2022-05-19 15:42:21 +09:00
Dean Herbert
d187ca2d8c
Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels
Add drawable channel caching to new chat overlay
2022-05-19 15:15:47 +09:00
Dan Balasescu
5709dc566a
Merge pull request #18313 from peppy/first-run-screen-import-from-stable
Add first run screen for importing from previous installation
2022-05-19 14:56:44 +09:00
Dean Herbert
ce3a3542ea
Merge pull request #18333 from peppy/ignore-misc-xml
Delete and ignore rider's `misc.xml`
2022-05-19 14:03:27 +09:00
Dean Herbert
70bd40ce44 Fix incorrect count of beatmaps available to import 2022-05-19 14:01:24 +09:00
Dean Herbert
f6fb8f3fb9 Delete and ignore rider's misc.xml
This file has changed on us too many times. Doesn't seem to contain
anything of value.
2022-05-19 13:55:19 +09:00
Dean Herbert
a443200d0d Make dependency nullable to allow for safer disposal unbinding 2022-05-19 13:49:52 +09:00
Dean Herbert
1f6f06562b
Merge pull request #18329 from smoogipoo/ci-improvements
Bust CI cache on CodeAnalysis ruleset changes
2022-05-19 12:44:50 +09:00
Dan Balasescu
3bca014b52 Bust CI cache on CodeAnalysis ruleset changes 2022-05-19 09:44:11 +09:00
Salman Ahmed
5d3878a737 Add test coverage for slow-loading channels 2022-05-18 22:58:39 +03:00
Jai Sharma
371738b047 Check against the loaded drawable channel 2022-05-18 20:00:42 +01:00
Salman Ahmed
ccecf1cd6a
Merge pull request #18322 from peppy/banned-symbol-guid
Add `new Guid` bannedsymbols rule
2022-05-18 21:02:17 +03:00
Salman Ahmed
f5235f6a56 Correctify recommended method and property 2022-05-18 20:38:13 +03:00
Dean Herbert
0cee90e156 Add common strings for missing localisable content 2022-05-18 21:32:57 +09:00
Dean Herbert
d54e1503c7 Rename interaction toggle method 2022-05-18 21:32:57 +09:00
Dean Herbert
fa09270e62 Remove left-over todo 2022-05-18 21:32:57 +09:00
Dean Herbert
df4968a55b Add new Guid bannedsymbols rule 2022-05-18 21:20:14 +09:00
Dan Balasescu
731f0960ec Don't merge adjacent legacy Catmull segments 2022-05-18 17:16:24 +09:00
Dan Balasescu
fe49a7e678 Add failing tests 2022-05-18 17:10:19 +09:00
Dean Herbert
e652180873
Merge pull request #18319 from smoogipoo/package-json-files
Package .json files in nupkg output
2022-05-18 14:38:40 +09:00
Dan Balasescu
3f71224dfc Package .json files in nupkg output 2022-05-18 14:05:21 +09:00
Bartłomiej Dach
c2555a91c7
Merge branch 'master' into first-run-screen-import-from-stable 2022-05-17 22:52:01 +02:00
Bartłomiej Dach
79215c37a4
Merge pull request #18311 from peppy/first-run-screen-button-ux
Improve the first run progress button to show loading and completion status
2022-05-17 22:49:49 +02:00
Bartłomiej Dach
10b881dbf7
Merge branch 'master' into first-run-screen-button-ux 2022-05-17 22:27:49 +02:00
Dean Herbert
02198d0436
Merge pull request #18289 from bdach/mod-overlay/adjust-multiplier-scale-transition
Adjust difficulty multiplier pop in/out transition on mod overlay
2022-05-17 18:21:30 +09:00
Dean Herbert
062ffe64ac Remove delay on pop in 2022-05-17 18:21:19 +09:00
Dean Herbert
1b7ec1be26 Add basic test coverage of new screen 2022-05-17 18:15:14 +09:00
Dean Herbert
bf00b062ad Add full localisation of import beatmaps screen 2022-05-17 17:58:24 +09:00
Dean Herbert
f4e0ad8c4c Fix drag drop of osu! folder not working as expected 2022-05-17 17:51:28 +09:00
Dean Herbert
83e781d5a1 Allow localisation of PlaceholderText 2022-05-17 17:42:46 +09:00
Dean Herbert
c0de1f96ff Tidy up interaction toggling and add progress message 2022-05-17 17:33:54 +09:00
Dean Herbert
17e0105c2c Fix interaction with popover when textbox is disabled 2022-05-17 17:33:54 +09:00
Dean Herbert
03d3900a02 Fix incorrect default state of checkboxes 2022-05-17 17:33:54 +09:00
Dean Herbert
30fdbc3de0 Add safety against calling GetStableImportPaths when path doesn't exist 2022-05-17 17:33:54 +09:00
Dean Herbert
adc7b61240 Switch directory selector to use a semi-shared popover implementation 2022-05-17 17:33:54 +09:00
Dean Herbert
3ff0399281 Split out LabelledTextBoxWithPopover for reuse 2022-05-17 17:33:54 +09:00
Dean Herbert
8112416335 Assert that downloads are queued early enough to work 2022-05-17 17:33:54 +09:00
Dean Herbert
e2ea98693f Tidy up buttons and text 2022-05-17 17:33:54 +09:00
Dean Herbert
98e5ad44a7 Add OverlayColourProvider support to OsuDirectorySelector 2022-05-17 17:33:54 +09:00