Commit Graph

852 Commits

Author SHA1 Message Date
smoogipoo f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
Dean Herbert fa693bb8a8 Move `MusicController` adjustment set to inside `OsuScreen` itself (and result `nullable`) 2021-09-16 16:08:09 +09:00
AbstractQbit 318f0941ca Move all the "inherit previous `AllowTrackAdjustments`" logic into `OsuScreen` 2021-09-15 21:25:39 +03:00
AbstractQbit b87af3dd68 Move the inherited `AllowTrackAdjustments` into `OsuScreen` 2021-09-15 10:55:16 +03:00
AbstractQbit bd18c581c1 Replace `allowTrackAdjustmentsStack` with a Dictionary 2021-09-14 21:14:24 +03:00
AbstractQbit 01d2f4f17a Make `allowTrackAdjustmentsStack` readonly 2021-09-14 18:04:43 +03:00
AbstractQbit b9193aae6d Make IOsuScreen.AllowTrackAdjustments nullable
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
Dean Herbert 7c60c6a733
Merge pull request #14571 from rednir/get-user-from-username
Add ability to open user profile links with username instead of user ID
2021-09-06 00:15:09 +09:00
Davran Dilshat e5f886a315 revert unnecessary change 2021-09-05 10:45:38 +01:00
Joseph Madamba a773a22726 Fix toolbar hiding when clicking home button 2021-08-31 14:29:16 -07:00
rednir c789163d01
use user ID overload when its supposed to be used
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-30 13:22:12 +01:00
Davran Dilshat 90c313e2ad add methods to get a user from their username 2021-08-29 19:19:55 +01:00
Joseph Madamba 38912bfc16 Fix floating overlays not closing when clicking some empty area of the toolbar 2021-08-28 20:38:35 -07:00
Salman Ahmed 9a6ff29951
Reword comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-21 15:39:57 +03:00
Salman Ahmed 1729d43cec Add explanatory comment 2021-08-21 15:18:03 +03:00
Salman Ahmed 20f193c1c2 Fix screen offsetting not handling scaled game instances
By using `Content` instead, now the logic will get the X of the settings
overlay at the `Content` space, which can be scaled in the
`ScalingMode.Everything` mode.

And in the case of `ScalingMode.ExcludeOverlays`, a subcontainer
somewhere inside `Content` that's holding the screen stack would be scaled,
but `Content` won't be affected which is what we want in that case.
2021-08-21 04:16:12 +03:00
Dean Herbert 82eddeffef Add `LocalUserPlayInfo` interface to convey common information about player status 2021-08-17 16:15:47 +09:00
Dean Herbert 93b97e5110 Adjust ratio to match previous behaviour 2021-08-13 16:35:22 +09:00
Dean Herbert c1d67976e6 Rename const, add xmldoc and make protected 2021-08-13 16:29:36 +09:00
Salman Ahmed bb1d74255e Remove unrequired parenthesis 2021-08-12 14:16:20 +03:00
Salman Ahmed 3d7866e82d Calculate horizontal offset on present overlays only 2021-08-12 14:15:01 +03:00
Salman Ahmed b58b5ec2b4 Apply horizontal offset changing once per frame
The previous way was causing every-frame invalidation when an overlay is
visible.
2021-08-12 12:44:38 +03:00
Salman Ahmed d099bb8ab6 Calculate offsets from overlay `ScreenSpaceDrawQuad`s instead 2021-08-07 21:08:26 +03:00
Salman Ahmed e924ea8d93 Make `ScreenOffsetContainer` privatly settable only 2021-08-07 18:52:27 +03:00
Salman Ahmed 8dc0650ca7 Add test coverage 2021-08-06 22:56:43 +03:00
Salman Ahmed f77037ef57 Replace state-based screen offsetting logic with `HorizontalScreenOffset`s 2021-08-06 18:38:57 +03:00
Henry Lin 89e8296eb1 Reset all types of adjustments in `MusicController`; Rename `AllowRateAdjustments` to `AllowTrackAdjustments` 2021-07-29 15:39:26 +08:00
Bartłomiej Dach b1087d14f3
Merge branch 'master' into skin-editor-button-access 2021-07-22 22:49:44 +02:00
Dean Herbert db6f323266 Output startup component load start/end times to non-debug logs
Useful for diagnosing issues in cases like #13981.
2021-07-22 14:45:57 +09:00
Dean Herbert 9c4fbf45e9 Add the ability to enter and exit the skin editor via on-screen buttons 2021-07-20 19:36:12 +09:00
Dean Herbert ed29646291 Remove `IApplicableToDifficulty.ReadFromDifficulty`
This was added specifically for `ModDifficultyAdjust`, but turned out to
be more of a headache than we expected. We have since removed usage and
would hope that this is not required by any other mods.

Opting for complete removal rather than obsoletion, as we discovered
this was already broken in multiple cases, with fixes being quite
logically complex.

If you happen to be a ruleset developer relying on this, open an issue
and we'll talk you through a better approach (or check what
`ModDifficultyAdjust` is doing now for an example).
2021-07-14 12:32:16 +09:00
Bartłomiej Dach fbe3b447e5 Merge branch 'master' into linkify-metadata 2021-07-03 15:51:08 +02:00
Bartłomiej Dach 16d08df5e2 Remove mention of direct from xmldoc 2021-07-03 15:22:03 +02:00
Dean Herbert f2d9d78455 Fix some incorrectly invoked `async` calls 2021-07-02 14:43:48 +09:00
Dean Herbert 31dbc7798b Merge branch 'master' into linkify-metadata 2021-07-01 19:41:33 +09:00
Dean Herbert 3816c486d5 Guard against a potential startup crash if user's preferred ruleset has a compatibility issue
Resolves this issue seen at https://github.com/ppy/osu/issues/13722#issuecomment-872088071.
2021-07-01 19:03:58 +09:00
Dean Herbert b6e07ff59c
Merge pull request #13572 from bdach/fix-unsupported-locales
Fix game crashes due to attempting localisation load for unsupported locales
2021-06-19 17:09:39 +09:00
Dean Herbert afcc3e14f4
m 2021-06-19 16:16:29 +09:00
Bartłomiej Dach 76db87f9cb Try-catch around localisation store registration
Some platforms (android, older windows versions) will throw exceptions
at runtime when an unsupported `CultureInfo` is attempted to be
instantiated, leading to nasty crashes. Add a preventative try-catch
registration to prevent the crash, and log the errors for visibility.
2021-06-19 08:02:30 +02:00
Dean Herbert d06e52505a Fix thread safety of `KeyBindingStore.GetReadableKeyCombinationsFor` 2021-06-18 17:11:39 +09:00
smoogipoo 19f0e3d695 Add HighPerformanceSession 2021-06-16 20:53:48 +09:00
Bartłomiej Dach cc5145a131 Fix languages with a sub-language part not working properly 2021-06-16 11:10:03 +02:00
Dean Herbert 68fa7d68cc
Merge pull request #13511 from smoogipoo/fix-possible-nullref-2
Fix possible nullref in difficulty recommender
2021-06-16 15:20:45 +09:00
smoogipoo a5261f0cb3 Add difficulty recommender instantly 2021-06-16 11:48:49 +09:00
smoogipoo 579a4aa9c8 Remove comment 2021-06-15 14:10:09 +09:00
smoogipoo eb4c093371 Use hash as fallback 2021-06-15 14:06:17 +09:00
smoogipoo f6c6eea6dc Make PresentScore() only consider replay hash 2021-06-15 11:16:35 +09:00
Dean Herbert 26312bf60a
Merge branch 'master' into chat-mention 2021-06-11 20:03:44 +09:00
Dean Herbert 3d645608eb Remove nullability of DI dependencies and fix incorrect load order 2021-06-11 16:28:53 +09:00
smoogipoo 0b9916b266 Add parens to declare operator precedence 2021-06-08 18:39:52 +09:00