62176 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	91c3ae4fef	Merge pull request #24680 from peppy/tournament-remove-minimum-window-size ... Remove tournament client minimum window size	2023-08-30 09:35:59 +02:00
Bartłomiej Dach	8398e07be9	Merge branch 'master' into tournament-remove-minimum-window-size	2023-08-30 08:21:08 +02:00
Bartłomiej Dach	0f123fd8e0	Remove unused using directive	2023-08-30 08:20:57 +02:00
Bartłomiej Dach	fb8e3df582	Merge pull request #24679 from peppy/tournament-save-via-keyboard ... Allow saving changes in tournament system using `Ctrl`+`S`	2023-08-30 08:18:01 +02:00
Bartłomiej Dach	9b013beb1a	Merge pull request #24614 from peppy/carousel-difficulty-split ... Split out individual difficulties when using difficulty sort at song select	2023-08-30 08:06:44 +02:00
Dean Herbert	96a5443813	Merge branch 'master' into carousel-difficulty-split	2023-08-30 14:24:30 +09:00
Dean Herbert	cbd4b91feb	Merge pull request #24678 from Nabile-Rahmani/bot-scores ... Fix and use score user's IsBot property in results screen animation	2023-08-30 14:00:35 +09:00
Dean Herbert	24d6cbefe1	Remove tournament client minimum window size ... This seemed like a good idea but people were using it with smaller resolutions, do let's just not do it. Addresses https://github.com/ppy/osu/discussions/24670.	2023-08-30 13:45:00 +09:00
Dean Herbert	a85f0d5791	Allow saving changes in tournament system using Ctrl+S	2023-08-30 13:29:08 +09:00
Dean Herbert	d3e40f89e2	Merge pull request #24675 from bdach/hide-score-v2-mod ... Mark "Score V2" mod as not user-playable	2023-08-30 13:18:27 +09:00
Nabile Rahmani	270e2a6600	Update osu.Game/Rulesets/Mods/ModExtensions.cs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-29 23:59:08 +02:00
Nabile Rahmani	b658b0e346	Fix and use score user's IsBot property in results screen animation ... While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties. As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance. Related to PR #24675	2023-08-29 23:28:50 +02:00
Bartłomiej Dach	d07530b241	Mark "Score V2" mod as not user-playable ... The mod generally will only be present on scores imported from stable. As such, it's probably ok to mark it as such. The primary reason for this change is to address #24436 (Score V2 being visible on beatmap overlay leaderboard mod selector). There is one possibly-unintended consequence of this change, namely that the results screen uses `UserPlayable` to determine as to whether animations should be played back, with the intention of turning off the animation playback for autoplay scores specifically. Therefore, turning off this flag will mean that the results screen animations will not play out for Score V2 scores - but I tend to consider this as either largely unimportant, or something that should be fixed in some other way (possibly by checking against the autoplay mod directly). Other usages of `UserPlayable` are either innocuous, or straight-up good safeties going forward in the context of Score V2 (guards against selection in mod select overlays, against score submission with the mod).	2023-08-29 11:52:11 +02:00
Bartłomiej Dach	118c86df34	Fix TestSceneUpdateBeatmapSetButton using random difficulty count	2023-08-28 14:57:00 +02:00
Dean Herbert	d701a25969	Merge pull request #24668 from bdach/disable-redundant-verbatim-string-prefix-inspections ... Disable redundant verbatim string prefix inspections	2023-08-28 21:21:52 +09:00
Bartłomiej Dach	ba1f6439bf	Disable redundant verbatim string prefix inspections ... For some reason this started flaring up recently all over for me and showing inspections all over, which are _technically_ valid, but interfere with our convention of using verbatim string prefixes to denote non-localisable strings. This, as a result, led to circular inspections (addressing the r# inspection results in getting the osu-localisation-analyser one, addresssing that one results in getting the r# inspection back, etc. ad nauseam).	2023-08-28 12:44:57 +02:00
Bartłomiej Dach	97d1c6e9fc	Merge branch 'master' into carousel-difficulty-split	2023-08-28 11:07:43 +02:00
Bartłomiej Dach	b9795eb3d4	Fix changes to beatmap sets being undone on switching sort mode	2023-08-28 11:02:22 +02:00
Bartłomiej Dach	80ec18d117	Fix incorrect selection restore code in split case ... The fallback to "any of the added sets" needs to be applied after they've all been added, rather than with every added one. Otherwise, in flows that expect a particular difficulty to be selected in the end (such as exiting from editor) would end up switching away from the edited beatmap.	2023-08-28 10:06:26 +02:00
Bartłomiej Dach	0af6cc1394	Fix online ID not being propagated in split difficulty mode ... Would result in failures to re-download the beatmap in update flows, for instance.	2023-08-28 10:05:59 +02:00
Bartłomiej Dach	6251803868	Add failing test coverage of selection not being retained on song select	2023-08-28 10:05:59 +02:00
Bartłomiej Dach	3a6920c306	Add failing test coverage of beatmap update flow w/ split diffs	2023-08-28 09:51:44 +02:00
Dean Herbert	10b1450138	Rename remove method to better explain return type being IEnumerable	2023-08-25 18:10:54 +09:00
Dean Herbert	84f4fab9cf	Adjust test to actually test diff splitting	2023-08-25 18:09:51 +09:00
Dean Herbert	d70df88fa0	Merge pull request #24645 from Dreamurrrr/Dreamurrrr-patch-1 ... Update README.md to include VS Code plugin prerequisites	2023-08-25 13:48:26 +09:00
Dreamurrrr	4fd165c0a7	Update README.md to include VS Code plugin prerequisites	2023-08-24 13:28:17 -05:00
Dean Herbert	1efd557b96	Merge pull request #24576 from nekodex/new-overlay-sfx ... Update overlay pop-in/pop-out sample usage	2023-08-25 01:47:55 +09:00
Dean Herbert	bf0f4fddad	Localise non-overridden samples	2023-08-25 01:08:22 +09:00
Dean Herbert	35cdd6d866	Use string.Empty	2023-08-25 01:07:07 +09:00
Dean Herbert	89eeff515b	Reduce complexity of selection restore	2023-08-25 00:52:54 +09:00
Dean Herbert	9e94f38091	Fix typo in local variable	2023-08-24 18:33:15 +09:00
Dean Herbert	b471ab07a6	Fix typo in test step ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-24 18:30:59 +09:00
Dean Herbert	081fb308e1	Merge branch 'master' into new-overlay-sfx	2023-08-24 18:29:00 +09:00
Jamie Taylor	f4415a5bab	Add more detail to comment	2023-08-24 18:20:36 +09:00
Jamie Taylor	7ef5a71e91	Move PopIn/PopOut sample playback from WaveOverlayContainer to WaveContainer (so Multiplayer/Lounge plays the samples)	2023-08-24 18:13:23 +09:00
Jamie Taylor	2e27a476bb	Re-enable sample playback for PasswordEntryPopover and remove sampleJoin playback instead	2023-08-24 18:04:47 +09:00
Bartłomiej Dach	90dfef2bb9	Merge pull request #24628 from bdach/export-note-lock-test-cases ... Add capability to export ordered object policy test cases for stable crosscheck	2023-08-24 08:42:27 +02:00
Dean Herbert	981e0c1ad7	Rename export test step to better fit purpose	2023-08-24 14:26:26 +09:00
Bartłomiej Dach	7312d1147d	Merge branch 'master' into export-note-lock-test-cases	2023-08-24 07:17:38 +02:00
Dean Herbert	d01b065b4a	Merge pull request #24627 from bdach/no-custom-hitwindows ... Rewrite `TestSceneObjectOrderedHitPolicy` to not rely on custom hitwindows	2023-08-24 13:50:06 +09:00
Dean Herbert	ba70d48d2c	Fix one more test probably going off-screen	2023-08-24 13:31:33 +09:00
Bartłomiej Dach	9ef0ae53d1	Merge pull request #24634 from peppy/enable-sentry-global-mode ... Enable sentry "global mode" as per recommendation	2023-08-23 20:58:48 +02:00
Dean Herbert	4881130cae	Limit set/diff count in test to better fit on screen	2023-08-24 03:32:12 +09:00
Dean Herbert	a8e4237e34	Enable sentry "global mode" as per recommendation ... Sentry documentation suggests this should be on for a client-facing app. We haven't run into issues without it until now, but might as well set it correctly?	2023-08-24 03:23:18 +09:00
Bartłomiej Dach	8d24bf5049	Merge pull request #24632 from peppy/mod-bool-display-improvement ... Show mod settings as "on" or "off" rather than "True" or "False"	2023-08-23 19:47:55 +02:00
Bartłomiej Dach	052bf2a6e0	Use alternative solution for timing offset woes on export	2023-08-23 13:54:34 +02:00
Dean Herbert	72d2715222	Show mod settings as "on" or "off" rather than "True" or "False"	2023-08-23 20:21:43 +09:00
Dean Herbert	d6aded3ac3	Update framework	2023-08-23 20:11:55 +09:00
Bartłomiej Dach	b1979954f5	Merge pull request #24631 from peppy/add-colon-mod-settings ... Add missing colon in mod settings tooltip	2023-08-23 12:46:33 +02:00
Dean Herbert	5eac604f8b	Add coverage of selection retention when difficulties are split out	2023-08-23 19:44:42 +09:00