RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
61,225 Commits 3 Branches 659 Tags 360 MiB
Commit Graph

32 Commits

Author SHA1 Message Date
Dean Herbert 978d15955c Fix control points not being cloned when running beatmap conversion 
Closes #20994.

I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.

I've tested using the scenario in the linked issue.

I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
should correctly cover this scenario once we are serialising control
points as well.
 2022-11-01 17:42:09 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert 1373cc02d7 Shallow clone `BeatmapInfo` during conversion process to avoid overwriting fields 2021-10-12 16:43:56 +09:00
smoogipoo 8293b06c0a Remove obsolete code 2021-04-09 13:56:58 +09:00
Dean Herbert 6d4c1ba2ae Fix a couple of new inspections introduced in Rider EAPs 2021-03-15 13:35:08 +09:00
smoogipoo de5ef8a471 Rework to support obsoletion 2020-09-17 21:37:32 +09:00
smoogipoo c7d24203ce Make beatmap conversion support cancellation tokens 2020-09-17 17:40:05 +09:00
smoogipoo 1116703e92 Fix potential out-of-order objects after conversion 2020-07-13 16:52:05 +09:00
Dan Balasescu 9702cc9809
Merge branch 'master' into remove-legacy-id 2019-12-25 21:01:12 +09:00
Dean Herbert 0677f746aa Provide the ruleset to converter classes 2019-12-24 16:02:16 +09:00
smoogipoo 6e7426a098 Simplify/improve beatmap conversion precheck 2019-12-23 17:44:18 +09:00
smoogipoo 0bd35ab7bb Turn on warnings, resolve issues 2019-04-25 17:36:17 +09:00
Dean Herbert 26d53d06a9 Fix remaining issues 2019-02-28 13:31:40 +09:00
Dean Herbert 8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
smoogipoo d431dd59a8 Cleanups 2018-10-17 10:53:21 +09:00
smoogipoo 41391a6627 Fix beatmap conversion tests failing 2018-10-16 12:01:58 +09:00
smoogipoo fb1760f580 Simplify linq from beatmap conversion 2018-10-11 20:29:37 +09:00
smoogipoo 397d93660a Don't deep-clone beatmapinfo/control points 2018-05-17 13:17:33 +09:00
smoogipoo 30a3f4f29f Fix not being able to convert beatmaps with 0 hitobjects 2018-05-07 15:27:45 +09:00
smoogipoo 03a5df84c6 Initial rework of beatmap conversion process 2018-04-19 22:04:12 +09:00
smoogipoo 66b3b295e7 Use IBeatmap wherever possible 2018-04-19 20:44:38 +09:00
smoogipoo b5a55a0dce Make an interface for beatmaps 2018-04-19 18:58:40 +09:00
Dean Herbert 32a74f95a5 Normalize all the line endings 2018-04-13 18:26:38 +09:00
Dean Herbert 9a0fc9e29a Move combo colours completely out of beatmap 2018-03-20 16:24:06 +09:00
Dean Herbert 16eab2eebf Fix combo colours not working until now 2018-03-13 19:19:08 +09:00
smoogipoo a2c239d5e3 Rename to IBeatmapConverter, move to separate file 2018-03-02 20:19:47 +09:00
smoogipoo 797d03a65f Implement basic structure for beatmap conversion testing 2018-03-02 13:13:00 +09:00
Dean Herbert 37d393bca0 Update licence headers 2018-01-05 20:21:19 +09:00
smoogipoo bd171926d6 Remove AvailableColumns from ManiaRulesetContainer 
Also restructures with the addition of a ManiaBeatmap which holds definitions for "groups" of columns. At the moment these are empty save for a "Column" property, but can be expanded in the future, maybe.
 2018-01-03 18:44:25 +09:00
Dean Herbert 23b4d2163c Fix spelling and grammar 2017-11-28 21:30:03 +09:00
Dean Herbert bd88df2722 Add note about sequential execution of ConvertHitObject 2017-11-28 18:33:41 +09:00
Dean Herbert 6d3d485565 And then everything became one 2017-09-19 16:06:58 +09:00