RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
58,509 Commits 3 Branches 658 Tags 356 MiB
Commit Graph

58509 Commits

Author SHA1 Message Date
Dean Herbert 8caf960f9a Revert weird nullable changes to `Skin.cs` 2023-01-25 14:43:46 +09:00
Dean Herbert 0a9b20d5d5 Split lookup store into own file / class 2023-01-25 14:43:46 +09:00
Dean Herbert c1a5c16973 Reduce maximum texture size to a more commonly-supported `8192` 2023-01-25 14:43:46 +09:00
Dean Herbert d000a4ed28 Make sure to dispose of the original texture upload as we are replacing it 2023-01-25 14:43:46 +09:00
Dean Herbert 598c6fcbad Add basic support for stupidly long hold note skin textures 2023-01-25 14:43:46 +09:00
Dean Herbert 3cd810f332
Merge pull request #22265 from Wleter/SliderEnd-Snap 
Add snapping sliderends with nearby objects
 2023-01-24 13:43:43 +09:00
Dean Herbert bc717b1f25
Merge pull request #22381 from Susko3/fix-osu-touch-with-screen-scaling 
Fix touches not being handled outside `OsuTouchInputMapper` when using screen scaling
 2023-01-24 11:07:11 +09:00
Dean Herbert 949610c8a4 Add commentary as to why `ReceivePositionalInputAt` override is required 2023-01-24 11:06:54 +09:00
Susko3 a992682276 Fix `OsuTouchInputMapper` not handling all touches when using screen scaling 2023-01-23 21:46:01 +01:00
Bartłomiej Dach 7483967157
Merge branch 'master' into SliderEnd-Snap 2023-01-23 21:33:16 +01:00
Bartłomiej Dach 1f40b2daf6
Clean up xmldocs 2023-01-23 21:22:18 +01:00
Bartłomiej Dach 9f2ed853eb
Merge pull request #22371 from peppy/more-settings-keywords 
Add more keywords to settings based on feedback
 2023-01-23 20:19:53 +01:00
Dean Herbert d695214ae1
Merge pull request #22277 from stanriders/level-badge-colour 
Add tiered level badge colouring
 2023-01-23 16:21:28 +09:00
Dean Herbert 432e0a6a37
Merge branch 'master' into level-badge-colour 2023-01-23 15:46:15 +09:00
Dean Herbert 736965e009 Fix test scene potentially overflowing visible region 2023-01-23 15:45:44 +09:00
Dean Herbert 9c2494383f Rename fetch method to be non-plural to match all others 2023-01-23 15:43:52 +09:00
Dean Herbert e3932c077b
Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt 
Fix advanced statistics display potentially performing invalid difficulty calculation
 2023-01-23 15:39:47 +09:00
Dean Herbert 7ebd31d42f Add more keywords to settings based on feedback 2023-01-23 15:14:16 +09:00
Dean Herbert 2ed9fe3747 Add support for externally specified keywords in `SettingsButton`s 2023-01-23 15:10:26 +09:00
Dean Herbert 73f083a316 Refactor how additional points are provided to avoid confusion 2023-01-23 14:13:46 +09:00
Dean Herbert f87bb589a2
Merge pull request #22340 from EXtremeExploit/groups-modes 
Add modes text to groups tooltip
 2023-01-23 01:10:25 +09:00
Dean Herbert 9a89dfb7d1
Merge pull request #22339 from shinobu-uwu/fix-fail-sample-playing-after-leaving-dialog 
Fix skin fail sound continuing to play after leaving gameplay
 2023-01-22 22:27:26 +09:00
Bartłomiej Dach e1acf85bb3
Merge branch 'master' into groups-modes 2023-01-22 10:09:34 +01:00
Bartłomiej Dach 9bde1ef9bf
Privatise setter 2023-01-22 10:09:08 +01:00
Bartłomiej Dach b98da506c1
Fix code quality inspection 2023-01-22 10:07:47 +01:00
Bartłomiej Dach 31e7d7333b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog 2023-01-22 09:35:37 +01:00
Bartłomiej Dach 06aa3f7798
Rename `Stop{SampleAndRemoveFilters -> }()` 
Now that just one method for stopping samples is left, let's just
repurpose st as the general "stop global effects" method rather than
have it there with a hyperspecific name. It also has good symmetry, as
there already was a `Start()` method in the class.
 2023-01-22 09:29:22 +01:00
Bartłomiej Dach 9e4e85e3e3
Inline `StopSample()` into `StopSampleAndRemoveFilters()` 
The first method no longer has any callers except for the second one.
 2023-01-22 09:26:01 +01:00
Bartłomiej Dach 0edfd24410
Remove unnecessary sample stop in `Restart()` 
It is unnecessary, as a successful restart will exit the current player
screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
call, which means that in the restart flow the sample was actually
getting stopped twice.

Standard exit flow is fine, it only stopped the sample once.
 2023-01-22 09:24:12 +01:00
Bartłomiej Dach 88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds 
Fix comment editor text boxes not having sound feedback
 2023-01-22 09:10:20 +01:00
Bartłomiej Dach b66279c5d7
Merge pull request #22341 from peppy/screen-scaling-keywords 
Add search keywords for screen scaling sub-settings
 2023-01-22 08:56:14 +01:00
Matheus Filipe dos Santos Reinert db0b69db6b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog 2023-01-22 02:12:07 -03:00
Dean Herbert 27f1afdae1
Merge pull request #22330 from bdach/segmented-graph-bad-accesses 
Fix `SegmentedGraph` draw node calculating segment colours in unsafe manner
 2023-01-22 13:55:48 +09:00
Dean Herbert 7040743249 Add search keywords for screen scaling sub-settings 2023-01-22 13:47:31 +09:00
Matheus Filipe dos Santos Reinert 5b1a23c697 Replace RemoveFilters call with StopSampleAndRemoveFilters 2023-01-22 01:44:16 -03:00
Matheus Filipe dos Santos Reinert 2e1ba6ef49 Create StopSampleAndRemoveFilters method and change RemoveFilters to private 2023-01-22 01:43:40 -03:00
EXtremeExploit 2f3971b6fb
Move code to already existing if block 2023-01-22 01:40:00 -03:00
EXtremeExploit 8c208da324
Cleanup 2023-01-22 01:39:01 -03:00
EXtremeExploit 05f77d2cab
Add modes text to groups tooltip 2023-01-22 01:36:53 -03:00
Matheus Filipe dos Santos Reinert a746cbc6ed Fix failSample still playing after player left FailOverlay 2023-01-22 01:14:33 -03:00
Joseph Madamba da03abc812 Fix comment editor text boxes not having sound feedback 2023-01-21 17:32:42 -08:00
Bartłomiej Dach 718cbf9382
Fix `SegmentedGraph` draw node calculating segment colours in unsafe manner 
The `SegmentedGraph`'s draw node would call `getSegmentColour()`
on the drawable, which would query the `DrawColourInfo` and
`tierColours` properties of the drawable. This is a cross-thread access
and as such completely unsafe, as due to being cross-thread it can die
on invalidations or out-of-bounds accesses.

Fix by transferring everything to the draw node first before attempting
to draw. `SegmentedGraph.TierColours` setter already correctly
invalidates the draw node via `graphNeedsUpdate`, so no further
intervention was required there.

Closes #22326.
 2023-01-21 23:19:34 +01:00
Salman Ahmed 292fd345bc
Merge pull request #22302 from ekrctb/fix-infinity-spm 
Fix spinners potentially displaying incorrect SPM numbers
 2023-01-21 16:56:34 +03:00
Salman Ahmed ce64ba471a
Merge branch 'master' into fix-infinity-spm 2023-01-21 15:42:48 +03:00
Dean Herbert c2e1c91b58
Merge pull request #22315 from frenzibyte/fix-test-browser-broken 
Fix test browsers on longer working after framework update
 2023-01-21 21:34:08 +09:00
Salman Ahmed c48af79588 Fix test browsers on longer working after framework update 2023-01-21 14:49:47 +03:00
Dean Herbert 2a9b1ea9fc
Merge pull request #22310 from peppy/fix-threading-tournament-save 
Fix incorrect async continuation causing tournament client to not enable save button
 2023-01-21 15:31:56 +09:00
Dean Herbert 0fb12508f0 Fix incorrect async continuation causing tournament client to not enable save button 2023-01-21 11:28:56 +09:00
Dean Herbert 2075583313
Merge pull request #22303 from peppy/update-framework 
Update framework
 2023-01-21 00:30:59 +09:00
Dean Herbert 154c258248 Fix `TournamentGameBase` calling `AddInternal` 2023-01-20 23:53:30 +09:00