Commit Graph

568 Commits

Author SHA1 Message Date
ansel 8cbc0502ae Inline `CalculateEffect` 2022-09-12 15:51:18 +03:00
ansel 324a3723a5 Rewrite DMD 2022-09-10 23:23:04 +03:00
ansel 3f93ec8538 Expose counter to inheritors 2022-09-10 23:20:28 +03:00
ansel 667854b034 Make effect display have a built-in counter 2022-09-10 23:18:48 +03:00
ansel b056cac10a Remove generic and add default implementation for `CalculateEffect` 2022-09-10 08:34:29 +03:00
ansel 545e0bbcef Adjust inheritors and test 2022-08-29 22:49:25 +03:00
ansel 5343c26452 Control colour via `Current` bindable 2022-08-29 22:48:27 +03:00
ansel 7faeed88b0 Add ability to override width of value area 2022-08-29 22:08:43 +03:00
ansel 039f009562 Inherit difficulty multiplier display from `ModsEffectDiplay` 2022-08-27 20:26:05 +03:00
ansel 3e828c3416 Move base layout from DifficultyMultiplierDisplay to another class 2022-08-27 20:11:38 +03:00
Dan Balasescu 0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Dan Balasescu e1fa959f0b Fix language change removing mod column bold text 2022-08-22 13:00:47 +09:00
Bartłomiej Dach aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.

Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.

Fixes #19889.
2022-08-21 23:15:49 +02:00
Bartłomiej Dach 3d14b14cfe
Use alternative method for checking panel readiness to eliminate bool flag 2022-08-17 21:56:11 +02:00
Bartłomiej Dach 3109066e34
Rename `{Requires -> Pending}Configuration` 2022-08-16 22:45:24 +02:00
Bartłomiej Dach 6bfdfeb153
Refactor mod panel selection logic to avoid overwriting 2022-08-16 22:41:35 +02:00
Bartłomiej Dach 10daac6752
Only open mod customisation panel on explicit selection of single mod 2022-08-15 20:38:23 +02:00
Bartłomiej Dach f860bc11ee
Fix several schedule-related issues arising from new column addition 2022-08-15 20:38:16 +02:00
Bartłomiej Dach 5ff2e41a55
Add preset column to mod select test scene 2022-08-15 18:38:37 +02:00
Dan Balasescu 76fea25668
Merge pull request #19646 from its5Q/settings-localisation
Add missing localisation for settings enums
2022-08-10 18:51:52 +09:00
its5Q abca3d1b2a Prefix common strings for context 2022-08-10 00:35:19 +10:00
Bartłomiej Dach f74fb3491e
Use alternative implementation of preset panel cleanup 2022-08-08 21:08:54 +02:00
Bartłomiej Dach a0a6e1faee
Fix spurious sample playbacks from already-removed panels 2022-08-08 20:30:55 +02:00
Bartłomiej Dach f21a51aa24
Simplify mirror copy of task logic in `ModColumn` 2022-08-08 19:20:50 +02:00
Bartłomiej Dach 00333fb0d2
Change `?? false` test to `== true` for legibility 2022-08-08 19:19:13 +02:00
its5Q 5080d62e77 Add missing localisation for settings enums 2022-08-08 21:51:23 +10:00
Dean Herbert 070d156e89 Simplify task logic in `ModPresetColumn` 2022-08-08 16:13:52 +09:00
Bartłomiej Dach 839409d7ac
Add preset column to solo mod select overlay 2022-08-07 16:20:31 +02:00
Bartłomiej Dach b318bbd5e6
Allow non-homogenous column types in mod select overlay 2022-08-07 16:20:31 +02:00
Bartłomiej Dach 0287c49ca8
Implement user selection logic for mod presets 2022-08-07 16:20:20 +02:00
Bartłomiej Dach b1dcd7821c
Automatically toggle preset panels if selected mods match 2022-08-07 15:30:20 +02:00
Bartłomiej Dach 9b3183b2b4
Implement mod preset deletion flow 2022-08-06 21:58:55 +02:00
Bartłomiej Dach ca1b4689cb
Automatically focus name textbox upon add preset popover open 2022-08-03 21:26:35 +02:00
Bartłomiej Dach 159d3b032c
Rename locals for legibility 2022-08-03 21:23:31 +02:00
Bartłomiej Dach 82d3fbd51b
Split `AddPresetPopover` to separate file 2022-08-03 21:22:55 +02:00
Bartłomiej Dach add2971eb4
Implement preset creation flow with test coverage 2022-08-02 22:05:54 +02:00
Bartłomiej Dach 7251389e43
Add localisations for add preset button 2022-08-02 22:05:34 +02:00
Bartłomiej Dach 059a465fe8
Add border to popover for better visual contrast 2022-08-02 22:03:33 +02:00
Bartłomiej Dach 1b3074d098
Implement popover for creating mod presets 2022-08-02 22:03:33 +02:00
Bartłomiej Dach 085080576a
Add button for creating new mod presets 2022-08-02 22:03:32 +02:00
Bartłomiej Dach 85f77abee1
Fix code quality inspection about ambiguous equality 2022-07-31 23:53:46 +02:00
Bartłomiej Dach 345f103119
Migrate mod preset column to use realm 2022-07-31 23:53:45 +02:00
Bartłomiej Dach 446485f804
Move localisation string to common location 2022-07-24 23:30:52 +02:00
Bartłomiej Dach 8af9cfbe40
Add readonly modifier 2022-07-24 23:29:18 +02:00
Bartłomiej Dach 6a67d76d7c
Add basic mod preset column implementation 2022-07-24 16:39:04 +02:00
Bartłomiej Dach b2f8934117
Extract base mod select column presentation logic 2022-07-24 16:39:03 +02:00
Bartłomiej Dach f3ceabc53f
Rename `ModSelect{Overlay -> }Panel` 2022-07-22 19:17:22 +02:00
Bartłomiej Dach a3090003de
Add tooltip showing contents of mod preset 2022-07-21 23:29:21 +02:00
Bartłomiej Dach bdff7f1ef4
Implement basic appearance of mod preset panels 2022-07-21 23:29:21 +02:00
Bartłomiej Dach 6cd18fad99
Fix code inspections after base panel class extraction 2022-07-21 23:29:08 +02:00