RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
62,856 Commits 3 Branches 650 Tags 350 MiB
Commit Graph

33 Commits

Author SHA1 Message Date
Terochi e6f1ec57a9 Bring back and make use of `clearPreviousSamples()` 2023-03-23 18:46:48 +01:00
Terochi 1478a26cc0 Addressed changes 2023-03-21 23:15:49 +01:00
Dean Herbert 297e7d6542 Fix `Flush` call being run too late in `PoolableSkinnableSample` 2023-03-16 15:33:30 +09:00
Terochi edc6314634 Drank some coffee and figured out the fix 2023-03-15 10:49:59 +01:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert ab458320c4 Fix some lingering inspections 2022-11-09 17:46:24 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert 1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert 6017ef3825
Merge branch 'master' into fix-skin-sample-lookup 2021-06-08 17:37:36 +09:00
Dan Balasescu 67135ce3db
Add null check 2021-06-08 16:15:17 +09:00
Dean Herbert f3f634e969 Clean up previous sample immediately on skin source change to avoid `Play` after disposal 
This seems to be the simplest way to avoid calls to `Play` after the
underlying sample may have been disposed. As per the issue thread, a
local workaround is acceptable here.

Closes #13223.
 2021-06-08 15:05:18 +09:00
Dean Herbert 70a844ac10 Remove `allowFallback` parameters completely 2021-05-27 14:50:42 +09:00
Dean Herbert 68aaf90702 Fix disposal rather than performing some weird hack 2021-03-19 20:30:52 +09:00
Dean Herbert b2d8db3a92 Rename incorrect variable 2021-03-19 20:25:21 +09:00
Dean Herbert bf4317d3f0 Ensure looping is disabled on old samples when switching skins 2021-03-19 15:34:21 +09:00
Dean Herbert fde026d443 Remove redundant interface specification 2021-02-22 14:54:48 +09:00
Dean Herbert 63dd55c92c Add missing methods from updated audio component interface implementation 2021-02-22 14:18:52 +09:00
Dean Herbert 143e145670 Update implementation of AdjustableAudioComponents 2021-02-18 15:44:23 +09:00
smoogipoo 9b5995f2f1 Update with removal of looping parameter 2021-02-12 19:05:17 +09:00
smoogipoo 0c3aef8645 Fix potential race in looping sample 
As mentioned via GitHub comments. Very unlikely for this to happen unless: the sample takes a short amount of time to load, is very short itself, and the update thread stalls until the sample fully completes.
 2021-02-12 17:42:35 +09:00
smoogipoo 8ffbcc9860 Fix test failures and general discrepancies 2021-01-20 14:05:35 +09:00
smoogipoo 58269f9314 Update with framework changes 2021-01-20 13:35:43 +09:00
smoogipoo de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
Dean Herbert ced7a36788 Update namespaces 2021-01-18 21:24:10 +09:00
Bartłomiej Dach f6d15b9757 Invert back-to-front logic 2020-12-06 18:59:38 +01:00
Bartłomiej Dach fcd9483ffa
Merge branch 'master' into fix-multiple-playback-on-skin-change 2020-12-06 18:21:24 +01:00
smoogipoo f5e8d1d14d Lose old reference immediately on updateSample() 2020-11-30 19:19:24 +09:00
smoogipoo afb8eb636d Apply simple PR reviews 2020-11-30 18:40:22 +09:00
Dean Herbert a3b1d14f17 Apply similar fix to PoolableSkinnableSound 2020-11-22 14:44:39 +09:00
smoogipoo 7c83a27002 Add more xmldocs 2020-11-19 22:48:21 +09:00
smoogipoo d388c44428 Cleanup, refactoring, and restart sample on skin change 2020-11-19 22:30:21 +09:00
smoogipoo 0287269b2f Fix volume discrepancies 2020-11-19 21:21:30 +09:00
smoogipoo 003fed857c Separate files 2020-11-19 19:52:34 +09:00