Commit Graph

12 Commits

Author SHA1 Message Date
Dean Herbert a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
Dean Herbert ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert 7460018cd3 Move combo colours to GlobalSkinColours 2020-02-07 14:58:07 +09:00
smoogipoo 91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
Bartłomiej Dach 49c252ec78 Mark storyboard sample retrieval test headless 2020-01-06 07:33:59 +01:00
smoogipoo 878e9f182e Add storyboard sample test scene 2020-01-02 15:23:41 +09:00
smoogipoo 7507fee9f9 Add test for HP rewind 2019-12-27 16:55:46 +09:00
smoogipoo 7ee0370d23 Add some tests 2019-12-26 17:48:46 +09:00
Salman Ahmed 55be4478aa Merge remote-tracking branch 'upstream/master' into fallback-to-skin-combo-colours 2019-12-21 12:36:09 +03:00
smoogipoo 5664ce3109 Add hitobject container regression test 2019-12-18 18:51:12 +09:00
iiSaLMaN 517f547590 Fix failing test 2019-11-07 19:12:18 +03:00
smoogipoo 89f50b26f7 Fix hitobject combo colour potentially not getting adjusted 2019-10-18 17:32:11 +09:00