Commit Graph

11 Commits

Author SHA1 Message Date
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert c0abce918f Add `enum` to snap method as alternative to mutliple nested invocations 2022-05-12 16:19:07 +09:00
Dean Herbert f6fc926f1a Add xmldoc and rename methods in `IPositionSnapProvider` for legibility 2022-05-05 15:58:21 +09:00
Salman Ahmed 59cf3ff50f Move distancing methods from `IPositionSnapProvider` to `IDistanceSnapProvider` 2022-04-28 05:48:45 +03:00
Salman Ahmed 70a93c0e7e Move `DistanceSpacingMultiplier` bindable to its own `IDistanceSnapProvider` interface 2022-04-24 08:33:00 +03:00
Salman Ahmed 0992bec2c8 Change "distance spacing" multipler type to `double`
Avoids losing precision on initial load, causing an unnecessary
hash change in `EditorChangeHandler`.

Resolves test failures in `TestSceneEditorChangeStates`
(https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).
2022-02-16 03:28:12 +03:00
Salman Ahmed 528dc03b8c Expose distance spacing in `IPositionSnapProvider` for updating distance grid
Alternate method is to expose a `SnapDistancesChanged` event in
`IPositionSnapProvider` instead, but I chose this way as an analogue to
`IBeatSnapProvider.BeatDivisor`, which might even make sense to be
exposed as `BindableBeatDivisor` instead of caching that separately.
2022-02-15 02:21:53 +03:00
Dean Herbert b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00
Dean Herbert d4e5a612ea Update `IPositionalSnapProvider` to take a `HitObject` as reference, rather than raw time
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
2021-09-03 17:11:12 +09:00
Dean Herbert c9a41f9dae Make all objects in selection candidates for spatial snapping
Closes #10898.
2020-11-24 17:35:54 +09:00
Dean Herbert c41fb67e73 Move all ruleset editor tests to their own namespace 2020-09-25 18:51:26 +09:00