Commit Graph

29 Commits

Author SHA1 Message Date
Bartłomiej Dach 3d52a1267e
Fix test failures via test-local popover containers 2023-08-19 15:08:30 +02:00
Bartłomiej Dach 9bcd86d66d
Fix test failure due to relying on implementation detail 2023-06-19 18:42:30 +02:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert cab9a1c012 Add test coverage of distance snap grid failing visually 2022-10-26 13:10:54 +09:00
Dean Herbert 5f10b81af1 Move distance snap grid test cursor behind grid to better visualise centre-points 2022-10-26 13:10:54 +09:00
Dean Herbert 6608ada925 Fix test failures due to missing colour provider dependency 2022-10-13 17:05:11 +09:00
Dean Herbert 4b72e55770 Fix various test scenes not adding `EditorClock` to the draw hierarchy 2022-08-26 18:08:43 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert fda61943b0 Update distance snap test when cursor at centre of grid to be in line with expectations 2022-05-12 13:11:55 +09:00
Salman Ahmed b119726b28 Reword test step 2022-05-06 15:38:38 +03:00
Dean Herbert daed42513e Fix outdated test asserts 2022-05-06 18:44:25 +09:00
Dean Herbert 9fd98b8060 Also add test coverage of adjsuting the distance spacing multiplier 2022-05-05 18:49:12 +09:00
Dean Herbert 4fe23bced2 Update tests with new assumptions and a better snap implementation 2022-05-05 18:49:12 +09:00
Salman Ahmed 269e15c167 Add test coverage of distance spacing multiplier working with distance snap grid 2022-05-05 18:49:12 +09:00
Dean Herbert de9b3d33eb Rename misleading `DistanceSpacing` variable 2022-05-05 17:08:09 +09:00
Dean Herbert 19cf9dc20b Merge branch 'snapping-tidy-distance' 2022-05-05 16:51:32 +09:00
Dean Herbert 977e6d8a80 Add xmldoc for `IDistanceSnapProvider` and related properties 2022-05-05 16:25:45 +09:00
Dean Herbert f6fc926f1a Add xmldoc and rename methods in `IPositionSnapProvider` for legibility 2022-05-05 15:58:21 +09:00
Salman Ahmed fef94d49f4 Revert "Convert data type of `DistanceSpacing` to float"
This reverts commit 7aaa88cac2.
2022-04-29 08:02:07 +03:00
Salman Ahmed 7aaa88cac2 Convert data type of `DistanceSpacing` to float 2022-04-28 10:24:36 +03:00
Salman Ahmed 70a93c0e7e Move `DistanceSpacingMultiplier` bindable to its own `IDistanceSnapProvider` interface 2022-04-24 08:33:00 +03:00
Salman Ahmed 0992bec2c8 Change "distance spacing" multipler type to `double`
Avoids losing precision on initial load, causing an unnecessary
hash change in `EditorChangeHandler`.

Resolves test failures in `TestSceneEditorChangeStates`
(https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).
2022-02-16 03:28:12 +03:00
Salman Ahmed 528dc03b8c Expose distance spacing in `IPositionSnapProvider` for updating distance grid
Alternate method is to expose a `SnapDistancesChanged` event in
`IPositionSnapProvider` instead, but I chose this way as an analogue to
`IBeatSnapProvider.BeatDivisor`, which might even make sense to be
exposed as `BindableBeatDivisor` instead of caching that separately.
2022-02-15 02:21:53 +03:00
Dean Herbert b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00
smoogipoo bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
Dean Herbert b339c149d8 Copy `BaseDifficulty` to `Beatmap<T>` and move all write operations across 2021-10-06 15:10:45 +09:00
Dean Herbert d4e5a612ea Update `IPositionalSnapProvider` to take a `HitObject` as reference, rather than raw time
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
2021-09-03 17:11:12 +09:00
Dean Herbert c9a41f9dae Make all objects in selection candidates for spatial snapping
Closes #10898.
2020-11-24 17:35:54 +09:00
Dean Herbert c41fb67e73 Move all ruleset editor tests to their own namespace 2020-09-25 18:51:26 +09:00