RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
56,060 Commits 3 Branches 659 Tags 366 MiB
Commit Graph

13 Commits

Author SHA1 Message Date
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Naxess 3a5912e35e Add new checks to verifiers 2021-07-13 10:53:25 +02:00
Naxess 2f3f4f3e4b Add new checks to verifier 2021-06-21 15:30:45 +02:00
Naxess 19800f5f7f Move `IBeatmap` arg into context 2021-05-13 11:24:22 +02:00
Naxess b7bc42e0d3 Rename "playableBeatmap" check arg to "beatmap" 
The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.
 2021-05-12 02:34:16 +02:00
Naxess c13b93e6f1 Replace `IWorkingBeatmap` arg with `BeatmapVerifierContext` in checks 
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
 2021-05-12 02:29:18 +02:00
Naxess 8656176ab8 Add the playable beatmap as check argument 
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
 2021-04-20 01:31:51 +02:00
Naxess 448574e7e6 Use `WorkingBeatmap` instead of `IBeatmap` 
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.

Also improves the structure of the `CheckBackgroundTest` class in the process.
 2021-04-17 17:33:53 +02:00
Dean Herbert 03ba04e8ce Split out general checks into its own verifier class (and remove `static` usage) 2021-04-13 19:50:22 +09:00
Naxess 304fe5cd34 Add `CheckBackground` to `OsuBeatmapVerifier` 2021-04-13 10:41:02 +02:00
Naxess 60c2494b31 Make `BeatmapVerifier` an interface 2021-04-13 10:40:56 +02:00
Naxess 65ebdd8f7a Move check origin from `IssueTemplate` to `Issue` 
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
 2021-04-12 10:08:08 +02:00
Dean Herbert 1c553b5d48 Checker -> BeatmapVerifier 2021-04-12 15:29:05 +09:00