RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,954 Commits 3 Branches 651 Tags 355 MiB
Commit Graph

499 Commits

Author SHA1 Message Date
Bartłomiej Dach 07cbc3e683 Privatise and seal whatever possible 2020-06-21 23:05:10 +02:00
Bartłomiej Dach 4bba0c7359 Move abstract sample test to main game project 2020-06-21 22:28:19 +02:00
Salman Ahmed eb64c4752c
Merge remote-tracking branch 'upstream/master' into cache-ruleset-dependencies-for-tests 2020-06-15 11:31:12 +03:00
Salman Ahmed 60381d5817
Remove IRulesetTestScene and use OsuTestScene.CreateRuleset() instead 2020-06-15 11:30:48 +03:00
Dean Herbert 0b6e8783d4
Merge branch 'master' into test-scene-create-ruleset 2020-06-12 17:06:27 +09:00
Salman Ahmed 4fb71eeb20
Move setting up the ruleset bindable to top-base test scene 2020-06-10 18:23:31 +03:00
Salman Ahmed efd5e14410
Clarify why ruleset bindable must be set at the BDL of any base test scene 2020-06-06 19:20:06 +03:00
Salman Ahmed 0f78af7252
Remove unnecessary disabled check 
I have a bad memory here, til.
 2020-06-06 19:19:30 +03:00
smoogipoo caf94df0d0 Merge branch 'master' into multiplayer-beatmap-checksum 2020-06-05 19:16:05 +09:00
Salman Ahmed 741fa20149
Use CreateRuleset() for editor test scenes as well 2020-06-04 00:47:10 +03:00
Salman Ahmed c72592c52c
Remove bindable-disabling logic and don't tie immediately to CreateRuleset() 2020-06-04 00:44:28 +03:00
Salman Ahmed bbad70c3f0
Fix mod perfect test scenes failing due to null ruleset provided 
Just a workaround for now, a better fix may be to put the test data creation in an action that is guaranteed to be invoked after the test scene has fully loaded (all dependencies would've been resolved by then).
 2020-06-04 00:43:11 +03:00
Salman Ahmed 136e10086a
Set the ruleset bindable value at the BDL for its subclasses usages 
There are test scenes using current value of ruleset bindable on their BDL (example in TestSceneSliderSnaking's BDL)
 2020-06-04 00:37:06 +03:00
Salman Ahmed 11da045d8c
Reorder declaration position of ruleset-creation methods 
Should be recognized as a normal protected method in its declaring class.
 2020-06-03 23:43:18 +03:00
Salman Ahmed 84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset 
# Conflicts:
#	osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
#	osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
#	osu.Game/Tests/Visual/ModTestScene.cs
#	osu.Game/Tests/Visual/OsuTestScene.cs
 2020-06-03 22:00:02 +03:00
smoogipoo 3c85561cdc Add tests 2020-06-02 14:31:43 +09:00
Salman Ahmed 2c6887e610
Remove unnecessary use of and remove StartupStorage 2020-05-31 19:49:03 +03:00
Salman Ahmed 82fe99cf4a
Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory 
Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).
 2020-05-31 02:24:49 +03:00
smoogipoo 51e74687f8 Merge branch 'editor-scrolling-playfield-support' of https://github.com/peppy/osu; branch 'results-screen-condensed-panel' of https://github.com/smoogipoo/osu into results-screen-condensed-panel 2020-05-26 15:39:39 +09:00
smoogipoo d5ea076427 Merge branch 'master' into results-screen-condensed-panel 2020-05-22 20:45:39 +09:00
Dean Herbert 866db629d6 Fix remaining test failures 2020-05-22 18:23:24 +09:00
Dean Herbert dd09d7830d Cache and resolve editor clock as EditorClock in all cases 2020-05-22 16:44:06 +09:00
smoogipoo 45b59f574d Fix TestSceneResultsScreen crashing 2020-05-21 18:43:12 +09:00
smoogipoo 9f868be872 Create common TestScoreInfo type 2020-05-21 18:39:22 +09:00
Dean Herbert bac78707de Move more logic to column to both clean things up and fix tests 2020-05-21 14:25:37 +09:00
Dean Herbert 82d6549161 Pass down snap result and remove local TimeAt usage 2020-05-20 21:01:29 +09:00
Dean Herbert 9638064741 Tidy up ruleset assignment code 2020-05-20 10:06:23 +09:00
Dean Herbert db4e3047dd Add test for final sample output 2020-05-19 23:28:13 +09:00
Dean Herbert be3a0a3c1d Merge branch 'master' into remove-requiredtypes 2020-05-16 18:28:14 +09:00
smoogipoo 648999a2de Remove all RequiredTypes usages 2020-05-16 18:17:12 +09:00
Dean Herbert 44319c1b71 Commit missed change 2020-05-12 20:26:34 +09:00
Dean Herbert de50b725d5 Fix mod failure checks executing actual game logic 2020-05-12 20:08:35 +09:00
Dean Herbert d0a8c0fa71 Add kiai support to osu!taiko skinned playfields 2020-04-30 16:43:00 +09:00
smoogipoo 7d54d4b800 Improve test scene 2020-04-28 18:36:10 +09:00
Dean Herbert fe0038ed14
Merge branch 'master' into fix-mania-placement 2020-04-24 17:00:12 +09:00
Salman Ahmed 227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset 2020-04-23 16:25:33 +03:00
Salman Ahmed 2fa47992dc
Seal the ruleset creation methods and let abstract method take their place 
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
 2020-04-23 13:27:12 +03:00
Salman Ahmed 0a0ea39431
Mark the top ruleset creation method as can-be-null 2020-04-23 13:24:30 +03:00
smoogipoo 6df45164fa Expose direction from scrolling test container 2020-04-23 11:17:16 +09:00
smoogipoo 40f11ed15c Resolve broken test scene 2020-04-23 10:37:05 +09:00
smoogipoo 08982e0e00 Ensure editor tests wait for load to complete 2020-04-22 19:49:21 +09:00
smoogipoo 0a34fddcc3 Fix TestBeatmap not setting appropriate ruleset ID 2020-04-22 19:38:27 +09:00
Dean Herbert af32f51116
Merge pull request #8800 from iiSaLMaN/allow-cancelling-completion 
Fix results screen pushed after rewinding in-between push delay
 2020-04-21 12:49:49 +09:00
Salman Ahmed fc6c245de5 Replace all judged event logic with HasCompleted bindable 2020-04-19 05:36:04 +03:00
Dean Herbert d4788e39bb Merge branch 'master' into taiko-drumroll-skinning 2020-04-17 19:30:18 +09:00
Salman Ahmed 7f791dcdf0 Re-enable ruleset bindable before setting defined ruleset in case it's disabled 
Happens on cases like restarting the test scene by clicking directly on it on the browser (*where it for some reason reloads the entire test scene*)
 2020-04-17 11:18:05 +03:00
Salman Ahmed 155bc8b49a Remove `ModTestScene` ruleset parameter on constructor and use `CreateRuleset` instead 2020-04-17 11:17:59 +03:00
Salman Ahmed 92df4e3a9e Remove `PlayerTestScene` constructor and use `CreateRuleset` method instead 2020-04-17 11:17:51 +03:00
Salman Ahmed 5fa6bcb5a3 Move `SkinnableTestScene` into using the global `CreateRuleset` method 2020-04-17 11:17:44 +03:00
Salman Ahmed 67bd7bfa39 Add `CreateRuleset` in OsuTestScene for scenes that depend on it 2020-04-17 11:12:25 +03:00