Commit Graph

54245 Commits

Author SHA1 Message Date
andy840119
8d175bc402 Remove the null check. 2022-08-02 23:14:08 +08:00
andy840119
c8c2758d63 give the object a default value(null). 2022-08-02 23:02:14 +08:00
andy840119
13b2441c51 give the field a default value. 2022-08-02 22:29:54 +08:00
andy840119
11a4bb5833 Prevent return the null value. 2022-08-02 22:29:54 +08:00
andy840119
78cc28d75f Remove nullable disable annotation and fix the api broken. 2022-08-02 22:29:54 +08:00
Dan Balasescu
5a1c05918f Fix test failures 2022-08-02 20:18:45 +09:00
Dan Balasescu
b4e55f7309 Apply IRenderer changes 2022-08-02 19:50:57 +09:00
Dan Balasescu
dc49862466 Merge branch 'irenderer-shaders' into irenderer-textures 2022-08-02 19:25:24 +09:00
Dan Balasescu
a2a913ab52 Merge branch 'irenderer-batches' into irenderer-textures 2022-08-02 19:25:08 +09:00
Dean Herbert
258ad7c6b9 Tidy up kiai time access 2022-08-02 18:18:40 +09:00
Dean Herbert
cc4cde2c79 Improve IBeatSyncProvider interface and reduce beatmap track dependence 2022-08-02 17:59:18 +09:00
Dean Herbert
7022c6382d Add localisation support for local modification strings 2022-08-02 16:30:14 +09:00
Dean Herbert
8cb02f47eb Mark BeatmapSet.Status as modified when any beatmap is modified, rather than all 2022-08-02 16:08:58 +09:00
Dean Herbert
df76f9f4da Fix some additional metadata being updated when it shouldn't (with local changes) 2022-08-02 15:49:22 +09:00
Dean Herbert
227906e30e
Merge pull request #19543 from peppy/dont-clear-chat-overlay
Avoid clearing chat overlay textbox when pressing "back" key binding
2022-08-02 14:34:17 +09:00
Dean Herbert
34ffc51c51 Avoid clearing chat overlay textbox when pressing "back" key binding
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.

Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.
2022-08-02 13:56:03 +09:00
Dan Balasescu
fc0914bf77
Merge pull request #19536 from frenzibyte/playlists-settings-leak
Fix playlist settings reference leak due to unsafe binding
2022-08-02 13:30:55 +09:00
Dan Balasescu
4295dc3cb9
Merge pull request #19535 from naipofo/overlay-filter-rank
Hide F rank from the beatmap overlay
2022-08-02 13:06:27 +09:00
Dean Herbert
4adc8375e9 Add more xmldoc and avoid BeatmapSet status being set when it shouldn't be 2022-08-02 12:12:02 +09:00
Dan Balasescu
9a468f85f7
Merge pull request #19534 from andy840119/fix-up-remaining-issue-in-the-mods
Update nullability specifications in osu!catch and osu!taiko mods
2022-08-02 12:09:44 +09:00
Dean Herbert
5501195ed7
Merge pull request #19538 from bdach/mod-overlay/sheared-button-broken-autosize
Fix broken sheared button autosizing logic
2022-08-02 11:51:14 +09:00
andy840119
eb73f9e88c Remove un-need using. 2022-08-02 10:23:52 +08:00
Bartłomiej Dach
298efa5391
Fix broken ShearedButton autosizing logic 2022-08-01 22:04:16 +02:00
Bartłomiej Dach
923d9a4e5f
Add failing assertions to demonstrate autosize failure 2022-08-01 22:04:14 +02:00
NaiPofo
3356909026
Merge branch 'master' into overlay-filter-rank 2022-08-01 21:54:44 +02:00
Salman Ahmed
7354f9e6ba Remove localisation for now 2022-08-01 22:05:52 +03:00
Dean Herbert
c0e5f11c90
Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-02 02:20:51 +09:00
Salman Ahmed
7e9d11ee24 Enable NRT on playlists settings overlay 2022-08-01 20:15:08 +03:00
Salman Ahmed
c851e3d8f3 Fix playlist settings reference leak due to unsafe callback binding 2022-08-01 20:08:18 +03:00
notmyname
6686b09549 Hide F rank from beatmap overlay 2022-08-01 18:54:00 +02:00
andy840119
b1d320bf67 Use non-nullable instead in the taiko ruleset. 2022-08-02 00:48:23 +08:00
andy840119
1fe7e4d19a Use non-nullable instead in the catch ruleset. 2022-08-02 00:45:47 +08:00
Salman Ahmed
fc7fc3d673 Fix newly imported beatmaps not using correct comparer for sorting 2022-08-01 19:13:57 +03:00
Dean Herbert
0fcae08d38 Show "locally modified" pill when local modifications have been made 2022-08-02 00:52:38 +09:00
Dean Herbert
01cc9bd7ef
Merge pull request #19479 from frenzibyte/carousel-update-on-resume
Fix song select not updating selected beatmap card on editor resume
2022-08-02 00:48:18 +09:00
Salman Ahmed
682192dbd7 Add failing test case 2022-08-01 18:43:01 +03:00
Dean Herbert
c53a4f1c45
Merge pull request #16589 from mk56-spn/Wiggle-strength-duration
Add strength setting for wiggle mod
2022-08-02 00:03:53 +09:00
Dean Herbert
a5fac70c3b Rename variable to not include mode name itself 2022-08-01 23:30:00 +09:00
Dean Herbert
d09976bb39 Merge branch 'master' into Wiggle-strength-duration 2022-08-01 23:29:03 +09:00
Salman Ahmed
49ee78babb
Merge pull request #19500 from andy840119/remove-nullable-disable-in-the-audio-namespace
Remove nullable disable annotation in audio namespace
2022-08-01 15:59:19 +03:00
Salman Ahmed
7c9f8648a5
Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace 2022-08-01 15:25:12 +03:00
Dean Herbert
8ef777405d
Merge pull request #19262 from goodtrailer/stable-slider-tick-anims
Imitate stable's slider followcircle tick-based behavior
2022-08-01 21:11:33 +09:00
Salman Ahmed
03eccc2f7e
Merge branch 'master' into stable-slider-tick-anims 2022-08-01 15:01:09 +03:00
andy840119
6cccb6b848 Remove canBeNull: true. 2022-08-01 19:45:15 +08:00
Salman Ahmed
3ff0327d91 Display readable message when reaching download limit 2022-08-01 14:22:54 +03:00
Salman Ahmed
2465e8ed68
Merge pull request #19508 from gutyina70/fix-tags-overflow
Prevent tags overflowing on beatmap info overlay
2022-08-01 13:16:04 +03:00
Salman Ahmed
2a127c6ef8
Merge branch 'master' into fix-tags-overflow 2022-08-01 12:40:43 +03:00
Dan Balasescu
d4eec9122f
Merge pull request #19516 from peppy/fix-editor-track-disposal-crash
Fix editor potentially playing a track post-disposal
2022-08-01 18:12:21 +09:00
Dean Herbert
e0940c6c22 Update animations to final versions 2022-08-01 18:03:32 +09:00
Dean Herbert
0b8d3cbce9 Merge branch 'master' into stable-slider-tick-anims 2022-08-01 18:03:22 +09:00