Commit Graph

33 Commits

Author SHA1 Message Date
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert f6a3709060 Store default skins to database 2021-11-29 18:28:25 +09:00
ekrctb a960a28d06 Replace "end glow" terminology with "hyper-dash after-image"
Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
The "after-image" was already used in the code as a synonym of "end glow" inconsistently.
2021-07-28 19:11:22 +09:00
ekrctb 0bf04ece34 Avoid `internal` property by using `ChildrenOfType` 2021-07-28 18:13:43 +09:00
ekrctb da69867fd4 Move catcher trail generation logic to `CatcherArea` 2021-07-27 19:07:37 +09:00
ekrctb bb046fa3b8 Move catcher trail generation logic to `Catcher`
It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
Trail generation logic is moved to `Catcher`.
The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
Instead, the last time a trail is generated is calculated and used.
The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.
2021-07-26 17:51:59 +09:00
ekrctb b88ee3c1a1 Pass `DroppedObjectContainer` via constructor instead of DI
It is now just one level deep, so it is not beneficial to use DI here.
This effectively reverts ae09c23e.
2021-07-19 20:11:49 +09:00
ekrctb 97059a9f50 Create `Catcher` in `CatchPlayfield` 2021-07-19 19:44:40 +09:00
PercyDan54 e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
ekrctb ae09c23e4e Resolve `DroppedObjectContainer` via DI 2021-06-24 16:09:13 +09:00
ekrctb 16d5893535 Add `DroppedObjectContainer` class 2021-06-24 15:51:54 +09:00
ekrctb ccca7e0b25 more specific type droppedObjectContainer 2020-12-09 10:35:01 +09:00
ekrctb d18397acad Adjust namespace 2020-12-07 12:35:24 +09:00
ekrctb e82ca66d3e Fix depth of dropped objects 2020-12-04 10:21:54 +09:00
Dean Herbert a50ca0a1ed Fix osu!catch test failures due to trying to retrieve container too early 2020-10-19 20:00:17 +09:00
Bartłomiej Dach ed83ac188e Remove special case for moving catcher sprite 2020-05-06 23:25:25 +02:00
Salman Ahmed bffe6742e0
Replace finishing catcher transforms with until-true step 2020-04-22 10:43:49 +03:00
Salman Ahmed 730b5ea1a9
Make the Catcher.Colour assertion read better 2020-04-22 10:40:21 +03:00
Salman Ahmed 5d3475a5ed
Retrieve CatcherTrailDisplay for asserting colours set correctly 2020-04-22 05:12:51 +03:00
Salman Ahmed e17a44c99b Merge branch 'master' of github.com:ppy/osu into catch-hyperdash-catcher-colouring 2020-04-21 05:58:56 +03:00
Bartłomiej Dach e3e0cd149f Refactor test code to eliminate boolean flags 2020-04-19 12:46:28 +02:00
Salman Ahmed d27d8671ab Convert all static getter-only properties to static readonly fields 2020-04-08 14:23:29 +03:00
Salman Ahmed b100230538 Test CatchSkinColour transformation on colour retrieval implicitly 2020-04-05 00:13:23 +03:00
Salman Ahmed c4f7b45768 Revert "Add support for custom hyper-dash fruit colouring"
This reverts commit 6f2cc5471a and also its testing cases.

This became dead code after actual correct osu!catch skin colouring, we don't support modern skinning (non-legacy skinning) at the moment, so for what it's worth this can be reverted to default red-coloured
2020-04-05 00:07:25 +03:00
Salman Ahmed ee247e58c8 Merge branch 'catch-hyperdash-fruit-colouring' into catch-hyperdash-catcher-colouring 2020-04-04 18:07:29 +03:00
Salman Ahmed dd684b68d9 Make parameters required 2020-04-03 19:53:38 +03:00
Salman Ahmed 0340b6db51 Describe step names more 2020-04-03 19:50:32 +03:00
Salman Ahmed 16a4525a9c CatchSkinConfiguration -> CatchSkinColour 2020-03-30 09:33:47 +03:00
Salman Ahmed e51097da9e Add a legacy skin provider above the test skin 2020-03-30 09:29:00 +03:00
Salman Ahmed 45eb03bfe2 Apply review suggestions 2020-03-28 07:43:47 +03:00
Salman Ahmed 77b3011394 Add hyper-dash catcher & trails colouring test cases 2020-03-26 09:19:00 +03:00
Salman Ahmed 29274b004c Add hyper-dash fruit colouring test cases 2020-03-26 05:42:13 +03:00
Salman Ahmed aa162b1033 Setup hyper-dash colouring test scene 2020-03-26 05:42:11 +03:00