RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
65,991 Commits 3 Branches 659 Tags 364 MiB
Commit Graph

27 Commits

Author SHA1 Message Date
Dean Herbert fa47309eef
Fix exit key during storyboard outro not progressing to results 2023-10-12 19:31:54 +09:00
Dean Herbert 73b8146729
Update tests in line with new behaviour 2023-10-12 15:42:54 +09:00
Dean Herbert 9b45591c2f Add failing test coverage of saving failed replay causing progression to results 2023-03-29 14:00:11 +09:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Salman Ahmed b6701dd578 Add failing test case 2022-10-02 15:29:53 +03:00
Dean Herbert 6d78218142 Update usages of `GameplayClockContainer.GameplayClock` to access properties directly 2022-08-15 18:08:49 +09:00
Dean Herbert 35745c83b7 Replace dodgy `SetUpSteps` overriding with usage of `HasCustomSteps` 2022-06-28 15:19:02 +09:00
Dean Herbert 401d9c1bae Fix `TestStoryboardSkipOutro` occasionally failing due to strict timings 2022-06-27 17:13:46 +09:00
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dan Balasescu 781cb9f18d Move HasPassed/HasFailed into GameplayState 2022-02-01 14:46:24 +09:00
Dean Herbert 04d8fd3a58 Improve reliability of `TestStoryboardSkipOutro` 
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.

Have run quite a lot locally with no failures (while removing the skip step 100% fails).
 2022-01-01 15:32:39 +09:00
Dean Herbert 26a1e40d24 Fix storyboard outro during fail test not being lenient enough 2021-10-13 13:48:57 +09:00
Dean Herbert 246ab41cc6 Remove special casing for user exit during storyboard outro 2021-06-17 18:11:15 +09:00
Dean Herbert bcf1e3db1e Fix test failures in `TestSceneStoryboardWithOutro` 
Test was not accounting for the fact that the results may not have
loaded in time.
 2021-05-27 19:45:55 +09:00
Christine Chen ae2b5a0806 Actually test that player was exited 2021-05-08 22:42:14 -04:00
Christine Chen 25312b3e88 Don't restart completion delegate on exit, revert exit behavior to lazer 2021-05-08 11:47:44 -04:00
Christine Chen 8c564a69ed Fix InvalidOperationException when exiting a map at the end 2021-05-07 21:11:03 -04:00
Dean Herbert 3cc9bad979 Actually check for correct state of fade content in rewind test 2021-05-05 17:49:33 +09:00
Christine Chen 1d4a8bc0ae Add visual test for rewinding 2021-05-04 22:23:36 -04:00
Christine Chen fd1241cc85 Added tests 
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion

Co-Authored-By: Marlina José <marlina@umich.edu>
 2021-04-18 23:26:50 -04:00
Christine Chen 98460c8feb Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field 2021-04-18 20:20:14 -04:00
Christine Chen 7b1d40db7d Remove redundant string interpolation 2021-04-17 22:13:28 -04:00
Christine Chen e9f8fa64b8 Added a test for toggling the storyboard after the map is loaded 2021-04-17 21:49:29 -04:00
Christine Chen 7f5b1e84a1 Update TestSceneStoryboardWithOutro.cs 
- Construct storyboard in CreateWorkingBeatmap()
- Use GameplayClockContainer.GameplayClock.CurrentTime
- Remove unnecessary lines
 2021-04-17 13:57:32 -04:00
Christine Chen b15838b220 Move storyboard outro logic to DrawableStoryboard 2021-04-16 00:59:10 -04:00
Christine Chen 25b8c2f257 Allow skipping storyboard outro 
Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed

The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.

Co-Authored-By: Marlina José <marlina@umich.edu>
 2021-04-15 13:20:40 -04:00