Commit Graph

228 Commits

Author SHA1 Message Date
Dean Herbert f500abd4f7 Make "Hold Off" and "No Release" mod incompatible 2024-07-19 14:08:39 +03:00
Nathan Du 1eb10e029c Rewrite no release mod
Per the request of spaceman_atlas, the No Release mod is rewritten to
avoid modifications to DrawableHoldNoteTail. The approach is based
on that of the Strict Tracking mod for the osu!(standard) ruleset,
injecting the mod behavior by replacing the normal hold note with
the mod's variant. The variant inherits most bevaior from the normal
hold note, but when creating nested hitobjects, it creates its own
hold note tail variant instead, which in turn is used to instantiate
the mod's variant of DrawableHoldNoteTail with a new behavior.

The time a judgement is awarded is changed from the end of its
Perfect window to the time of the tail itself.
2024-07-01 20:29:30 +08:00
Nathan Du 960d552dc1 Initial implemention of the No Release mod
This commit adds a new osu!mania mod No Release that relaxes tail
judgements. The current implementation automatically awards Perfect
(or Meh if the hold note is broken midway) for a hold note tail at
the end of its Perfect window, as long as it is held by then.

Tests are pending for the next commit.
2024-06-28 22:21:08 +08:00
Dan Balasescu ca92a31cf9
Fix missing event unbinds 2024-03-07 21:10:11 +09:00
Dan Balasescu 878fb2d10d
Add break support 2024-02-15 22:05:25 +09:00
Dan Balasescu d1a51b474c
Adjust tests 2024-02-15 21:25:40 +09:00
Dan Balasescu 755bc7c050
Fix resolution scaling 2024-02-15 20:07:55 +09:00
Dan Balasescu 8f995a30af
Fix legacy coverage metrics 2024-02-08 00:20:32 +09:00
Dan Balasescu af20eacc82
Fix coordinate space 2024-02-07 00:25:22 +09:00
Dan Balasescu 69db1b2778
Add ManiaModCover to take over old roles of the mods 2024-02-07 00:15:14 +09:00
Dan Balasescu 5bc7befbd4
Add progressive cover to mania HD and FI mods 2024-02-06 23:47:20 +09:00
Dan Balasescu 5265d33c12
Make coverage into a bindable 2024-02-06 23:33:00 +09:00
Bartłomiej Dach f89923aeae
Annotate mods that give pp 2024-01-31 14:59:35 +01:00
Dan Balasescu 93efa98d9b
Fix mania "Great" hits failing with perfect mod 2023-12-22 16:19:36 +09:00
Dan Balasescu bff08d124b
Remove mania mod multiplier for DT/NC 2023-12-20 22:28:50 +09:00
Dean Herbert 5341a335a6
Bypass `Parent` nullability checks for now 2023-10-17 17:48:45 +09:00
Dean Herbert c5397bdbb3
Merge branch 'master' into mania-edit-disable-sv 2023-09-20 14:23:07 +09:00
Dean Herbert 0f5eff1230 Merge branch 'master' into mania-edit-disable-sv 2023-09-01 19:08:48 +09:00
Dan Balasescu c8f42f73e8 Adjust mania hit windows with gameplay rate 2023-08-24 11:17:41 +09:00
Dan Balasescu a2fd7707a1 Allow toggling SVs in the editor 2023-08-18 18:55:24 +09:00
Dan Balasescu 5678db4e70 Fix test + cleanup 2023-08-15 19:42:32 +09:00
Dan Balasescu e34a9a0001 Disable hold end conversion for mania HoldOff mod 2023-08-15 19:30:40 +09:00
Dan Balasescu ad51f880e0 Remove overrides on DC/NC mods 2023-04-10 17:49:29 +09:00
Dan Balasescu 15f6bc155e Add progressive score multiplier for HT 2023-04-10 13:35:48 +09:00
Dan Balasescu c923482976 Add progressive score multiplier for DT 2023-04-10 13:31:48 +09:00
Dylan Nantz e23c565c84 code quality 2023-01-11 14:28:11 -05:00
Dylan Nantz 1f4e0303f7 add mania FadeIn mod configuration 2023-01-11 14:13:29 -05:00
Dean Herbert efded323e4 Rename variables and avoid the need for a property 2023-01-09 16:49:38 +09:00
Dylan Nantz b8fbd68e32 reduce mania hidden mod precision 2023-01-06 11:39:41 -05:00
Dylan Nantz 4a1a023f9e Code quality improvements 2022-12-20 13:33:33 -05:00
Dylan Nantz 42dbb0bfd0 fix formatting 2022-12-19 19:24:38 -05:00
Dylan Nantz c200e77994 Add mania hidden mod configuration 2022-12-19 18:31:28 -05:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dan Balasescu 37407293aa Adjust target and hold off mod multipliers 2022-11-01 17:57:20 +09:00
Salman Ahmed 84fdd2e107 Improve flashlight display on break periods 2022-10-11 17:16:57 +03:00
o-dasher f3e25eacad Removes unnecessary setting sources specifications 2022-09-27 09:25:58 -04:00
o-dasher 537796c3a1 Cleanup mod bindings 2022-09-25 15:49:22 -04:00
Dean Herbert a215d009fe Update `Remove`/`RemoveRange`/`RemoveAll` calls in line with framework changes 2022-08-29 15:57:40 +09:00
Nao c940f5abcb
Merge branch 'master' into ruleset-localization 2022-08-14 15:17:44 -04:00
Dean Herbert e5e9841652 Apply multiple other mod debuffs as decided in pull request discussion 2022-08-12 18:58:09 +09:00
naoei 3e38baca3c Change ruleset mod description types 2022-08-10 16:09:11 -04:00
為什麼 4120c20968 Remove the nullable disable annotation in the Mania ruleset. 2022-07-27 22:24:02 +08:00
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert 0cac935939 Shorten class name of `ModCreatedReplayUser` 2022-03-31 11:34:23 +09:00
Dean Herbert 4b2c01a8c1 Bring all mod implementations up-to-date 2022-03-29 16:59:03 +09:00
Dean Herbert d2d88015e3 Update all cinema/autoplay mods to specify the system user ID 2022-03-28 22:22:56 +09:00
Bartłomiej Dach 82f9ad63f5
Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
Dean Herbert ddc8094a75 Update description 2022-02-02 13:34:23 +09:00
Spooghetti420 b75c08c9ab
Improve beat length logic
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-01 13:36:36 +00:00