RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix `TestScenePresentScore` sharing metadata/difficulty across multiple beatmaps

This commit is contained in:
Dean Herbert 2022-01-10 13:03:25 +09:00
parent 6251713796
commit fa7dddcf3c
1 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
osu.Game.Tests/Visual/Navigation/TestScenePresentScore.cs
View File

@ -8,6 +8,7 @@
using osu.Framework.Screens;
using osu.Framework.Testing;
using osu.Game.Beatmaps;
using osu.Game.Online.API;
using osu.Game.Rulesets;
using osu.Game.Rulesets.Mania;
using osu.Game.Rulesets.Osu;
@ -28,14 +29,6 @@ public class TestScenePresentScore : OsuGameTestScene
{
AddStep("import beatmap", () =>
{
var difficulty = new BeatmapDifficulty();
var metadata = new BeatmapMetadata
{
Artist = "SomeArtist",
AuthorString = "SomeAuthor",
Title = "import"
};
beatmap = Game.BeatmapManager.Import(new BeatmapSetInfo
{
Hash = Guid.NewGuid().ToString(),
@ -45,19 +38,29 @@ public class TestScenePresentScore : OsuGameTestScene
new BeatmapInfo
{
OnlineID = 1 * 1024,
Metadata = metadata,
BaseDifficulty = difficulty,
Metadata = new BeatmapMetadata
{
Artist = "SomeArtist",
AuthorString = "SomeAuthor",
Title = "import"
},
BaseDifficulty = new BeatmapDifficulty(),
Ruleset = new OsuRuleset().RulesetInfo
},
new BeatmapInfo
{
OnlineID = 1 * 2048,
Metadata = metadata,
BaseDifficulty = difficulty,
Metadata = new BeatmapMetadata
{
Artist = "SomeArtist",
AuthorString = "SomeAuthor",
Title = "import"
},
BaseDifficulty = new BeatmapDifficulty(),
Ruleset = new OsuRuleset().RulesetInfo
},
}
}).GetResultSafely().Value;
}).GetResultSafely()?.Value;
});
}
@ -130,7 +133,8 @@ private Func<ScoreInfo> importScore(int i, RulesetInfo ruleset = null)
Hash = Guid.NewGuid().ToString(),
OnlineID = i,
BeatmapInfo = beatmap.Beatmaps.First(),
Ruleset = ruleset ?? new OsuRuleset().RulesetInfo
Ruleset = ruleset ?? new OsuRuleset().RulesetInfo,
User = new GuestUser(),
}).GetResultSafely().Value;
});