diff --git a/osu.Game/Screens/Play/DimmableStoryboard.cs b/osu.Game/Screens/Play/DimmableStoryboard.cs
index 73b4153601..f8cedddfbe 100644
--- a/osu.Game/Screens/Play/DimmableStoryboard.cs
+++ b/osu.Game/Screens/Play/DimmableStoryboard.cs
@@ -20,6 +20,14 @@ namespace osu.Game.Screens.Play
private readonly Storyboard storyboard;
private DrawableStoryboard drawableStoryboard;
+ ///
+ /// Whether the storyboard is considered finished.
+ ///
+ ///
+ /// This is true by default in here, until an actual drawable storyboard is loaded, in which case it'll bind to it.
+ ///
+ public IBindable HasStoryboardEnded = new BindableBool(true);
+
public DimmableStoryboard(Storyboard storyboard)
{
this.storyboard = storyboard;
@@ -63,7 +71,5 @@ namespace osu.Game.Screens.Play
Add(storyboard);
OverlayLayerContainer.Add(storyboard.OverlayLayer.CreateProxy());
}
-
- public IBindable HasStoryboardEnded = new BindableBool(true);
}
}
diff --git a/osu.Game/Storyboards/Drawables/DrawableStoryboard.cs b/osu.Game/Storyboards/Drawables/DrawableStoryboard.cs
index abfb4598ec..a9a8b8a4ac 100644
--- a/osu.Game/Storyboards/Drawables/DrawableStoryboard.cs
+++ b/osu.Game/Storyboards/Drawables/DrawableStoryboard.cs
@@ -91,7 +91,7 @@ namespace osu.Game.Storyboards.Drawables
}
///
- /// Whether the storyboard has ended after the gameplay portion of the beatmap.
+ /// Whether the storyboard is considered finished.
///
public IBindable HasStoryboardEnded => hasStoryboardEnded;
diff --git a/osu.Game/Storyboards/IStoryboardElement.cs b/osu.Game/Storyboards/IStoryboardElement.cs
index 377ad57ab2..2f05e92070 100644
--- a/osu.Game/Storyboards/IStoryboardElement.cs
+++ b/osu.Game/Storyboards/IStoryboardElement.cs
@@ -18,13 +18,13 @@ namespace osu.Game.Storyboards
public static class StoryboardElementExtensions
{
///
- /// Returns the end time of this object.
+ /// Returns the end time of this storyboard element.
///
///
/// This returns the where available, falling back to otherwise.
///
- /// The object.
- /// The end time of this object.
- public static double GetEndTime(this IStoryboardElement storyboardElement) => (storyboardElement as IStoryboardElementHasDuration)?.EndTime ?? storyboardElement.StartTime;
+ /// The storyboard element.
+ /// The end time of this element.
+ public static double GetEndTime(this IStoryboardElement element) => (element as IStoryboardElementHasDuration)?.EndTime ?? element.StartTime;
}
}
diff --git a/osu.Game/Storyboards/IStoryboardElementHasDuration.cs b/osu.Game/Storyboards/IStoryboardElementHasDuration.cs
index daa0c55704..b8d3b66694 100644
--- a/osu.Game/Storyboards/IStoryboardElementHasDuration.cs
+++ b/osu.Game/Storyboards/IStoryboardElementHasDuration.cs
@@ -4,10 +4,13 @@
namespace osu.Game.Storyboards
{
///
- /// A StoryboardElement that ends at a different time than its start time.
+ /// A that ends at a different time than its start time.
///
public interface IStoryboardElementHasDuration
{
+ ///
+ /// The time at which the ends.
+ ///
double EndTime { get; }
}
}