RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-19 12:30:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore initial taps as they are generally inaccurate

Browse Source
This commit is contained in:
Dean Herbert 2022-06-01 20:57:24 +09:00
parent b88bce9b8b
commit f3f7e28353
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Screens/Edit/Timing/TapButton.cs
View File

@ -275,20 +275,23 @@ namespace osu.Game.Screens.Edit.Timing
IsHandlingTapping.Value = false; IsHandlingTapping.Value = false;
} }
private const int initial_taps_to_ignore = 4;
private const int max_taps_to_consider = 8;
private void handleTap() private void handleTap()
{ {
tapTimings.Add(Clock.CurrentTime); tapTimings.Add(Clock.CurrentTime);
if (tapTimings.Count > 8) if (tapTimings.Count > initial_taps_to_ignore + max_taps_to_consider)
tapTimings.RemoveAt(0); tapTimings.RemoveAt(0);
if (tapTimings.Count < 5) if (tapTimings.Count < initial_taps_to_ignore * 2)
{ {
bpmText.Text = new string('.', tapTimings.Count); bpmText.Text = new string('.', tapTimings.Count);
return; return;
} }
double bpm = Math.Round(60000 / ((tapTimings.Last() - tapTimings.First()) / (tapTimings.Count - 1))); double bpm = Math.Round(60000 / ((tapTimings.Last() - tapTimings.Skip(initial_taps_to_ignore).First()) / (tapTimings.Count - initial_taps_to_ignore - 1)));
bpmText.Text = $"{bpm} BPM"; bpmText.Text = $"{bpm} BPM";