RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use LargeTextureStore for all online texture retrieval 

Until now, many online textures were retrieved via the default texture store, which causes them to never be removed from GPU memory. It also has a performance overhead due to mipmap generation (which will be avoided via ppy/osu-framework#1885.
This commit is contained in:
Dean Herbert 2018-09-09 02:41:47 +09:00
parent 6c150c9ed7
commit f149a66a4d
7 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/OsuGameBase.cs
View File

@ -108,7 +108,9 @@ private void load()
dependencies.Cache(contextFactory = new DatabaseContextFactory(Host.Storage));
dependencies.Cache(new LargeTextureStore(new TextureLoaderStore(new NamespacedResourceStore<byte[]>(Resources, @"Textures"))));
var largeStore = new LargeTextureStore(new TextureLoaderStore(new NamespacedResourceStore<byte[]>(Resources, @"Textures")));
largeStore.AddStore(new TextureLoaderStore(new OnlineStore()));
dependencies.Cache(largeStore);
dependencies.CacheAs(this);
dependencies.Cache(LocalConfig);

4
osu.Game/Overlays/MedalSplash/DrawableMedal.cs
View File

@ -118,9 +118,9 @@ public DrawableMedal(Medal medal)
}
[BackgroundDependencyLoader]
private void load(OsuColour colours, TextureStore textures)
private void load(OsuColour colours, TextureStore textures, LargeTextureStore largeTextures)
{
medalSprite.Texture = textures.Get(medal.ImageUrl);
medalSprite.Texture = largeTextures.Get(medal.ImageUrl);
medalGlow.Texture = textures.Get(@"MedalSplash/medal-glow");
description.Colour = colours.BlueLight;
}

2
osu.Game/Overlays/Profile/Header/BadgeContainer.cs
View File

@ -176,7 +176,7 @@ public DrawableBadge(Badge badge)
}
[BackgroundDependencyLoader]
private void load(TextureStore textures)
private void load(LargeTextureStore textures)
{
Child = new Sprite
{

2
osu.Game/Overlays/Profile/Sections/Recent/MedalIcon.cs
View File

@ -30,7 +30,7 @@ public MedalIcon(string slug)
}
[BackgroundDependencyLoader]
private void load(TextureStore textures)
private void load(LargeTextureStore textures)
{
sprite.Texture = textures.Get(url);
}

2
osu.Game/Screens/Ranking/ResultsPageScore.cs
View File

@ -368,7 +368,7 @@ public UserHeader(User user)
}
[BackgroundDependencyLoader]
private void load(TextureStore textures)
private void load(LargeTextureStore textures)
{
if (!string.IsNullOrEmpty(user.CoverUrl))
cover.Texture = textures.Get(user.CoverUrl);

2
osu.Game/Users/Avatar.cs
View File

@ -24,7 +24,7 @@ public Avatar(User user = null)
}
[BackgroundDependencyLoader]
private void load(TextureStore textures)
private void load(LargeTextureStore textures)
{
if (textures == null)
throw new ArgumentNullException(nameof(textures));

2
osu.Game/Users/UserCoverBackground.cs
View File

@ -18,7 +18,7 @@ public UserCoverBackground(User user)
}
[BackgroundDependencyLoader]
private void load(TextureStore textures)
private void load(LargeTextureStore textures)
{
if (textures == null)
throw new ArgumentNullException(nameof(textures));