Re-privatise start time bindable

This commit is contained in:
smoogipoo 2020-11-09 21:51:58 +09:00
parent 33c3b07101
commit ec8b726ea8

View File

@ -100,7 +100,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
/// </remarks> /// </remarks>
protected virtual float SamplePlaybackPosition => 0.5f; protected virtual float SamplePlaybackPosition => 0.5f;
public readonly Bindable<double> StartTimeBindable = new Bindable<double>(); private readonly Bindable<double> startTimeBindable = new Bindable<double>();
private readonly BindableList<HitSampleInfo> samplesBindable = new BindableList<HitSampleInfo>(); private readonly BindableList<HitSampleInfo> samplesBindable = new BindableList<HitSampleInfo>();
private readonly Bindable<bool> userPositionalHitSounds = new Bindable<bool>(); private readonly Bindable<bool> userPositionalHitSounds = new Bindable<bool>();
private readonly Bindable<int> comboIndexBindable = new Bindable<int>(); private readonly Bindable<int> comboIndexBindable = new Bindable<int>();
@ -150,7 +150,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
{ {
base.LoadComplete(); base.LoadComplete();
StartTimeBindable.BindValueChanged(_ => updateState(State.Value, true)); startTimeBindable.BindValueChanged(_ => updateState(State.Value, true));
comboIndexBindable.BindValueChanged(_ => updateComboColour(), true); comboIndexBindable.BindValueChanged(_ => updateComboColour(), true);
updateState(ArmedState.Idle, true); updateState(ArmedState.Idle, true);
@ -188,7 +188,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
AddNestedHitObject(drawableNested); AddNestedHitObject(drawableNested);
} }
StartTimeBindable.BindTo(HitObject.StartTimeBindable); startTimeBindable.BindTo(HitObject.StartTimeBindable);
if (HitObject is IHasComboInformation combo) if (HitObject is IHasComboInformation combo)
comboIndexBindable.BindTo(combo.ComboIndexBindable); comboIndexBindable.BindTo(combo.ComboIndexBindable);
@ -213,7 +213,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
if (!hasHitObjectApplied) if (!hasHitObjectApplied)
return; return;
StartTimeBindable.UnbindFrom(HitObject.StartTimeBindable); startTimeBindable.UnbindFrom(HitObject.StartTimeBindable);
if (HitObject is IHasComboInformation combo) if (HitObject is IHasComboInformation combo)
comboIndexBindable.UnbindFrom(combo.ComboIndexBindable); comboIndexBindable.UnbindFrom(combo.ComboIndexBindable);