From ebd778da2de92377a1e1c874f294d73d0b90494a Mon Sep 17 00:00:00 2001
From: Salman Ahmed <email@iisalman.me>
Date: Thu, 12 Dec 2019 12:48:07 +0300
Subject: [PATCH] More test splitting

---
 .../Skins/TestSceneSkinConfigurationLookup.cs | 25 ++++++++++++++-----
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/osu.Game.Tests/Skins/TestSceneSkinConfigurationLookup.cs b/osu.Game.Tests/Skins/TestSceneSkinConfigurationLookup.cs
index fe96cbd633..8808cf2185 100644
--- a/osu.Game.Tests/Skins/TestSceneSkinConfigurationLookup.cs
+++ b/osu.Game.Tests/Skins/TestSceneSkinConfigurationLookup.cs
@@ -117,9 +117,8 @@ namespace osu.Game.Tests.Skins
             });
         }
 
-        [TestCase(false)]
-        [TestCase(true)]
-        public void TestEmptyComboColours(bool allowFallback)
+        [Test]
+        public void TestEmptyComboColours()
         {
             AddStep("Add custom combo colours to source1", () => source1.Configuration.ComboColours = new List<Color4>
             {
@@ -127,11 +126,25 @@ namespace osu.Game.Tests.Skins
                 new Color4(55, 110, 166, 255),
                 new Color4(75, 125, 175, 255),
             });
-            AddStep("Disallow default colours fallback in source2", () => source2.Configuration.AllowDefaultComboColoursFallback = allowFallback);
 
-            AddAssert($"Check retrieved combo colours from {(allowFallback ? "source1" : "fallback source")}", () =>
+            AddAssert("Check retrieved combo colours is skin default colours", () =>
+                requester.GetConfig<GlobalSkinConfiguration, IReadOnlyList<Color4>>(GlobalSkinConfiguration.ComboColours)?.Value?.SequenceEqual(SkinConfiguration.DefaultComboColours) ?? false);
+        }
+
+        [Test]
+        public void TestEmptyComboColoursNoFallback()
+        {
+            AddStep("Add custom combo colours to source1", () => source1.Configuration.ComboColours = new List<Color4>
             {
-                var expectedColours = allowFallback ? SkinConfiguration.DefaultComboColours : source1.Configuration.ComboColours;
+                new Color4(100, 150, 200, 255),
+                new Color4(55, 110, 166, 255),
+                new Color4(75, 125, 175, 255),
+            });
+            AddStep("Disallow default colours fallback in source2", () => source2.Configuration.AllowDefaultComboColoursFallback = false);
+
+            AddAssert("Check retrieved combo colours from source1", () =>
+            {
+                var expectedColours = source1.Configuration.ComboColours;
                 return requester.GetConfig<GlobalSkinConfiguration, IReadOnlyList<Color4>>(GlobalSkinConfiguration.ComboColours)?.Value?.SequenceEqual(expectedColours) ?? false;
             });
         }