RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change conditional used to decide legacy judgement animation to match stable 

In stable, the type of legacy judgement to show is based on the presence
of particle textures in the skin. We were using the skin version
instead, which turns out to be incorrect and not what some user skins
expect.

Closes #11078.
This commit is contained in:
Dean Herbert 2021-01-15 14:51:26 +09:00
parent abfc5f24a3
commit ebbc32adfa
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Skinning/LegacySkin.cs
View File

@ -378,8 +378,12 @@ public override Drawable GetDrawableComponent(ISkinComponent component)
// kind of wasteful that we throw this away, but should do for now.
if (createDrawable() != null)
{
if (Configuration.LegacyVersion > 1)
return new LegacyJudgementPieceNew(resultComponent.Component, createDrawable, getParticleTexture(resultComponent.Component));
var particle = getParticleTexture(resultComponent.Component);
if (particle != null)
{
return new LegacyJudgementPieceNew(resultComponent.Component, createDrawable, particle);
}
else
return new LegacyJudgementPieceOld(resultComponent.Component, createDrawable);
}