RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use property instead of type checking

This commit is contained in:
Craftplacer 2020-05-08 02:09:37 +02:00
parent c412afe35b
commit e6ad28a1cb
4 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Desktop/Updater/SquirrelUpdateManager.cs
View File

@ -22,6 +22,8 @@ namespace osu.Desktop.Updater
{
public class SquirrelUpdateManager : osu.Game.Updater.UpdateManager
{
public override bool CanPerformUpdate => true;
private UpdateManager updateManager;
private NotificationOverlay notificationOverlay;

4
osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs
View File

@ -25,8 +25,8 @@ private void load(Storage storage, OsuConfigManager config, OsuGameBase game)
Bindable = config.GetBindable<ReleaseStream>(OsuSetting.ReleaseStream),
});
// We shouldn't display the button for the base UpdateManager (without updating logic)
if (updateManager != null && updateManager.GetType() != typeof(UpdateManager))
// We should only display the button for UpdateManagers that do update the client
if (updateManager != null && updateManager.CanPerformUpdate)
{
Add(new SettingsButton
{

2
osu.Game/Updater/SimpleUpdateManager.cs
View File

@ -19,6 +19,8 @@ namespace osu.Game.Updater
/// </summary>
public class SimpleUpdateManager : UpdateManager
{
public override bool CanPerformUpdate => true;
private string version;
[Resolved]

2
osu.Game/Updater/UpdateManager.cs
View File

@ -17,6 +17,8 @@ namespace osu.Game.Updater
/// </summary>
public class UpdateManager : CompositeDrawable
{
public virtual bool CanPerformUpdate => false;
[Resolved]
private OsuConfigManager config { get; set; }