RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-02 11:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

add check for preview time setting

Browse Source
This commit is contained in:
cdwcgt 2023-01-19 00:37:36 +09:00
parent 0f3a586738
commit e5eab72aeb
No known key found for this signature in database
GPG Key ID: 144396D01095C3A2
2 changed files with 67 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Rulesets/Edit/BeatmapVerifier.cs
View File

@ -36,6 +36,9 @@ namespace osu.Game.Rulesets.Edit
new CheckUnsnappedObjects(),
new CheckConcurrentObjects(),
new CheckZeroLengthObjects(),
// Timing
new CheckPreviewTime(),
};
public IEnumerable<Issue> Run(BeatmapVerifierContext context)

64
osu.Game/Rulesets/Edit/Checks/CheckPreviewTime.cs Normal file
View File

@ -0,0 +1,64 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic;
using osu.Game.Beatmaps;
using osu.Game.Rulesets.Edit.Checks.Components;
namespace osu.Game.Rulesets.Edit.Checks
{
public class CheckPreviewTime : ICheck
{
public CheckMetadata Metadata => new CheckMetadata(CheckCategory.Timing, "Check Preview Time Consistency");
public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[]
{
new IssueTemplatePreviewTimeConflict(this),
new IssueTemplateHasNoPreviewTime(this),
};
public IEnumerable<Issue> Run(BeatmapVerifierContext context)
{
var diffList = context.Beatmap.BeatmapInfo.BeatmapSet?.Beatmaps ?? new List<BeatmapInfo>();
int previewTime = context.Beatmap.BeatmapInfo.Metadata.PreviewTime;
if (previewTime == -1)
{
yield return new IssueTemplateHasNoPreviewTime(this).Create();
}
foreach (var diff in diffList)
{
if (diff.Equals(context.Beatmap.BeatmapInfo))
{
continue;
}
if (diff.Metadata.PreviewTime != previewTime)
{
yield return new IssueTemplatePreviewTimeConflict(this).Create(diff.DifficultyName);
}
}
}
public class IssueTemplatePreviewTimeConflict : IssueTemplate
{
public IssueTemplatePreviewTimeConflict(ICheck check)
: base(check, IssueType.Warning, "Audio preview time conflicts with {0} diff")
{
}
public Issue Create(string diffName) => new Issue(this, diffName);
}
public class IssueTemplateHasNoPreviewTime : IssueTemplate
{
public IssueTemplateHasNoPreviewTime(ICheck check)
: base(check, IssueType.Warning, "A preview point for this map is not set. Consider settings one from the Timing menu")
{
}
public Issue Create() => new Issue(this);
}
}
}