From db6a9c97172ec8418633f62fe2e8ebcc901b6605 Mon Sep 17 00:00:00 2001
From: Joehu <madamba.joehu@outlook.com>
Date: Sun, 12 Jul 2020 22:06:17 -0700
Subject: [PATCH] Move null check to menu item addition
---
osu.Game/Online/Leaderboards/LeaderboardScore.cs | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/osu.Game/Online/Leaderboards/LeaderboardScore.cs b/osu.Game/Online/Leaderboards/LeaderboardScore.cs
index 40323c325e..b60d71cfe7 100644
--- a/osu.Game/Online/Leaderboards/LeaderboardScore.cs
+++ b/osu.Game/Online/Leaderboards/LeaderboardScore.cs
@@ -376,8 +376,8 @@ namespace osu.Game.Online.Leaderboards
{
List<MenuItem> items = new List<MenuItem>();
- if (score.Mods.Length > 0 && modsContainer.Any(s => s.IsHovered))
- items.Add(new OsuMenuItem("Use these mods", MenuItemType.Highlighted, getMods));
+ if (score.Mods.Length > 0 && modsContainer.Any(s => s.IsHovered) && songSelect != null)
+ items.Add(new OsuMenuItem("Use these mods", MenuItemType.Highlighted, () => songSelect.Mods.Value = score.Mods));
if (score.ID != 0)
items.Add(new OsuMenuItem("Delete", MenuItemType.Destructive, () => dialogOverlay?.Push(new LocalScoreDeleteDialog(score))));
@@ -385,11 +385,5 @@ namespace osu.Game.Online.Leaderboards
return items.ToArray();
}
}
-
- private void getMods()
- {
- if (songSelect != null)
- songSelect.Mods.Value = score.Mods;
- }
}
}